Re: [SSSD] [PATCH] BUILD: fix chmake not to generate warning

[Pavel Reichl]

On 02/27/2015 04:29 PM, Lukas Slebodnik wrote:
>  On (25/02/15 18:22), Pavel Reichl wrote:
> >> On (25/02/15 11:20), Pavel Reichl wrote:
> >>> On 02/25/2015 09:05 AM, Jakub Hrozek wrote:
> >>>> On Tue, Feb 24, 2015 at 04:11:28PM -0500, Stephen Gallagher wrote:
> >>>>> Ack to all the patches. Good work!
> >>>> CI passed:http://sssd-ci.duckdns.org/logs/job/8/12/summary.html
> >>>> Pushed to master:
> >>>>      * 889706cbc739358c2a0aac2ba6bc054fdc8e048b
> >>>>      * b6840554b4eeda395f5460a56df2eac1f3f97397
> >>>>      * 18372712592b30638772afb5b7e15bfca92c2058
> >>>>      * 4a5a18f489f4d19aa0571528a7f0c7a8d35ac83f
> >>>>      * 4706958e7505ce279f06cb2bf413eb38ee8f114c
> >>>>      * de0b510a1919b3952e983babf5b37ac499233a2a
> >>>>      * dc4c30bae512c0b45ff925d9e998337f8fe97e94
> >>>>      * e4796d5ed8e08be7f3767e12753389b18a2ce9f0
> >>>>      * 03e9d9d6c1d8768a6f70217bababd82de29bc770
> >>>>      * a63b368a025a61edf41a3d5ce34f325b03295cf6
> >>>>      * 887edd6b7c53fde44eb9f9060e09db5cd981ba37
> >>>>      * 9eabaad5e0f3f20a6bcec0629342584c244a79bc
> >>>>      * d6c3de740c7bed8b007805d6a313220d8d974ee5
> >>>>      * 36458f3054020f046c4a9b81d0112c7ca2e1be1c
> >>>>      * 4e0404ca1b19830dc0f729e59efd5bbd0a9d6103
> >>>> _______________________________________________
> >>>> sssd-devel mailing list
> >>>> sssd-devel(a)lists.fedorahosted.org
> >>>> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> >>> if I remove patch: 'SPEC: Build python3 bindings on available
> platforms'
> >>>
> >>> I'm able to successfully call reconfig, but chmake fails for me with
> >>> following:
> >>>
> >>>   CC       src/providers/ad/libsss_ad_common_la-ad_domain_info.lo
> >>>   CC       src/providers/ad/libsss_ad_common_la-ad_sudo.lo
> >>>   CCLD     libsss_ad_common.la
> >>>   CC       src/tools/_py2sss_la-sss_sync_ops.lo
> >>> In file included from /usr/include/stdint.h:25:0,
> >>>                  from
> >>> /usr/lib/gcc/x86_64-redhat-linux/4.9.2/include/stdint.h:9,
> >>>                  from /usr/include/tevent.h:31,
> >>>                  from ../src/tools/sss_sync_ops.c:21:
> >>> /usr/include/features.h:328:4: error: #warning _FORTIFY_SOURCE requires
> >>> compiling with optimization (-O) [-Werror=cpp]
> >>> #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
> >>>     ^
> >>> cc1: all warnings being treated as errors
> >> I think thiw warning is obvious macro _FORTIFY_SOURCE is used without
> >> optimization.
> >>
> >> macro _FORTIFY_SOURCE is defined as a part of PYTHON2_CFLAGS PYTHON3_CFLAGS
> >>
> >> @see python-config --cflags
> >>       python3-config --cflags
> >>
> >> grep "FORTIFY_SOURCE" config.log
> >> PYTHON2_CFLAGS='-I/usr/include/python2.7 -I/usr/include/python2.7
> -fno-strict-aliasing -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
> -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64
> -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall
> -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
> --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC
> -fwrapv'
> >> PYTHON3_CFLAGS='-I/usr/include/python3.4m -I/usr/include/python3.4m 
> -Wno-unused-result -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
> -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches 
> -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv  -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DNDEBUG
> -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
> -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64
> -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv'
> >>
> >>
> >> The problem is with bash function chmake. It turns off optimization.
> >> It should also undefine macro _FORTIFY_SOURCE
> >>
> >> next version work well
> >> make V=0 CFLAGS+="-ggdb3 -O0 -Wp,-U_FORTIFY_SOURCE"
> >>
> >> LS
> > Thanks! Please see attached patch.
>  >From 1ebad3c7cbeb3a99ecbb6a54027916e7b4748fc4 Mon Sep 17 00:00:00 2001
> > From: Pavel Reichl <preichl(a)redhat.com&gt;
> > Date: Wed, 25 Feb 2015 12:06:07 -0500
> > Subject: [PATCH] BUILD: fix chmake not to generate warning
> >
> > compiling with optimization (-O) [-Werror=cpp]
> >
> > The problem is with bash function chmake. It turns off optimization.
> > It should also undefine macro _FORTIFY_SOURCE
> > ---
> > contrib/fedora/bashrc_sssd | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/contrib/fedora/bashrc_sssd b/contrib/fedora/bashrc_sssd
> > index
> 7301b520c6b0e9487e94f3855a2eb2ec2468f15f..c4a8aed5e9f017a93abd9eb68e1288223308b851 100644
> > --- a/contrib/fedora/bashrc_sssd
> > +++ b/contrib/fedora/bashrc_sssd
> > @@ -78,7 +78,8 @@ SSS_WARNINGS='-Wall \
> > # them. This builds with optimizations turned off and GDB debugging symbols.
> > chmake()
> > {
> > -    make V=0 CFLAGS+="-ggdb3 -O0 $SSS_WARNINGS ${SSS_WERROR-}" \
> > +    make V=0 \
> > +         CFLAGS+="-ggdb3 -O0 $SSS_WARNINGS ${SSS_WERROR-}
> -Wp,-U_FORTIFY_SOURCE" \
>  It would be good if "-O0" and "-Wp,-U_FORTIFY_SOURCE" were together.
>
>  Please explain in commit message why it was added.
>  You can also add generated warning.
>
>  Summary:
>  it is best practice to have verbose explanation of simple message.
>  unless it is obvious.
>
>  LS
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/mailman/listinfo/sssd-devel 
OK, I'll amend the
message. I pasted the original message but failed to 
notice that it started with '#' - which is symbol for ignored comments 
in git message