Sumit,
I've attached a new version of the patch with the changes you suggested.
just some minor nitpicks:
- please reformat the commit message to use multiple lines not longer than 80 characters
Fixed.
- can you rename SSS_SOURCES to SSS_CRYPT_SOURCES
Thats what I meant to do in the first place. Fixed.
- can you update the comment at the beginning of crypto_sha512crypt.c so that it is clear that this file uses calls from libcrypto and not from libnss3
Done.
- please fix the following whitespace issues:
Applying: Added option to use libcrypto instead of NSS. /tmp/sssd/.git/rebase-apply/patch:117: trailing whitespace. [ --enable-crypto Use OpenSSL crypto instead of NSS], /tmp/sssd/.git/rebase-apply/patch:271: trailing whitespace.
/tmp/sssd/.git/rebase-apply/patch:292: trailing whitespace. * The final result will be added to the first context. */ /tmp/sssd/.git/rebase-apply/patch:147: new blank line at EOF.
warning: 4 lines add whitespace errors.
I ran the last version of the patch through git apply and I only received 3 errors. I fixed everything I could find and now git apply is giving me no errors.
Cheers, George McCollister