On 03/23/2015 11:12 AM, Jakub Hrozek wrote:
On Fri, Feb 27, 2015 at 07:13:37PM +0200, Nikolai Kondrashov wrote:
> Hi everyone,
>
> This is my attempt to add basic integration tests. There are almost no tests
> there at the moment and this is mostly about the infrastructure and the way we
> might do it.
>
> I will be glad to answer any questions and receive any comments or
> suggestions. I'm sure I did a lot of things in a wrong way :)
>
> Thank you!
>
> CI:
http://sssd-ci.duckdns.org/logs/job/8/40/summary.html
>
> Nick
I checked the build system changes since Michal requested another
reviwer there.
Thanks, Jakub!
> +if ENABLE_INTGCHECK
> +intgcheck:
> + set -e; \
> + rm -Rf intg; \
> + $(MKDIR_P) intg/bld; \
> + : Use /hopefully/ short prefix to keep D-Bus socket path short; \
I admit I don't know what are these lines that start with a colon?
This is a void command, similar to "true". From the "SHELL BUILTIN
COMMANDS"
in Bash manual:
: [arguments]
No effect; the command does nothing beyond expanding arguments
and performing any specified redirections. A zero exit code is
returned.
It is also in POSIX:
http://pubs.opengroup.org/onlinepubs/009695399/utilities/colon.html
I used it as a substitute for comments, assuming that comments can't appear
there, but it seems I was wrong. A command can't *start* with a comment
(according to Automake), but can contain them otherwise.
I can replace these with "#", but e.g. vim will highlight the rest of the
command as comment then.
> +AM_CONDITIONAL([HAVE_PYTHON3], [test x"$PYTHON3" !=
x])
I think the HAVE_PYTHON changes should be in a separate patch.
Sure, will do.
> +root:
> + $(MKDIR_P) -m 0700 root/.dbus-keyrings
Can we add a comment why we need the dbus-keyring directory?
Yes, but here we can only use ":" (or similar) before the command.
Otherwise we'll get this from Automake:
src/tests/intg/Makefile.am:23: error: '#' comment at start of rule is
unportable
We can put the comment above the rule, but it wouldn't be exactly appropriate.
> + PATH="$$(dirname -- $(SLAPD)):$$PATH" \
Interesting ^, is slapd typically out of $PATH?
Yes, it's in /usr/sbin, which is not supposed to be in a regular user's PATH.
Nick