On Tue, 08 Feb 2011 07:21:46 -0500
Stephen Gallagher <sgallagh(a)redhat.com> wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/07/2011 10:11 AM, Simo Sorce wrote:
>
> While looking at the previous patch I saw that we were still using
> the sss_nss_ prefix for a number of functions that are used by both
> the pam and nss responders. Changed the prefix to sss_cli_ so it is
> more clear those functions are not nss specific.
>
Nack. If we're going to change these, we should be changing their
return types from nss_status to something neutral as well.
I thought about that when changing the names of the functions. But it
would be a much more intrusive patch. Although if you are ok with that
I can give it a go.
Simo.
--
Simo Sorce * Red Hat, Inc * New York