-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/23/2010 07:50 AM, Jakub Hrozek wrote:
On 02/23/2010 01:29 PM, Stephen Gallagher wrote:
> Nack.
> ldap_id_cleanup_users_done():
> If the cleanup_groups_send subreq creation fails, you do not set
> err. This means that the error you print will indicate EOK. That's
> confusing to someone trying to debug. Also, please eliminate one or the
> other of the DEBUG messages within the fail label. They are redundant.
Thanks for the review, new patch is attached.
Ack.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkuD1Q0ACgkQeiVVYja6o6PYtACgoPLI9JKwmqR1U7J/XeykcAES
sXYAn0o12qoMbalRX3GHBQk6F3iu5KoE
=nOz2
-----END PGP SIGNATURE-----