-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 04/11/2011 07:01 AM, Jakub Hrozek wrote:
The first patch fixes
https://bugzilla.redhat.com/show_bug.cgi?id=694444
by not detecting duplicates at all.
Ack.
The second patch is an optimization. Since it is possible that the
list
of servers contains duplicates now, the code marks all duplicates when
setting a server status, too. I'm submitting it as a separate patch
because it might be easier to push only one of them if QE thinks they
have the capacity to test only one of them for the stable 1.5 branch.
Nack.
While it's not as if we call this function often, it seems
counter-intuitive to me that we'd be looping through all the server
lists (which could be arbitrarily long, if we're using SRV records) on
every state update, rather than just eating this cost once when adding
new servers to the list.
In other words, we should do a duplicate check before calling
create_fo_server() and skip creating it if the name and port matches.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAk2jJykACgkQeiVVYja6o6OY4gCdHKflwcyJGAassfkq/63K7dpw
pMIAnR+DWPA3QcPNDQXDVUh48fJ6Kzzx
=VrIL
-----END PGP SIGNATURE-----