-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/11/2009 06:13 AM, Sumit Bose wrote:
Hi,
with this patch the client sends its PID to sssd. This is at least
needed by the krb5 provider if the client PID should be part of the
credential cache file.
bye,
Sumit
------------------------------------------------------------------------
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
I'm not a huge fan of the assignment in extract_uint32_t.
Isn't
*var = (uint32_t)body[*c]);
the same, or does that throw typecast warnings?
If the latter, then I'd prefer that it at least be written as:
*var = *(uint32_t *)&body[*c];
Using array notation gives an implication I don't like.
Same comment about array notation use in add_uint32_t_item.
Also, don't we need to bump the protocol version if we're adding new
mandatory arguments?
- --
Stephen Gallagher
RHCE 804006346421761
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkqqS3EACgkQeiVVYja6o6OvvQCgpCdn9uc8XsrMPdgJFPxIxgqa
BZkAn3dr6mYITlsKRG04KKFyjENzpXbK
=wKnD
-----END PGP SIGNATURE-----