-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/10/2011 03:13 PM, Stephen Gallagher wrote:
On 02/08/2011 10:29 AM, Simo Sorce wrote:
> ----- Original Message -----
>> On Tue, 08 Feb 2011 07:21:46 -0500
>> Stephen Gallagher <sgallagh(a)redhat.com> wrote:
>>
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> On 02/07/2011 10:11 AM, Simo Sorce wrote:
>>>>
>>>> While looking at the previous patch I saw that we were still using
>>>> the sss_nss_ prefix for a number of functions that are used by
>>>> both
>>>> the pam and nss responders. Changed the prefix to sss_cli_ so it
>>>> is
>>>> more clear those functions are not nss specific.
>>>>
>>>
>>> Nack. If we're going to change these, we should be changing their
>>> return types from nss_status to something neutral as well.
>>
>> I thought about that when changing the names of the functions. But it
>> would be a much more intrusive patch. Although if you are ok with that
>> I can give it a go.
> New patch that also changes error codes.
Ack.
Revoking my ack. Further testing reveals that this broke something in
pam_sss and auth is now failing.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAk1VQX0ACgkQeiVVYja6o6NF9QCeMyh6Rn/nI2mqxEiPTMt+kan2
pqUAn366drMgtgkKLXAz3PrQJDgPIiou
=4BTX
-----END PGP SIGNATURE-----