URL:
https://github.com/SSSD/sssd/pull/5546
Title: #5546: kcm: add GET_CRED_LIST for faster iteration
sumit-bose commented:
"""
> The feature is already covered by the current KCM integration
tests, i.e. if the krb5 client library supports the extension it will be used in the
tests. However there is no indication in the tests if the GET_CRED_LIST or
GET_CRED_UUID_LIST is used. I wonder if it would be good to have such indication to avoid
regressions on platform where we know that the extension is supported?
We can grep the logs and produce a debug message saying which operation was executed but
this does not fail the test. I think the right thing to do is to let QA write a
performance test that would be able to catch it? They just did manual verification for
[
rhbz#1876514](https://bugzilla.redhat.com/show_bug.cgi?id=)
ok
> About `KCM_MIT_OFFSET`, I think it would be worth to add a comment explaining where
this is coming from, e.g. that it is the opcode of the first call of the MIT extension.
Done.
Thanks for the update. The CI failure on rawhide does not look related, so ACK.
bye,
Sumit
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5546#issuecomment-813925536