Re: [SSSD] [PATCH] added a ASQ search API for sysdb
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/27/2009 12:45 PM, Sumit Bose wrote:
On Tue, Oct 27, 2009 at 10:27:40AM -0400, Simo Sorce wrote:
> On Mon, 2009-10-26 at 17:43 +0100, Sumit Bose wrote:
>> Hi,
>>
>> this patch adds a sysdb interface for ASQ (attribute scoped query)
>> searches. These are useful to limit searches to objects listed in
>> member/memberof attributes (this is not limited to member/memberof you
>> can take any attribute you want).
>
> The sysdb part looks good, so I'd say: ACK
>
> The tests should work fine although I have a couple of remarks on the
> style, and what is tested.
>
> The tests use a synchronous style, so in this case the _done() function
> should just get you out of the loop.
> The _recv() function should be called after the test_loop() returns.
> We are being synchronous here so no need to suffer the pain of jumping
> through functions to see the program flow.
>
> Also the test itself is not a request, so the request structure in this
> case should be named "req" and not "subreq".
>
> You are testing the return of only one result, it may be worth testing
> with something that will return at least 2 results to exercise the
> realloc machinery and the checks with more than one result.
>
> Simo.
>
Thanks for review. I have modified the test accordingly and fixed the
indentation in sysdb.h and sysdb_ops.c.
bye,
Sumit
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
Ack.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkrpjF4ACgkQeiVVYja6o6MXPwCeOneyKZrpKbZCFLoheMn7a/q9
wlgAn2J91VFKJm4aPAmDeN8qJX/jy+Aq
=NtiO
-----END PGP SIGNATURE-----