On Wed, Apr 29, 2015 at 06:54:43PM +0200, Jakub Hrozek wrote:
On Wed, Apr 22, 2015 at 10:24:25AM +0200, Sumit Bose wrote:
> +errno_t sss_auth_pack_2fa_blob(const char *fa1, size_t fa1_len,
> + const char *fa2, size_t fa2_len,
> + uint8_t *buf, size_t buf_len,
> + size_t *_2fa_blob_len)
Lukas would like to finish the review, so I'll just send the main
question I had since I read the patches as well -- is it wise to use
const char* here and not uint8_t? Are we sure there can't be NULL
characters in either factors? If yes, then I guess it would make sense
to use uint8_t...
Since both factors has to be entered at PAM password prompts I think we
can be sure that they are real strings.
bye,
Sumit
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel