On 11/12/2015 01:08 PM, Jakub Hrozek wrote:
On Thu, Nov 12, 2015 at 01:03:33PM +0100, Petr Cech wrote:
> >On 11/11/2015 02:28 PM, Jakub Hrozek wrote:
>> > >Hi,
>> > >
>> > >I think one of the prime reasons for #2861 was copy-pasting code. The
>> > >two attached patches reduce the code duplication and hopefully will
make
>> > >future additions to Data Provider safer.
>> > >
>> > >Ideas on different solutions are welcome!
>> > >
> >Hi Jakub,
> >
> >I am afraid that the first patch is inapplicable.
> >It is build up on 562a15a2d156b4b062acbf1f4e44e4cb7a4058d2 commit but there
> >is no such commit.
> >
> >Regards
Ah, I'm sorry I should have said earlier that the patches must be
applied atop the patches in thread called "[PATCH] Guard against invalid
DP messages".
These code refactoring patches are not that important, we can wait with
review until the other thread is pushed.
Well, I looked at thread called "[PATCH] Guard against invalid DP
messages". Those patches are still under review. So I will wait for
their pushing to the code base.
Please, ping this thread after it.
Thank you
Petr