On (28/02/15 22:24), Pavel Reichl wrote:
On 02/27/2015 05:27 PM, Lukas Slebodnik wrote:
ehlo,
I found this patch in my old branches. It still applies to sssd and remove dead code.
LS
Hello Lukas,
what I don't like about your patch is the fact that you are changing the intentions of the author of the original code.
I did not change anything. It is dead code and it's very likely compiler optimize it out anyway.
There is a BIG difference between intention of author and what code does :-)
Still there's no way how to fix function to do what was intended because we can't change the type of the parameter. At least not for sssd_krb5_locator_close() and free_exp_data().
I'm not sure whether we can modify definition of hbac_free_info(). Do you know?
We cannot change API of hbac_free_info either. It is part of public API $ nm --defined-only --dynamic /usr/lib64/libipa_hbac.so | grep free 0000000000001030 T hbac_free_info
If we are not able to change the functions to do what was intended (which we definitely can't for 2 out of 3) then I agree with you patch.
ci passed:http://sssd-ci.duckdns.org/logs/job/8/43/summary.html
LS