9:38 a.m.
URL: https://github.com/SSSD/sssd/pull/102
Author: mzidek-rh
Title: #102: Sssctl no case sensitive searches
Action: opened
PR body:
"""
Trying to get rid of branches with smaller patches. Here is one of them.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/102/head:pr102
git checkout pr102
9:44 a.m.
New subject: [sssd PR#102][comment] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
mzidek-rh commented:
"""
I need to write an intg test. So the review can wait.
"""
See the full comment at https://github.com/SSSD/sssd/pull/102#issuecomment-264207778
11:55 a.m.
New subject: [sssd PR#102][synchronized] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Author: mzidek-rh
Title: #102: Sssctl no case sensitive searches
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/102/head:pr102
git checkout pr102
11:55 a.m.
New subject: [sssd PR#102][comment] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
mzidek-rh commented:
"""
Regression test was added
"""
See the full comment at https://github.com/SSSD/sssd/pull/102#issuecomment-264518150
6:18 a.m.
New subject: [sssd PR#102][+Changes requested] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
Label: +Changes requested
7:08 a.m.
New subject: [sssd PR#102][synchronized] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Author: mzidek-rh
Title: #102: Sssctl no case sensitive searches
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/102/head:pr102
git checkout pr102
7:09 a.m.
New subject: [sssd PR#102][comment] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
mzidek-rh commented:
"""
Just updated the patches.
"""
See the full comment at https://github.com/SSSD/sssd/pull/102#issuecomment-265736056
7:24 a.m.
New subject: [sssd PR#102][-Changes requested] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
Label: -Changes requested
7:24 a.m.
New subject: [sssd PR#102][comment] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
mzidek-rh commented:
"""
I see I forgot to remove the changes requested label. Doing so now.
"""
See the full comment at https://github.com/SSSD/sssd/pull/102#issuecomment-266430057
4:46 a.m.
New subject: [sssd PR#102][comment] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
jhrozek commented:
"""
Except for the single question about the first patch to make sure I understand why we
needed the change, the patches look good to me. CI is pending.
"""
See the full comment at https://github.com/SSSD/sssd/pull/102#issuecomment-267002949
4:51 a.m.
New subject: [sssd PR#102][comment] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
jhrozek commented:
"""
Actually, the tests don't pass on RHEL-6, because the subprocess module is too old
there:
http://sssd-ci.duckdns.org/logs/job/59/14/rhel6/ci-build-debug/ci-make-in...
I think just using subprocess.call would solve the issue.
"""
See the full comment at https://github.com/SSSD/sssd/pull/102#issuecomment-267003994
4:51 a.m.
New subject: [sssd PR#102][+Changes requested] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
Label: +Changes requested
8:35 a.m.
New subject: [sssd PR#102][synchronized] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Author: mzidek-rh
Title: #102: Sssctl no case sensitive searches
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/102/head:pr102
git checkout pr102
12:07 p.m.
New subject: [sssd PR#102][-Changes requested] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
Label: -Changes requested
12:14 p.m.
New subject: [sssd PR#102][comment] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
mzidek-rh commented:
"""
I pushed it to CI, but the RHEL 6 build took too long time, so I canceled it. Here is the
partial result (the rawhide fail is unrelated):
http://sssd-ci.duckdns.org/logs/job/59/15/summary.html
Here is CI result for RHEL 6 only that I pushed separately:
http://sssd-ci.duckdns.org/logs/job/59/16/summary.html
Combined together, it passed :)
"""
See the full comment at https://github.com/SSSD/sssd/pull/102#issuecomment-267110123
3:59 p.m.
New subject: [sssd PR#102][comment] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
jhrozek commented:
"""
Thank you, since the only issue in the set was related to the CI failure, I'm acking
the set..
"""
See the full comment at https://github.com/SSSD/sssd/pull/102#issuecomment-267170164
3:59 p.m.
New subject: [sssd PR#102][+Accepted] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
Label: +Accepted
3:46 a.m.
New subject: [sssd PR#102][closed] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Author: mzidek-rh
Title: #102: Sssctl no case sensitive searches
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/102/head:pr102
git checkout pr102
3:46 a.m.
New subject: [sssd PR#102][comment] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
jhrozek commented:
"""
* 35ecfab87a24031e55798b22975e02832ee0f2ad
* 715abb607540945cc82355e94712da7ac9746a67
* d6e875c49d6be650a03fc14f00a680734b23ef66
* 867bb85ecc8117aa8bdde9add0df8857cf87236e
"""
See the full comment at https://github.com/SSSD/sssd/pull/102#issuecomment-267284828
3:46 a.m.
New subject: [sssd PR#102][-Accepted] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
Label: -Accepted
3:46 a.m.
New subject: [sssd PR#102][+Pushed] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
Label: +Pushed
3:18 a.m.
New subject: [sssd PR#102][comment] Sssctl no case sensitive searches
URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches
lslebodn commented:
"""
On (15/12/16 01:46), Jakub Hrozek wrote:
* 35ecfab87a24031e55798b22975e02832ee0f2ad
* 715abb607540945cc82355e94712da7ac9746a67
* d6e875c49d6be650a03fc14f00a680734b23ef66
* 867bb85ecc8117aa8bdde9add0df8857cf87236e
I pushed patches also to 1.14 becuase I wanted to backport
test src/tests/intg/test_sssctl.py there for #109
sssd-1-14:
* d079a3551f16887fd201ed2656bd1e233440e750
* b252f8858fbf73f00a3010915c39ff237b556948
* e336dafd2108e6141799b76b899d7bba84f2bfe0
* 08c0b31f7acc5204b555484c867c684b600ef167
BTW do we want the 1st patch also to LTM branch?
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/102#issuecomment-270863045
2673
days inactive
2709
days old
sssd-devel@lists.fedorahosted.org
21 comments
1 participants
participants (1)
-
fidencio