URL: https://github.com/SSSD/sssd/pull/573 Author: sumit-bose Title: #573: winbind idmap plugin: fix detection Action: opened
PR body: """ Currently when compiling the detection code for the idmap interface version only SMBCLIENT_CFLAGS are used. Since libsmbclient does not use NTSTATUS the cflags do not contain '-DHAVE_IMMEDIATE_STRUCTURES=1' which make NTSTATUS to a struct instead of an integer. Since Samba itself might be complied with this define (it typically is) we have to make sure we use it as well. Otherwise the test program might crash on platforms where this change changes the calling convention as well.
Related to https://pagure.io/SSSD/sssd/issue/3741 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/573/head:pr573 git checkout pr573
URL: https://github.com/SSSD/sssd/pull/573 Title: #573: winbind idmap plugin: fix detection
fidencio commented: """ Ack!
Build passed on all supported platforms! """
See the full comment at https://github.com/SSSD/sssd/pull/573#issuecomment-390393258
URL: https://github.com/SSSD/sssd/pull/573 Title: #573: winbind idmap plugin: fix detection
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/573 Title: #573: winbind idmap plugin: fix detection
fidencio commented: """ master: 095bbe1 """
See the full comment at https://github.com/SSSD/sssd/pull/573#issuecomment-390393643
URL: https://github.com/SSSD/sssd/pull/573 Author: sumit-bose Title: #573: winbind idmap plugin: fix detection Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/573/head:pr573 git checkout pr573
URL: https://github.com/SSSD/sssd/pull/573 Title: #573: winbind idmap plugin: fix detection
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/573 Title: #573: winbind idmap plugin: fix detection
Label: -Accepted
sssd-devel@lists.fedorahosted.org
-
fidencio -
sumit-bose