On Mon, Feb 18, 2013 at 03:03:27PM +0100, Milan Cejnar wrote:
Function usage() in tools_util.c now correctly appends new line
character
with popt error messages.
https://fedorahosted.org/sssd/ticket/1756
This patch changes function usage() in tools_util.c which is used by
BAD_POPT_PARAMS macro.
Since BAD_POPT_PARAMS macro is called by multiple functions in multiple
files with both custom messages termited with \n as well as popt messages
which are not terminated by default, this patch offers a correction by
checking the string just before printing out to console and printing out
additional \n if new line wasn't present.
-----------
The second patch
- includes previously omitted brackets after if condition
- uses only one fprint()f call instead of two
Hi,
please reply to the original thread with follow up patches and squash
the follow up patch into the original one using git rebase -i for
instance.
See
https://fedorahosted.org/sssd/wiki/DevelTutorials it might get you
started. Feel also free to ping any of us on the #sssd channel on
FreeNode IRC.