URL: https://github.com/SSSD/sssd/pull/148 Author: lslebodn Title: #148: SYSTEMD: Update journald drop-in file Action: opened
PR body: """ We changed type forking into type notify as part of commit d4063e9a21a4e203bee7e0a0144fa8cabb14cc46. But we forgot to update template drop-in file for logging into journald. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/148/head:pr148 git checkout pr148
URL: https://github.com/SSSD/sssd/pull/148 Title: #148: SYSTEMD: Update journald drop-in file
fidencio commented: """ Patch looks fine. May I ask why the type notify required interactive mode? Would make sense to also add the explanation to the commit message?
Patch is good to go, but I'm adding the "Changes Request" label till I get the answer about whether makes sense adding the answer to the commit message. """
See the full comment at https://github.com/SSSD/sssd/pull/148#issuecomment-277939388
URL: https://github.com/SSSD/sssd/pull/148 Title: #148: SYSTEMD: Update journald drop-in file
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/148 Title: #148: SYSTEMD: Update journald drop-in file
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/148 Title: #148: SYSTEMD: Update journald drop-in file
lslebodn commented: """ Because `man 5 systemd.service` says that.: ``` Behavior of notify is similar to simple; however, it is expected that the daemon sends a notification message via sd_notify(3) ``` and type simple is really simple because it does not call fork
``` If set to simple (the default if neither Type= nor BusName=, but ExecStart= are specified), it is expected that the process configured with ExecStart= is the main process of the service. In this mode, if the process offers functionality to other processes on the system, its communication channels should be installed before the daemon is started up (e.g. sockets set up by systemd, via socket activation), as systemd will immediately proceed starting follow-up units. ```
"""
See the full comment at https://github.com/SSSD/sssd/pull/148#issuecomment-277966548
URL: https://github.com/SSSD/sssd/pull/148 Title: #148: SYSTEMD: Update journald drop-in file
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/148 Title: #148: SYSTEMD: Update journald drop-in file
lslebodn commented: """ master: * 7b4704a10958bb7d3390db9eff863875d2b643f7
sssd-1-14: * 14fe5a922c07da4c95feb65d1455d7f89d9e0f86
sssd-1-13: * 5e8474c2dc38c6c2e148db0d8ea9814bc6d5f275
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/148#issuecomment-278001247
URL: https://github.com/SSSD/sssd/pull/148 Title: #148: SYSTEMD: Update journald drop-in file
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/148 Author: lslebodn Title: #148: SYSTEMD: Update journald drop-in file Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/148/head:pr148 git checkout pr148
sssd-devel@lists.fedorahosted.org