[sssd PR#5776][opened] kcm: replace existing credentials to avoid unnecessary ccache growth

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5776
Author: pbrezina
 Title: #5776: kcm: replace existing credentials to avoid unnecessary ccache growth
Action: opened

PR body:
"""
Currently, we just append input credential to the ccache. This however make
the ccache grow over time as credentials expires and more control 
credentials are stored.

Now we remove or credentials that are the same and overwrite them with the
input credential.

Resolves: https://github.com/SSSD/sssd/issues/5775

:fixes: KCM now replace the old credential with new one when storing
 an update credential that is however already present in the ccache
 to avoid unnecessary growth of the ccache.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5776/head:pr5776
git checkout pr5776

[sssd PR#5776][+Waiting for review] kcm: replace existing credentials to avoid unnecessary ccache growth

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5776
Title: #5776: kcm: replace existing credentials to avoid unnecessary ccache growth

Label: +Waiting for review

[sssd PR#5776][comment] kcm: replace existing credentials to avoid unnecessary ccache growth

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5776
Title: #5776: kcm: replace existing credentials to avoid unnecessary ccache growth

pbrezina commented:
"""
@simo5 Simo, I believe the KCM performance as good enough and it is not hit by the users anymore (I didn't see any bug reports lately). This should avoid piling up the `refresh_time` credentials, avoiding the ccache growth so the overall performance should be even better. Would you mind testing this? I know you were hitting the issue as well.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5776#issuecomment-914282870

[sssd PR#5776][synchronized] kcm: replace existing credentials to avoid unnecessary ccache growth

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5776
Author: pbrezina
 Title: #5776: kcm: replace existing credentials to avoid unnecessary ccache growth
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5776/head:pr5776
git checkout pr5776

[sssd PR#5776][synchronized] kcm: replace existing credentials to avoid unnecessary ccache growth

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5776
Author: pbrezina
 Title: #5776: kcm: replace existing credentials to avoid unnecessary ccache growth
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5776/head:pr5776
git checkout pr5776

[sssd PR#5776][comment] kcm: replace existing credentials to avoid unnecessary ccache growth

[simo5]

URL: https://github.com/SSSD/sssd/pull/5776
Title: #5776: kcm: replace existing credentials to avoid unnecessary ccache growth

simo5 commented:
"""
Testing the f34 packages you have provided me, will report if anything's wrong with them.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5776#issuecomment-923177105

[sssd PR#5776][comment] kcm: replace existing credentials to avoid unnecessary ccache growth

[simo5]

URL: https://github.com/SSSD/sssd/pull/5776
Title: #5776: kcm: replace existing credentials to avoid unnecessary ccache growth

simo5 commented:
"""
Saw no issues, LGTM
"""

See the full comment at https://github.com/SSSD/sssd/pull/5776#issuecomment-933509682

[sssd PR#5776][comment] kcm: replace existing credentials to avoid unnecessary ccache growth

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/5776
Title: #5776: kcm: replace existing credentials to avoid unnecessary ccache growth

justin-stephenson commented:
"""
Ack from my side.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5776#issuecomment-933805865

[sssd PR#5776][+Accepted] kcm: replace existing credentials to avoid unnecessary ccache growth

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/5776
Title: #5776: kcm: replace existing credentials to avoid unnecessary ccache growth

Label: +Accepted

[sssd PR#5776][-Waiting for review] kcm: replace existing credentials to avoid unnecessary ccache growth

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/5776
Title: #5776: kcm: replace existing credentials to avoid unnecessary ccache growth

Label: -Waiting for review

[sssd PR#5776][+Ready to push] kcm: replace existing credentials to avoid unnecessary ccache growth

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5776
Title: #5776: kcm: replace existing credentials to avoid unnecessary ccache growth

Label: +Ready to push

[sssd PR#5776][comment] kcm: replace existing credentials to avoid unnecessary ccache growth

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5776
Title: #5776: kcm: replace existing credentials to avoid unnecessary ccache growth

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5776

* `master`
    * 55c5de2d5c84721ca733e2b593894ffe904cdfb4 - kcm: replace existing credentials to avoid unnecessary ccache growth
    * aca2e08ba7546b043865e132ac55a034c0e82092 - krb5: remove unused mem_ctx from get_krb5_data_from_cred()

"""

See the full comment at https://github.com/SSSD/sssd/pull/5776#issuecomment-934228507

[sssd PR#5776][+Pushed] kcm: replace existing credentials to avoid unnecessary ccache growth

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5776
Title: #5776: kcm: replace existing credentials to avoid unnecessary ccache growth

Label: +Pushed

[sssd PR#5776][-Accepted] kcm: replace existing credentials to avoid unnecessary ccache growth

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5776
Title: #5776: kcm: replace existing credentials to avoid unnecessary ccache growth

Label: -Accepted

[sssd PR#5776][-Ready to push] kcm: replace existing credentials to avoid unnecessary ccache growth

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5776
Title: #5776: kcm: replace existing credentials to avoid unnecessary ccache growth

Label: -Ready to push

[sssd PR#5776][closed] kcm: replace existing credentials to avoid unnecessary ccache growth

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5776
Author: pbrezina
 Title: #5776: kcm: replace existing credentials to avoid unnecessary ccache growth
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5776/head:pr5776
git checkout pr5776