[sssd PR#5651][opened] TEST: Use absolute path for the MODPATH assertions in python tests

[mtorromeo]

URL: https://github.com/SSSD/sssd/pull/5651
Author: mtorromeo
 Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests
Action: opened

PR body:
"""
Since 2.5.0 I had these 3 tests fail with the following assertion error:

```
======================================================================
FAIL: testImport (__main__.PyHbacImport)
Import the module and assert it comes from tree
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/build/sssd/src/sssd-2.5.0/src/tests/pyhbac-test.py", line 91, in testImport
    self.assertEqual(pyhbac.__file__, MODPATH + "/pyhbac.so")
AssertionError: '/build/sssd/src/sssd-2.5.0/./tp_pyhbac_za3ox6lp/pyhbac.so' != './tp_pyhbac_za3ox6lp/pyhbac.so'
- /build/sssd/src/sssd-2.5.0/./tp_pyhbac_za3ox6lp/pyhbac.so
+ ./tp_pyhbac_za3ox6lp/pyhbac.so
```

I don't know what changed but the issue here is related to a long-standing bug [1] in `tempfile.mkdtemp` where the returned path is not absolute if the dir parameter is relative, despite the documentation saying that the returned path is always absolute.

[1] https://bugs.python.org/issue7325
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5651/head:pr5651
git checkout pr5651

[sssd PR#5651][comment] TEST: Use absolute path for the MODPATH assertions in python tests

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5651
Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests

alexey-tikhonov commented:
"""
Hi @mtorromeo,

Sorry it slipped our attention.

Taking into account #5636, wouldn't it be better to use `realpath` instead of `abspath`?
"""

See the full comment at https://github.com/SSSD/sssd/pull/5651#issuecomment-932160227

[sssd PR#5651][comment] TEST: Use absolute path for the MODPATH assertions in python tests

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5651
Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests

alexey-tikhonov commented:
"""
Sorry it fall through the cracks.

LGTM.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5651#issuecomment-932160770

[sssd PR#5651][comment] TEST: Use absolute path for the MODPATH assertions in python tests

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5651
Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests

alexey-tikhonov commented:
"""
Sorry it fell through the cracks.

LGTM.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5651#issuecomment-932160770

[sssd PR#5651][comment] TEST: Use absolute path for the MODPATH assertions in python tests

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5651
Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests

alexey-tikhonov commented:
"""
.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5651#issuecomment-932160770

[sssd PR#5651][comment] TEST: Use absolute path for the MODPATH assertions in python tests

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5651
Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests

alexey-tikhonov commented:
"""
.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5651#issuecomment-932160770

[sssd PR#5651][synchronized] TEST: Use absolute path for the MODPATH assertions in python tests

[mtorromeo]

URL: https://github.com/SSSD/sssd/pull/5651
Author: mtorromeo
 Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5651/head:pr5651
git checkout pr5651

[sssd PR#5651][comment] TEST: Use absolute path for the MODPATH assertions in python tests

[mtorromeo]

URL: https://github.com/SSSD/sssd/pull/5651
Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests

mtorromeo commented:
"""
Hi @alexey-tikhonov, I guess it would just the same for me.

I updated and rebased the MR
"""

See the full comment at https://github.com/SSSD/sssd/pull/5651#issuecomment-932461522

[sssd PR#5651][comment] TEST: Use absolute path for the MODPATH assertions in python tests

[mtorromeo]

URL: https://github.com/SSSD/sssd/pull/5651
Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests

mtorromeo commented:
"""
Hi @alexey-tikhonov, I guess it would work just the same for me.

I updated and rebased the MR
"""

See the full comment at https://github.com/SSSD/sssd/pull/5651#issuecomment-932461522

[sssd PR#5651][synchronized] TEST: Use absolute path for the MODPATH assertions in python tests

[mtorromeo]

URL: https://github.com/SSSD/sssd/pull/5651
Author: mtorromeo
 Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5651/head:pr5651
git checkout pr5651

[sssd PR#5651][comment] TEST: Use absolute path for the MODPATH assertions in python tests

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5651
Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests

alexey-tikhonov commented:
"""
Thank you, ACK.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5651#issuecomment-933325853

[sssd PR#5651][+Accepted] TEST: Use absolute path for the MODPATH assertions in python tests

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/5651
Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests

Label: +Accepted

[sssd PR#5651][+Ready to push] TEST: Use absolute path for the MODPATH assertions in python tests

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5651
Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests

Label: +Ready to push

[sssd PR#5651][comment] TEST: Use absolute path for the MODPATH assertions in python tests

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5651
Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5651

* `master`
    * 57247096b309a9e916dd8a1c712004d08b6ee9c5 - TEST: Use absolute path for the MODPATH assertions in python tests

"""

See the full comment at https://github.com/SSSD/sssd/pull/5651#issuecomment-934228708

[sssd PR#5651][-Accepted] TEST: Use absolute path for the MODPATH assertions in python tests

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5651
Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests

Label: -Accepted

[sssd PR#5651][+Pushed] TEST: Use absolute path for the MODPATH assertions in python tests

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5651
Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests

Label: +Pushed

[sssd PR#5651][-Ready to push] TEST: Use absolute path for the MODPATH assertions in python tests

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5651
Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests

Label: -Ready to push

[sssd PR#5651][closed] TEST: Use absolute path for the MODPATH assertions in python tests

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/5651
Author: mtorromeo
 Title: #5651: TEST: Use absolute path for the MODPATH assertions in python tests
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5651/head:pr5651
git checkout pr5651