[PATCH] AD_PROVIDER: Fix constant char *

[Petr Cech]

Hello,

there is simple patch attached. Please, look at commit message.

Regards

-- 
Petr^4 Čech

[Petr Cech]

bump

-- 
Petr^4 Čech

[Sumit Bose]

On Fri, Jun 03, 2016 at 08:22:10AM +0200, Petr Cech wrote:
>  bump 
obvious ACK, just waiting for the CI to finish.

bye,
Sumit

> 
> -- 
> Petr^4 Čech
> _______________________________________________
> sssd-devel mailing list
> sssd-devel(a)lists.fedorahosted.org
> https://lists.fedorahosted.org/admin/lists/[e-mail]

[Sumit Bose]

On Fri, Jun 03, 2016 at 09:38:43AM +0200, Sumit Bose wrote:
>  On Fri, Jun 03, 2016 at 08:22:10AM +0200, Petr Cech wrote:
>  > bump
>  
>  obvious ACK, just waiting for the CI to finish. 
There are 2 failures in
http://sssd-ci.duckdns.org/logs/job/44/38/summary.html but they look
like CI issues and not related to the patch.

ACK

bye,
Sumit

> 
> bye,
> Sumit
> 
> > 
> > -- 
> > Petr^4 Čech
> > _______________________________________________
> > sssd-devel mailing list
> > sssd-devel(a)lists.fedorahosted.org
> > https://lists.fedorahosted.org/admin/lists/[e-mail]
> _______________________________________________
> sssd-devel mailing list
> sssd-devel(a)lists.fedorahosted.org
> https://lists.fedorahosted.org/admin/lists/[e-mail]

[Lukas Slebodnik]

On (03/06/16 09:38), Sumit Bose wrote:
> On Fri, Jun 03, 2016 at 08:22:10AM +0200, Petr Cech wrote:
> > bump
>
> obvious ACK, just waiting for the CI to finish.
>  
It might be a good idea to enable some compiler warning to catch such
issues.

LS

[Fabiano Fidêncio]

On Fri, Jun 3, 2016 at 2:32 PM, Lukas Slebodnik <lslebodn(a)redhat.com&gt; wrote:
>  On (03/06/16 09:38), Sumit Bose wrote:
> >On Fri, Jun 03, 2016 at 08:22:10AM +0200, Petr Cech wrote:
> >> bump
> >
> >obvious ACK, just waiting for the CI to finish.
> >
>  It might be a good idea to enable some compiler warning to catch such
>  issues. 
Using manywarnings.m4 is something desirable, I guess.
https://github.com/coreutils/gnulib/blob/master/m4/manywarnings.m4

>  LS
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/admin/lists/[e-mail] 

Best Regards,
-- 
Fabiano Fidêncio

[Jakub Hrozek]

On Fri, Jun 03, 2016 at 02:38:01PM +0200, Fabiano Fidêncio wrote:
>  On Fri, Jun 3, 2016 at 2:32 PM, Lukas Slebodnik
> <lslebodn(a)redhat.com&gt; wrote:
>  > On (03/06/16 09:38), Sumit Bose wrote:
>  >>On Fri, Jun 03, 2016 at 08:22:10AM +0200, Petr Cech wrote:
>  >>> bump
>  >>
>  >>obvious ACK, just waiting for the CI to finish.
>  >>
>  > It might be a good idea to enable some compiler warning to catch such
>  > issues.
>  
>  Using manywarnings.m4 is something desirable, I guess.
>  https://github.com/coreutils/gnulib/blob/master/m4/manywarnings.m4 
Did you try compiling sssd with these additional warnigns? I wonder how
many turn up and if there would be too many false positives to fix..

[Lukas Slebodnik]

On (03/06/16 14:38), Fabiano Fidêncio wrote:
> On Fri, Jun 3, 2016 at 2:32 PM, Lukas Slebodnik
> <lslebodn(a)redhat.com&gt; wrote:
> > On (03/06/16 09:38), Sumit Bose wrote:
> >>On Fri, Jun 03, 2016 at 08:22:10AM +0200, Petr Cech wrote:
> >>> bump
> >>
> >>obvious ACK, just waiting for the CI to finish.
> >>
> > It might be a good idea to enable some compiler warning to catch such
> > issues.
>
> Using manywarnings.m4 is something desirable, I guess.
> https://github.com/coreutils/gnulib/blob/master/m4/manywarnings.m4
>  
By default is sssd build with following flags
https://git.fedorahosted.org/cgit/sssd.git/tree/Makefile.am#n95

sssd can be also built with following extra flags
./configure CFLAGS="-Wextra -Wno-unused-parameter -Wno-sign-compare".

I would welcome any additional warnings.
I didn't check which of warnings from manywarnings.m4
are enabled by default with Wextra or Wall but I know
that some compiler warnings are not part of this "group" flags.

I am all five for enabling new warnigns.

LS

[Sumit Bose]

On Fri, Jun 03, 2016 at 04:55:15PM +0200, Lukas Slebodnik wrote:
>  On (03/06/16 14:38), Fabiano Fidêncio wrote:
>  >On Fri, Jun 3, 2016 at 2:32 PM, Lukas Slebodnik <lslebodn(a)redhat.com&gt; wrote:
>  >> On (03/06/16 09:38), Sumit Bose wrote:
>  >>>On Fri, Jun 03, 2016 at 08:22:10AM +0200, Petr Cech wrote:
>  >>>> bump
>  >>>
>  >>>obvious ACK, just waiting for the CI to finish.
>  >>>
>  >> It might be a good idea to enable some compiler warning to catch such
>  >> issues.
>  >
>  >Using manywarnings.m4 is something desirable, I guess.
>  >https://github.com/coreutils/gnulib/blob/master/m4/manywarnings.m4
>  >
>  By default is sssd build with following flags
>  https://git.fedorahosted.org/cgit/sssd.git/tree/Makefile.am#n95
>  
>  sssd can be also built with following extra flags
>  ./configure CFLAGS="-Wextra -Wno-unused-parameter -Wno-sign-compare".
>  
>  I would welcome any additional warnings.
>  I didn't check which of warnings from manywarnings.m4
>  are enabled by default with Wextra or Wall but I know
>  that some compiler warnings are not part of this "group" flags.
>  
>  I am all five for enabling new warnigns. 
+1

bye,
Sumit

> 
> LS
> _______________________________________________
> sssd-devel mailing list
> sssd-devel(a)lists.fedorahosted.org
> https://lists.fedorahosted.org/admin/lists/[e-mail]

[Fabiano Fidêncio]

On Fri, Jun 3, 2016 at 3:38 PM, Jakub Hrozek <jhrozek(a)redhat.com&gt; wrote:
>  On Fri, Jun 03, 2016 at 02:38:01PM +0200, Fabiano Fidêncio wrote:
> > On Fri, Jun 3, 2016 at 2:32 PM, Lukas Slebodnik <lslebodn(a)redhat.com&gt; wrote:
> > > On (03/06/16 09:38), Sumit Bose wrote:
> > >>On Fri, Jun 03, 2016 at 08:22:10AM +0200, Petr Cech wrote:
> > >>> bump
> > >>
> > >>obvious ACK, just waiting for the CI to finish.
> > >>
> > > It might be a good idea to enable some compiler warning to catch such
> > > issues.
> >
> > Using manywarnings.m4 is something desirable, I guess.
> > https://github.com/coreutils/gnulib/blob/master/m4/manywarnings.m4
>
>  Did you try compiling sssd with these additional warnigns? I wonder how
>  many turn up and if there would be too many false positives to fix.. 
I didn't. But I'll put it in my (not-so-short-term) TODO list..

IMO we can get rid of setting the warnings manually and start taking
advantage of the warnings.m4 and manywarnings.m4 gnulib's files.

About the possible false positives, we can have a list of "dontwarn"
warnings, just excluding the non-interesting/false positive warnings,
as we do in spice-gtk/libosinfo.

Of course, this idea shouldn't block this patch, it's just an idea for
the future :-)

Best Regards,
-- 
Fabiano Fidêncio

[Lukas Slebodnik]

On (03/06/16 13:09), Sumit Bose wrote:
> On Fri, Jun 03, 2016 at 09:38:43AM +0200, Sumit Bose wrote:
> > On Fri, Jun 03, 2016 at 08:22:10AM +0200, Petr Cech wrote:
> > > bump
> > 
> > obvious ACK, just waiting for the CI to finish.
>
> There are 2 failures in
> http://sssd-ci.duckdns.org/logs/job/44/38/summary.html but they look
> like CI issues and not related to the patch.
>
> ACK
>  
master:
* 9a6ff0851fc707f21165818f66ae926fa14d7226

LS