On (03/06/16 14:38), Fabiano FidĂȘncio wrote:
On Fri, Jun 3, 2016 at 2:32 PM, Lukas Slebodnik
<lslebodn(a)redhat.com> wrote:
> On (03/06/16 09:38), Sumit Bose wrote:
>>On Fri, Jun 03, 2016 at 08:22:10AM +0200, Petr Cech wrote:
>>> bump
>>
>>obvious ACK, just waiting for the CI to finish.
>>
> It might be a good idea to enable some compiler warning to catch such
> issues.
Using manywarnings.m4 is something desirable, I guess.
https://github.com/coreutils/gnulib/blob/master/m4/manywarnings.m4
By default is sssd build with following flags
https://git.fedorahosted.org/cgit/sssd.git/tree/Makefile.am#n95
sssd can be also built with following extra flags
./configure CFLAGS="-Wextra -Wno-unused-parameter -Wno-sign-compare".
I would welcome any additional warnings.
I didn't check which of warnings from manywarnings.m4
are enabled by default with Wextra or Wall but I know
that some compiler warnings are not part of this "group" flags.
I am all five for enabling new warnigns.
LS