[sssd PR#631][opened] nss: remove unused label

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/631
Author: fidencio
 Title: #631: nss: remove unused label
Action: opened

PR body:
"""
After 4937f2c6, Sumit noticed the following warning/breakage:

    make[2]: Leaving directory '/home/sbose/sssd/master_build/src/man'
    Making check in .
    make[2]: Entering directory '/home/sbose/sssd/master_build'
      CC       src/responder/nss/nss_protocol_grent.o
    ../src/responder/nss/nss_protocol_grent.c: In function
'nss_protocol_fill_initgr':
    ../src/responder/nss/nss_protocol_grent.c:409:1: error: label 'done' defined
but not used [-Werror=unused-label]
     done:
     ^~~~
    cc1: all warnings being treated as errors
    Makefile:17808: recipe for target 'src/responder/nss/nss_protocol_grent.o'
failed
    make[2]: *** [src/responder/nss/nss_protocol_grent.o] Error 1
    make[2]: Leaving directory '/home/sbose/sssd/master_build'

Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com&gt;
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/631/head:pr631
git checkout pr631

[sssd PR#631][comment] nss: remove unused label

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label

sumit-bose commented:
"""
I had a minor comment (see inline), please let me know if you agree or if you think that
it would be safer to keep this patch minimal.
"""

See the full comment at https://github.com/SSSD/sssd/pull/631#issuecomment-411814461

[sssd PR#631][comment] nss: remove unused label

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label

fidencio commented:
"""
I agree with your comment (but maybe I would prefer to have your suggestion as a separate
patch of this very same PR).

Would you mind pushing this as it is in order to fix the breakage asap?

(sorry for the typos and for not doing the change now, I am commiting without access to my
laptop).
"""

See the full comment at https://github.com/SSSD/sssd/pull/631#issuecomment-411817670

[sssd PR#631][synchronized] nss: remove unused label

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/631
Author: fidencio
 Title: #631: nss: remove unused label
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/631/head:pr631
git checkout pr631

[sssd PR#631][comment] nss: remove unused label

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label

fidencio commented:
"""
@sumit-bose, I've changed my mind and fully adopted your suggestion in one single
patch.
"""

See the full comment at https://github.com/SSSD/sssd/pull/631#issuecomment-411858930

[sssd PR#631][comment] nss: remove unused label

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label

sumit-bose commented:
"""
Thanks, I've started a CI run.
"""

See the full comment at https://github.com/SSSD/sssd/pull/631#issuecomment-411987087

[sssd PR#631][comment] nss: remove unused label

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label

sumit-bose commented:
"""
Ok, CI passed with an unrealated issue. ACK.
"""

See the full comment at https://github.com/SSSD/sssd/pull/631#issuecomment-412110512

[sssd PR#631][+Accepted] nss: remove unused label

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label

Label: +Accepted

[sssd PR#631][comment] nss: remove unused label

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label

fidencio commented:
"""
master:
 e8b417e
"""

See the full comment at https://github.com/SSSD/sssd/pull/631#issuecomment-412120488

[sssd PR#631][closed] nss: remove unused label

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/631
Author: fidencio
 Title: #631: nss: remove unused label
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/631/head:pr631
git checkout pr631

[sssd PR#631][+Pushed] nss: remove unused label

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label

Label: +Pushed

[sssd PR#631][-Accepted] nss: remove unused label

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label

Label: -Accepted