[sssd PR#321][opened] certmap: add OpenSSL implementation

[sumit-bose]

   URL: https://github.com/SSSD/sssd/pull/321
Author: sumit-bose
 Title: #321: certmap: add OpenSSL implementation
Action: opened

PR body:
"""
The OpenSSL 1.1 API is used but there is a short macro block which
should added the needed compatibility if and older OpenSSL version is
used.

Related to https://pagure.io/SSSD/sssd/issue/3050
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/321/head:pr321
git checkout pr321

[sssd PR#321][comment] certmap: add OpenSSL implementation

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

fidencio commented:
"""
@sumit-bose: what's the best way to test those changes?
"""

See the full comment at https://github.com/SSSD/sssd/pull/321#issuecomment-318278009

[sssd PR#321][comment] certmap: add OpenSSL implementation

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

lslebodn commented:
"""
I was testing patches with libcrypto and I noticed that `p11_child` was not build with
libcrypto.

Do we have a ticket for this?

Yes, I know it is just partially related to this PR
"""

See the full comment at https://github.com/SSSD/sssd/pull/321#issuecomment-324625426

[sssd PR#321][comment] certmap: add OpenSSL implementation

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

sumit-bose commented:
"""
@fidencio, building with libcrypto and running make check

@lslebodn, no, I think there is none, would you mind to open one and assign it to me?
"""

See the full comment at https://github.com/SSSD/sssd/pull/321#issuecomment-324638007

[sssd PR#321][comment] certmap: add OpenSSL implementation

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

lslebodn commented:
"""
>  @lslebodn, no, I think there is none, would you mind to open one and
> assign it to me?
>  
Here you are:https://pagure.io/SSSD/sssd/issue/3489

>  @fidencio, building with libcrypto and running make check
>  
because `libsss_certmap` has bunch of unit tets :-)
"""

See the full comment at https://github.com/SSSD/sssd/pull/321#issuecomment-324640290

[sssd PR#321][comment] certmap: add OpenSSL implementation

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

lslebodn commented:
"""
>  @lslebodn, no, I think there is none, would you mind to open one and
> assign it to me?
>  
Here you are:https://pagure.io/SSSD/sssd/issue/3489

>  @fidencio, building with libcrypto and running make check
>  
because `libsss_certmap` has bunch of unit tets :-)

I'm waiting for results of internal CI with non-default crypto
"""

See the full comment at https://github.com/SSSD/sssd/pull/321#issuecomment-324640290

[sssd PR#321][+Changes requested] certmap: add OpenSSL implementation

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

Label: +Changes requested

[sssd PR#321][comment] certmap: add OpenSSL implementation

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

lslebodn commented:
"""
BTW do you know what is purpose of ticket https://pagure.io/SSSD/sssd/issue/2880.
Is it duplicate of https://pagure.io/SSSD/sssd/issue/3489?
"""

See the full comment at https://github.com/SSSD/sssd/pull/321#issuecomment-325006812

[sssd PR#321][synchronized] certmap: add OpenSSL implementation

[sumit-bose]

   URL: https://github.com/SSSD/sssd/pull/321
Author: sumit-bose
 Title: #321: certmap: add OpenSSL implementation
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/321/head:pr321
git checkout pr321

[sssd PR#321][comment] certmap: add OpenSSL implementation

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

sumit-bose commented:
"""
Thank you for the review, I addressed all your comments.

About the tickets, the validation is currently done in two places, the ssh responder and
p11_child. So I think https://pagure.io/SSSD/sssd/issue/2880 is justified, even if the
solution will be to call p11_child from the ssh responder to validate the certificate
which is the solution I currently prefer.
"""

See the full comment at https://github.com/SSSD/sssd/pull/321#issuecomment-325358022

[sssd PR#321][-Changes requested] certmap: add OpenSSL implementation

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

Label: -Changes requested

[sssd PR#321][comment] certmap: add OpenSSL implementation

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

lslebodn commented:
"""
@jhrozek LGTM. I would appreciate more unit test for corner cases but that can be done
later.
"""

See the full comment at https://github.com/SSSD/sssd/pull/321#issuecomment-327109081

[sssd PR#321][comment] certmap: add OpenSSL implementation

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

lslebodn commented:
"""
@jhrozek LGTM. I would appreciate more unit test for corner cases but that can be done
later.
"""

See the full comment at https://github.com/SSSD/sssd/pull/321#issuecomment-327109081

[sssd PR#321][+Accepted] certmap: add OpenSSL implementation

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

Label: +Accepted

[sssd PR#321][comment] certmap: add OpenSSL implementation

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

jhrozek commented:
"""
Adding the accepted label as per @lslebodn 's comment.
"""

See the full comment at https://github.com/SSSD/sssd/pull/321#issuecomment-327113591

[sssd PR#321][comment] certmap: add OpenSSL implementation

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

jhrozek commented:
"""
Actually it looks like @lslebodn 's comment was meant for a different PR, removing the
Accepted label again, sorry for the spam.
"""

See the full comment at https://github.com/SSSD/sssd/pull/321#issuecomment-327118159

[sssd PR#321][-Accepted] certmap: add OpenSSL implementation

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

Label: -Accepted

[sssd PR#321][comment] certmap: add OpenSSL implementation

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

lslebodn commented:
"""
master:
* a20fb9cbd5f42a6ca895aea1b84347fdfea34b89
"""

See the full comment at https://github.com/SSSD/sssd/pull/321#issuecomment-327168880

[sssd PR#321][closed] certmap: add OpenSSL implementation

[lslebodn]

   URL: https://github.com/SSSD/sssd/pull/321
Author: sumit-bose
 Title: #321: certmap: add OpenSSL implementation
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/321/head:pr321
git checkout pr321

[sssd PR#321][+Pushed] certmap: add OpenSSL implementation

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/321
Title: #321: certmap: add OpenSSL implementation

Label: +Pushed