[sssd PR#44][opened] libwbclient-sssd: update interface to version 0.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/44
Author: sumit-bose
 Title: #44: libwbclient-sssd: update interface to version 0.13
Action: opened

PR body:
"""
This patch adds wbcCtxUnixIdsToSids() and wbcUnixIdsToSids() to SSSD's
libwbclient and implements the latter.

Resolves https://fedorahosted.org/sssd/ticket/3181
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/44/head:pr44
git checkout pr44

[sssd PR#44][comment] libwbclient-sssd: update interface to version 0.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/44
Title: #44: libwbclient-sssd: update interface to version 0.13

sumit-bose commented:
"""
On Thu, Oct 13, 2016 at 01:45:34AM -0700, fidencio wrote:
> fidencio commented on this pull request.
>
> I didn't run any kind of tests/CI/etc.
> The code looks good apart from one minor comment.
>
> I'm not moving the label to "Request changes", as the change may not be needed.
> >    case WBC_ID_TYPE_UID:
>        wbc_status = wbcUidToSid(ids[c].id.uid, &sids[c]);
>        break;
>    case WBC_ID_TYPE_GID:
>        wbc_status = wbcGidToSid(ids[c].id.gid, &sids[c]);
>        break;
>    default:
>        wbc_status = WBC_ERR_INVALID_PARAM;
>    }
>    if (!WBC_ERROR_IS_OK(wbc_status)) {
>        sids[c] = (struct wbcDomainSid) {0};
>    };
> }
> return WBC_ERR_SUCCESS;
>
> @sumit-bose,
> I didn't get why the function *always* return WBC_ERR_SUCCESS. Is it intended or shall we return the wbc_status when WBC_ERROR_IS_OK() fails?

no, this call converts a list of POSIX IDs to SIDs. If a single
translation fails the returned SID in the list is just '(struct
wbcDomainSid) {0}'. The return value of the call is just used to
indicate if something fundamentally went wrong.

HTH

bye,
Sumit

"""

See the full comment at https://github.com/SSSD/sssd/pull/44#issuecomment-253460158

[sssd PR#44][+Accepted] libwbclient-sssd: update interface to version 0.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/44
Title: #44: libwbclient-sssd: update interface to version 0.13

Label: +Accepted

[sssd PR#44][comment] libwbclient-sssd: update interface to version 0.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/44
Title: #44: libwbclient-sssd: update interface to version 0.13

fidencio commented:
"""
Okay, please, fire our CI and feel free to push the patches after CI passes.
"""

See the full comment at https://github.com/SSSD/sssd/pull/44#issuecomment-253464286

[sssd PR#44][comment] libwbclient-sssd: update interface to version 0.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/44
Title: #44: libwbclient-sssd: update interface to version 0.13

jhrozek commented:
"""
On Thu, Oct 13, 2016 at 02:35:57AM -0700, fidencio wrote:
> Okay, please, fire our CI and feel free to push the patches after CI passes.

Unfortunately in internal RH CI is broken at the moment (see
https://github.com/SSSD/sssd/pull/47)

"""

See the full comment at https://github.com/SSSD/sssd/pull/44#issuecomment-253474469

[sssd PR#44][comment] libwbclient-sssd: update interface to version 0.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/44
Title: #44: libwbclient-sssd: update interface to version 0.13

fidencio commented:
"""
@jhrozek: Okay, okay. I'm running CI on #47 and we can get back to this one after having that series pushed.
"""

See the full comment at https://github.com/SSSD/sssd/pull/44#issuecomment-253483989

[sssd PR#44][comment] libwbclient-sssd: update interface to version 0.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/44
Title: #44: libwbclient-sssd: update interface to version 0.13

jhrozek commented:
"""
On Thu, Oct 13, 2016 at 04:10:04AM -0700, fidencio wrote:
> @jhrozek: Okay, okay. I'm running CI on #47 and we can get back to this one after having that series pushed.

Thank you. I'm not sure myself if the patches for PR #47 are correct
(and I guess @lslebodn will have comments about the patchset in general
when he's back from vacation) but I would prefer us to unblock the build
at least. We can decide to revert the patches later if they are wrong..

"""

See the full comment at https://github.com/SSSD/sssd/pull/44#issuecomment-253484904

[sssd PR#44][comment] libwbclient-sssd: update interface to version 0.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/44
Title: #44: libwbclient-sssd: update interface to version 0.13

jhrozek commented:
"""
btw what the library exports also looks good to me:
```
objdump -T /usr/lib64/sssd/modules/libwbclient.so.0.13.0 | grep WBCLIENT_0.13
0000000000005e74 g    DF .text  000000000000001a  WBCLIENT_0.13 wbcCtxUnixIdsToSids
0000000000000000 g    DO *ABS*  0000000000000000  WBCLIENT_0.13 WBCLIENT_0.13
00000000000033ac g    DF .text  000000000000015b  WBCLIENT_0.13 wbcUnixIdsToSids
```

So I agree we can push this patch once the CI engine is back up..
"""

See the full comment at https://github.com/SSSD/sssd/pull/44#issuecomment-253543030

[sssd PR#44][comment] libwbclient-sssd: update interface to version 0.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/44
Title: #44: libwbclient-sssd: update interface to version 0.13

lslebodn commented:
"""
master:
* f3347a0c72afc75b4d829e9981d1bac6b05a8306

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/44#issuecomment-253857506

[sssd PR#44][+Pushed] libwbclient-sssd: update interface to version 0.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/44
Title: #44: libwbclient-sssd: update interface to version 0.13

Label: +Pushed

[sssd PR#44][-Accepted] libwbclient-sssd: update interface to version 0.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/44
Title: #44: libwbclient-sssd: update interface to version 0.13

Label: -Accepted

[sssd PR#44][closed] libwbclient-sssd: update interface to version 0.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/44
Author: sumit-bose
 Title: #44: libwbclient-sssd: update interface to version 0.13
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/44/head:pr44
git checkout pr44