6:35 a.m.
URL: https://github.com/SSSD/sssd/pull/517
Author: sumit-bose
Title: #517: Fix two memory leaks in the AD provider
Action: opened
PR body:
"""
I found two memory leaks in the AD provider, one is triggered by every user
lookup the other during an initgroups request with tokenGroups.
To verify this just lookup a larger number of AD users, I took 500, or call
'id' for each of the users. When checking the memory consumption before and
after e.g. with 'ps' the increased memory usage should become obvious.
To analyse where the memory is used 'talloc_report_full' help. You can call it
directly inside of gdb or just use Pavel's 'sss-talloc-report' from
https://github.com/pbrezina/sssd-dev-utils.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/517/head:pr517
git checkout pr517
7:01 a.m.
New subject: [sssd PR#517][comment] Fix two memory leaks in the AD provider
URL: https://github.com/SSSD/sssd/pull/517
Title: #517: Fix two memory leaks in the AD provider
lslebodn commented:
"""
retest this please
"""
See the full comment at https://github.com/SSSD/sssd/pull/517#issuecomment-366440086
6:13 a.m.
New subject: [sssd PR#517][comment] Fix two memory leaks in the AD provider
URL: https://github.com/SSSD/sssd/pull/517
Title: #517: Fix two memory leaks in the AD provider
jhrozek commented:
"""
I think the patches look good in general, but the tests don't compile at the moment:
```
/home/remote/jhrozek/devel/sssd/src/tests/cmocka/test_ad_common.c: In function
‘test_user_conn_list’:
/home/remote/jhrozek/devel/sssd/src/tests/cmocka/test_ad_common.c:775:35: warning: passing
argument 2 of ‘ad_user_conn_list’ from incompatible pointer type
[-Wincompatible-pointer-types]
test_ctx->dom);
^~~~~~~~
In file included from
/home/remote/jhrozek/devel/sssd/src/tests/cmocka/test_ad_common.c:40:0:
/home/remote/jhrozek/devel/sssd/src/providers/ad/ad_common.c:1405:1: note: expected
‘struct ad_id_ctx *’ but argument is of type ‘struct sss_domain_info *’
ad_user_conn_list(TALLOC_CTX *mem_ctx,
^~~~~~~~~~~~~~~~~
/home/remote/jhrozek/devel/sssd/src/tests/cmocka/test_ad_common.c:774:17: error: too few
arguments to function ‘ad_user_conn_list’
conn_list = ad_user_conn_list(test_ctx->ad_ctx,
^~~~~~~~~~~~~~~~~
In file included from
/home/remote/jhrozek/devel/sssd/src/tests/cmocka/test_ad_common.c:40:0:
/home/remote/jhrozek/devel/sssd/src/providers/ad/ad_common.c:1405:1: note: declared here
ad_user_conn_list(TALLOC_CTX *mem_ctx,
^~~~~~~~~~~~~~~~~
/home/remote/jhrozek/devel/sssd/src/tests/cmocka/test_ad_common.c:784:35: warning: passing
argument 2 of ‘ad_user_conn_list’ from incompatible pointer type
[-Wincompatible-pointer-types]
test_ctx->subdom);
^~~~~~~~
In file included from
/home/remote/jhrozek/devel/sssd/src/tests/cmocka/test_ad_common.c:40:0:
/home/remote/jhrozek/devel/sssd/src/providers/ad/ad_common.c:1405:1: note: expected
‘struct ad_id_ctx *’ but argument is of type ‘struct sss_domain_info *’
ad_user_conn_list(TALLOC_CTX *mem_ctx,
^~~~~~~~~~~~~~~~~
/home/remote/jhrozek/devel/sssd/src/tests/cmocka/test_ad_common.c:783:17: error: too few
arguments to function ‘ad_user_conn_list’
conn_list = ad_user_conn_list(test_ctx->ad_ctx,
^~~~~~~~~~~~~~~~~
In file included from
/home/remote/jhrozek/devel/sssd/src/tests/cmocka/test_ad_common.c:40:0:
/home/remote/jhrozek/devel/sssd/src/providers/ad/ad_common.c:1405:1: note: declared here
ad_user_conn_list(TALLOC_CTX *mem_ctx,
^~~~~~~~~~~~~~~~~
```
"""
See the full comment at https://github.com/SSSD/sssd/pull/517#issuecomment-366674462
6:13 a.m.
New subject: [sssd PR#517][+Changes requested] Fix two memory leaks in the AD provider
URL: https://github.com/SSSD/sssd/pull/517
Title: #517: Fix two memory leaks in the AD provider
Label: +Changes requested
8:07 a.m.
New subject: [sssd PR#517][synchronized] Fix two memory leaks in the AD provider
URL: https://github.com/SSSD/sssd/pull/517
Author: sumit-bose
Title: #517: Fix two memory leaks in the AD provider
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/517/head:pr517
git checkout pr517
8:10 a.m.
New subject: [sssd PR#517][comment] Fix two memory leaks in the AD provider
URL: https://github.com/SSSD/sssd/pull/517
Title: #517: Fix two memory leaks in the AD provider
sumit-bose commented:
"""
oopsy, fixed version pushed.
"""
See the full comment at https://github.com/SSSD/sssd/pull/517#issuecomment-366703772
8:12 a.m.
New subject: [sssd PR#517][-Changes requested] Fix two memory leaks in the AD provider
URL: https://github.com/SSSD/sssd/pull/517
Title: #517: Fix two memory leaks in the AD provider
Label: -Changes requested
10:50 a.m.
New subject: [sssd PR#517][synchronized] Fix two memory leaks in the AD provider
URL: https://github.com/SSSD/sssd/pull/517
Author: sumit-bose
Title: #517: Fix two memory leaks in the AD provider
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/517/head:pr517
git checkout pr517
10:51 a.m.
New subject: [sssd PR#517][comment] Fix two memory leaks in the AD provider
URL: https://github.com/SSSD/sssd/pull/517
Title: #517: Fix two memory leaks in the AD provider
sumit-bose commented:
"""
Sorry, there were some unrelated changes in the last commit.
"""
See the full comment at https://github.com/SSSD/sssd/pull/517#issuecomment-366748803
8:18 a.m.
New subject: [sssd PR#517][+Accepted] Fix two memory leaks in the AD provider
URL: https://github.com/SSSD/sssd/pull/517
Title: #517: Fix two memory leaks in the AD provider
Label: +Accepted
8:18 a.m.
New subject: [sssd PR#517][comment] Fix two memory leaks in the AD provider
URL: https://github.com/SSSD/sssd/pull/517
Title: #517: Fix two memory leaks in the AD provider
jhrozek commented:
"""
The internal CI is still down, but honestly I see no reason to wait for it, there's
nothing that could work here but wouldn't work on other distros.
ACK
"""
See the full comment at https://github.com/SSSD/sssd/pull/517#issuecomment-367340345
8:34 a.m.
New subject: [sssd PR#517][comment] Fix two memory leaks in the AD provider
URL: https://github.com/SSSD/sssd/pull/517
Title: #517: Fix two memory leaks in the AD provider
jhrozek commented:
"""
* master:
* e6ad16e05f42a1678a8c6cd14eb54ca75b8d775e
* db52090e33b8f1747b7d77bab64ab8c9f9f5ecc2
* sssd-1-13:
* ed16240f4bc36e984962412a41e4494c662b618d
"""
See the full comment at https://github.com/SSSD/sssd/pull/517#issuecomment-367344996
8:34 a.m.
New subject: [sssd PR#517][closed] Fix two memory leaks in the AD provider
URL: https://github.com/SSSD/sssd/pull/517
Author: sumit-bose
Title: #517: Fix two memory leaks in the AD provider
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/517/head:pr517
git checkout pr517
8:34 a.m.
New subject: [sssd PR#517][+Pushed] Fix two memory leaks in the AD provider
URL: https://github.com/SSSD/sssd/pull/517
Title: #517: Fix two memory leaks in the AD provider
Label: +Pushed
2256
days inactive
2261
days old
sssd-devel@lists.fedorahosted.org
13 comments
3 participants
participants (3)
-
jhrozek -
lslebodn
-
sumit-bose