12:26 p.m.
mzidek-rh's pull request #20: "sss_override fails to export" was opened
PR body:
"""
Here is a fix + CI test for https://fedorahosted.org/sssd/ticket/3179.
Michal
"""
See the full pull-request at https://github.com/SSSD/sssd/pull/20
... or pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/20/head:pr20
git checkout pr20
4:58 a.m.
New subject: [sssd PR#20] sss_override fails to export (+Accepted)
mzidek-rh's pull request #20: "sss_override fails to export" label
*Accepted* has been added
See the full pull-request at https://github.com/SSSD/sssd/pull/20
5:17 a.m.
New subject: [sssd PR#20] sss_override fails to export (comment)
lslebodn commented on a pull request
"""
On (07/09/16 10:26), mzidek-rh wrote:
Here is a fix + CI test for
https://fedorahosted.org/sssd/ticket/3179.
Michal
You can view, comment on, or merge this pull request online at:
https://github.com/SSSD/sssd/pull/20
I have just few comments to the integration test.
IMHO, it's not enough to test just that export
and import passed. It is an incomplete test.
We need to be sure that we corretly imported all datas.
In other word, check all user attributes.
It would be good to have more descriptive name of tests.
The "test_regr_3179_override" does not say a lot.
I know there are other tests with such name
but it does not mean we need to continue in this bad habit.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/20#issuecomment-245875622
5:21 a.m.
New subject: [sssd PR#20] sss_override fails to export (comment)
mzidek-rh commented on a pull request
"""
I agree that we need better tests for sss_override, but the purpose of this test was to
catch the error in the ticket so that we do not regress. We can create a ticket to add
more comprehensive tests for sss_overide export/import as a separate effort.
"""
See the full comment at https://github.com/SSSD/sssd/pull/20#issuecomment-245876454
5:27 a.m.
New subject: [sssd PR#20] sss_override fails to export (comment)
mzidek-rh commented on a pull request
"""
Btw. I am currently working on tests for some features we do not have covered in upstream
CI. I can add test for the sss_overide after I am finished with that. But I would really
prefer not to block this fix (pbrezina confirmed it is a regression, we need the fix
asap).
"""
See the full comment at https://github.com/SSSD/sssd/pull/20#issuecomment-245877403
5:38 a.m.
New subject: [sssd PR#20] sss_override fails to export (comment)
lslebodn commented on a pull request
"""
On (09/09/16 03:27), mzidek-rh wrote:
Btw. I am currently working on tests for some features we do not have
covered
in upstream CI. I can add test for the sss_overide after I am finished with
that. But I would really prefer not to block this fix (pbrezina confirmed it
is a regression, we need the fix asap).
I am not sure whether you got my message.
It is not important for me that 'user-export' failed.
The feature is not covered by test untill we are sure
that exported data are properly imported.
Your test would pass if functionality
of user-export and user-import would be replaced with simple fucntion
e.g. return 0 or exit(0)
It means it's incomplete test. Even though the fix for the bug is correct.
And adding few more tests which will check that
user has proper (uid, name ... ) should not take
more that 15 minutes. I cannot see a conflict with ASAP.
It will take some to to get used to with TDD. :-)
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/20#issuecomment-245879419
5:59 a.m.
New subject: [sssd PR#20] sss_override fails to export (-Accepted)
mzidek-rh's pull request #20: "sss_override fails to export" label
*Accepted* has been removed
See the full pull-request at https://github.com/SSSD/sssd/pull/20
5:59 a.m.
New subject: [sssd PR#20] sss_override fails to export (+Changes requested)
mzidek-rh's pull request #20: "sss_override fails to export" label *Changes
requested* has been added
See the full pull-request at https://github.com/SSSD/sssd/pull/20
7:48 a.m.
New subject: [sssd PR#20] sss_override fails to export (synchronize)
mzidek-rh's pull request #20: "sss_override fails to export" was
synchronize
See the full pull-request at https://github.com/SSSD/sssd/pull/20
... or pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/20/head:pr20
git checkout pr20
7:50 a.m.
New subject: [sssd PR#20] sss_override fails to export (comment)
mzidek-rh commented on a pull request
"""
See the updated tests. It uses export and import and checks if override works after
import.
"""
See the full comment at https://github.com/SSSD/sssd/pull/20#issuecomment-245903519
5:35 a.m.
New subject: [sssd PR#20] sss_override fails to export (comment)
lslebodn commented on a pull request
"""
On (09/09/16 05:50), mzidek-rh wrote:
See the updated tests. It uses export and import and checks if
override works after import.
ACK for test; just waiting for CI
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/20#issuecomment-246641793
6:46 a.m.
New subject: [sssd PR#20] sss_override fails to export (comment)
lslebodn commented on a pull request
"""
On (09/09/16 05:50), mzidek-rh wrote:
See the updated tests. It uses export and import and checks if
override works after import.
ACK
http://sssd-ci.duckdns.org/logs/job/53/24/summary.html
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/20#issuecomment-246656016
6:53 a.m.
New subject: [sssd PR#20] sss_override fails to export (comment)
lslebodn commented on a pull request
"""
On (09/09/16 05:50), mzidek-rh wrote:
See the updated tests. It uses export and import and checks if
override works after import.
master:
* 1c72723cde8bea0d390b928c7cd29e48e7a7deab
* 07e7683f5a86991feaa764e2055116554ada1b93
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/20#issuecomment-246657182
5:03 a.m.
New subject: [sssd PR#20] sss_override fails to export (-Changes requested)
mzidek-rh's pull request #20: "sss_override fails to export" label *Changes
requested* has been removed
See the full pull-request at https://github.com/SSSD/sssd/pull/20
5:03 a.m.
New subject: [sssd PR#20] sss_override fails to export (+Pushed)
mzidek-rh's pull request #20: "sss_override fails to export" label *Pushed*
has been added
See the full pull-request at https://github.com/SSSD/sssd/pull/20
5:16 a.m.
New subject: [sssd PR#20] sss_override fails to export (closed)
mzidek-rh's pull request #20: "sss_override fails to export" was closed
See the full pull-request at https://github.com/SSSD/sssd/pull/20
... or pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/20/head:pr20
git checkout pr20
2790
days inactive
2797
days old
sssd-devel@lists.fedorahosted.org
15 comments
1 participants
participants (1)
-
fidencio