On 3/6/20 1:19 AM, Till Maas wrote:
Hi Rich,
Am Fr., 6. März 2020 um 01:06 Uhr schrieb Rich Megginson
<rmeggins(a)redhat.com <mailto:rmeggins@redhat.com>>:
I'm looking at adding support for tox to all of the roles that don't
currently use tox. For example, here is diff of .travis.yml from kdump:
script:
- - molecule --version
- - ansible --version
- - molecule lint
- - molecule syntax
- - molecule test
+ - ./.travis/runtox
and here is the relevant section from tox:
[tox]
envlist =
black, pylint, flake8,
py{26,27,36,37,38},
custom
molecule is not in this list. Should we add molecule to this list?
Seems like we should, or tox conversion will regress travis CI behavior.
we use a tox plugin in the template that makes it use a different set of
tests in Travis:
https://github.com/linux-system-roles/template/blob/master/tox.ini#L263
I don't see molecule listed there. Is there some sort of hardcoded
config in travis or the tox-travis plugin that knows to always run molecule?
I do see that the network role CI in the py35 env runs molecule
https://travis-ci.com/linux-system-roles/network/jobs/292652710 but I
don't see what triggers that.
The envlist at the start is meant for environments that are run by
default by the user. Since molecule requires special configuration to be
able to run docker, it does not make sense to add it there IMHO. If
wanted, developers can still run it with "tox -e molecule".
Kind regards
Till
--
Till Maas
He/His/Him
Associate Manager, Software Engineering
NetworkManager, Nmstate, Ansible RHEL Networking System Role
Red Hat GmbH,
http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Laurie Krebs, Michael O'Neill,
Thomas Savage
_______________________________________________
systemroles mailing list -- systemroles(a)lists.fedorahosted.org
To unsubscribe send an email to systemroles-leave(a)lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/systemroles@lists.fedorahost...