From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: lvs-stats: Analyze sosreport lvm commands output
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/79698/2//COMMIT_MSG
Commit Message:
Line 6:
Line 7: lvs-stats: Analyze sosreport lvm commands output
Line 8:
Line 9: This tool reads the lvs sos command output, and print a report about the
Line 10: found logical volumes.
> I agree, but I don't have time to integrate it into sos report, and having
I'm asking that you place it in /usr/libexec/vdsm and ship it in vdsm.rpm.
Then someone else, say Ala, can call this utility from within our sos report plugin.
Line 11:
Line 12: Here is an examle run:
Line 13:
Line 14: $ cd sosreport-hostname.*/sos_commands/lvm2
--
To view, visit https://gerrit.ovirt.org/79698
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a172092210d02eb49d1d54de6958d3f80bcba1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Germano Veit Michel <germano(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79954 )
Change subject: net: tests: Remove func_net_ip_test.py
......................................................................
net: tests: Remove func_net_ip_test.py
There already is a module dedicated to testing static ip
configuration. Remove func_net_ip_test and move its tests
to func_static_ip_test.
Change-Id: I42af30bb7a90f71e7c2847defa4a259a1dd38127
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
D tests/network/func_net_ip_test.py
M tests/network/func_static_ip_test.py
2 files changed, 52 insertions(+), 76 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Leon Goldberg: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79954
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42af30bb7a90f71e7c2847defa4a259a1dd38127
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79951 )
Change subject: net: Introduce ipv4 config validator
......................................................................
net: Introduce ipv4 config validator
ipv4 configuration validity is shared between ovs and legacy switch
and as such should be validated prior to ovs/legacy split.
As there were some inconsistencies in the raised error codes of invalid
ip configurations, all related errors now raise ERR_BAD_ADDR.
Change-Id: Ibd2e3116249a30c917a945117022934ea87e0d29
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M lib/vdsm/network/ip/address/__init__.py
M lib/vdsm/network/ip/validator.py
M tests/network/config_network_test.py
M tests/network/ip_validator_test.py
4 files changed, 72 insertions(+), 33 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79951
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd2e3116249a30c917a945117022934ea87e0d29
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: sb validator: raise on missing sb device.
......................................................................
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/79953/20//COMMIT_MSG
Commit Message:
Line 6:
Line 7: net: sb validator: raise on missing sb device.
Line 8:
Line 9: If no southbound device was given to a bridgless network,
Line 10: raise.
> commit message is still wrong.
ok, it mentions 'bridgeless' so it is not wrong, but it is too terse.
Line 11:
Line 12: Change-Id: I6f3503faa5c84155ed667e2a474d1dc148798e35
--
To view, visit https://gerrit.ovirt.org/79953
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f3503faa5c84155ed667e2a474d1dc148798e35
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80015 )
Change subject: net: Centralize call to pre-config validation
......................................................................
net: Centralize call to pre-config validation
Introduce network.validator module, which is responsible to call all
pre-config validators.
This patch creats a new validator module for the link package and moves
the call to these validations (bond naming) to the new network.validator
module.
New pre-config validations should be called from this new module and
existing validation calls should be migrated and called from the new
module as well.
Change-Id: Icd8fab6168816cd03545f268f8402f06e1fe84d6
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/api.py
A lib/vdsm/network/link/validator.py
M lib/vdsm/network/netswitch/configurator.py
M lib/vdsm/network/netswitch/validator.py
A lib/vdsm/network/validator.py
A tests/network/link_validator_test.py
M tests/network/netswitch_test.py
7 files changed, 138 insertions(+), 53 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/80015
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd8fab6168816cd03545f268f8402f06e1fe84d6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: sb validator: raise on missing sb device.
......................................................................
Patch Set 20: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/79953/20//COMMIT_MSG
Commit Message:
Line 6:
Line 7: net: sb validator: raise on missing sb device.
Line 8:
Line 9: If no southbound device was given to a bridgless network,
Line 10: raise.
commit message is still wrong.
Line 11:
Line 12: Change-Id: I6f3503faa5c84155ed667e2a474d1dc148798e35
--
To view, visit https://gerrit.ovirt.org/79953
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f3503faa5c84155ed667e2a474d1dc148798e35
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Centralize call to pre-config validation
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/80015
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd8fab6168816cd03545f268f8402f06e1fe84d6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No