From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Openstacknet hooks must check provider type to run
......................................................................
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/80155/1//COMMIT_MSG
Commit Message:
PS1, Line 9: drive
driver
Line 9: When an openstacknet drive is installed along with another
Line 10: external network provider, its hooks were failing when an
Line 11: external network nic (non openstack) was handled.
Line 12: This patch modifies the hooks to check if the nic handled
Line 13: is of type OPENSTACK_NET_PROVIDER_TYPE before doing
which value is passed by the OVN provider? I thought that only the pluginType would differ.
Line 14: any other operation.
Line 15:
Line 16: Change-Id: Ie88b6793fde74d9cd3b6a308c75c10d02c05a627
Line 11: external network nic (non openstack) was handled.
Line 12: This patch modifies the hooks to check if the nic handled
Line 13: is of type OPENSTACK_NET_PROVIDER_TYPE before doing
Line 14: any other operation.
Line 15:
wasn't there an open bug about this?
Line 16: Change-Id: Ie88b6793fde74d9cd3b6a308c75c10d02c05a627
--
To view, visit https://gerrit.ovirt.org/80155
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie88b6793fde74d9cd3b6a308c75c10d02c05a627
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79328 )
Change subject: RPC: Add missing return statement
......................................................................
RPC: Add missing return statement
In the current code, the function _processEvent()
is not reachable, so this change does not affect anything.
But it will be reachable in subsequent patches.
It is unreachable, because the JsonRpcClient can only
receive messages from a single subscription queue and
this specific queue does not contain events,
only rpc responses
Change-Id: I17a948211ba3aa05af2be69c2a2d366aa26a9e9b
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M lib/yajsonrpc/__init__.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Nir Soffer: Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, but someone else must approve
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/79328
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17a948211ba3aa05af2be69c2a2d366aa26a9e9b
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79308 )
Change subject: RPC: Add missing return statement when handling messages
......................................................................
RPC: Add missing return statement when handling messages
Whithout the return statement, the code would access
undefined local variables.
Change-Id: I04ce4a5c6758e7bf0272ffac51f0cec89e3f6b8e
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M lib/yajsonrpc/__init__.py
1 file changed, 13 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/79308
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04ce4a5c6758e7bf0272ffac51f0cec89e3f6b8e
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79950 )
Change subject: jsonrpc tests: Discard the dependency on the network package
......................................................................
jsonrpc tests: Discard the dependency on the network package
The tests do not really need the networking connectivity functionality
and patching an inner implementation is not recommended.
This patch removes the dependency by placing a NOP at the usage.
Change-Id: I708c50567e4ec9b2c72cd34f8435ccb66aac7281
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M tests/integration/jsonRpcHelper.py
1 file changed, 17 insertions(+), 22 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Andrej Krejcir: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79950
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I708c50567e4ec9b2c72cd34f8435ccb66aac7281
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc tests: Discard the dependency on the network package
......................................................................
Patch Set 1: Code-Review+2
raising scores
--
To view, visit https://gerrit.ovirt.org/79950
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708c50567e4ec9b2c72cd34f8435ccb66aac7281
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79596 )
Change subject: tool: remove dummy bridge
......................................................................
tool: remove dummy bridge
Add a command that removes libvirt dummy bridge ;vdsmdummy;.
Also rename dummybr command to dummybr-create to keep naming consistent.
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
Change-Id: Icd78fba239b37d2c556f37c63438ee076516560b
Bug-Url: https://bugzilla.redhat.com/1430799
---
M lib/vdsm/tool/dummybr.py
M static/usr/share/man/man1/vdsm-tool.1.in
2 files changed, 66 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79596
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd78fba239b37d2c556f37c63438ee076516560b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79495 )
Change subject: tool: list/clear networks configured by VDSM
......................................................................
tool: list/clear networks configured by VDSM
Provide tools to list networks configured by VDSM and to clear
them.
This command could be called before vdsm removal to leave host
in a clean state. Typically a user would find default route network
name with `vdsm-tool list-nets` and then remove all networks but
the default route one with `vdsm-tool clear-nets --exclude-net netname`
Change-Id: I63702da4dd1c5a0328797f524734813ef251bdb6
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1430799
---
M lib/vdsm/tool/network.py
M static/usr/share/man/man1/vdsm-tool.1.in
2 files changed, 78 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79495
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63702da4dd1c5a0328797f524734813ef251bdb6
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tool: remove dummy bridge
......................................................................
Patch Set 6: Code-Review-1
my fault!
test_commit('0.10', 0, 1, False) ./lib/vdsm/tool/dummybr.py:42:38: F821 undefined name 'constants'
rc, out, err = commands.execCmd([constants.EXT_BRCTL, 'delbr', bridgeName])
--
To view, visit https://gerrit.ovirt.org/79596
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd78fba239b37d2c556f37c63438ee076516560b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: lvs-stats: Analyze sosreport lvm commands output
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/79698/2//COMMIT_MSG
Commit Message:
Line 6:
Line 7: lvs-stats: Analyze sosreport lvm commands output
Line 8:
Line 9: This tool reads the lvs sos command output, and print a report about the
Line 10: found logical volumes.
but why keep it in contrib? It seems to be simple and valuable enough to be contained in any sosreport.
Line 11:
Line 12: Here is an examle run:
Line 13:
Line 14: $ cd sosreport-hostname.*/sos_commands/lvm2
Line 49: active: 252
Line 50: open: 113
Line 51:
Line 52: Change-Id: I8a172092210d02eb49d1d54de6958d3f80bcba1e
Line 53: Bug-Url: XXX
please do not merge with this comment
--
To view, visit https://gerrit.ovirt.org/79698
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a172092210d02eb49d1d54de6958d3f80bcba1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Germano Veit Michel <germano(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes