From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79625 )
Change subject: net: Raise a meaningful exception for multiple sb nics
......................................................................
net: Raise a meaningful exception for multiple sb nics
Multiple southbound nics per network are not supported.
When decoding the kernel config, an error will occur, failing the flow.
This patch raises a meaningful exception, describing the problem to ease
the troubleshooting of errors.
Change-Id: I1afbda5550a1e45fe5dffdd14569154362242daa
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/kernelconfig.py
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79625
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1afbda5550a1e45fe5dffdd14569154362242daa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79621 )
Change subject: net: Allow QoS caps to ignore nets with multiple sb nics
......................................................................
net: Allow QoS caps to ignore nets with multiple sb nics
Multiple southbound nics per network are not supported, and when issuing
a caps request, it failed in the QoS section.
This patch allows the caps to continue by ignoring the invalid network,
reporting the error in the log.
Change-Id: Icf9aad74622262f841657d1687babea60623d065
Bug-Url: https://bugzilla.redhat.com/1470696
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/netinfo/qos.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79621
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf9aad74622262f841657d1687babea60623d065
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Raise a meaningful exception for multiple sb nics
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79625
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1afbda5550a1e45fe5dffdd14569154362242daa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Allow QoS caps to ignore nets with multiple sb nics
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79621
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf9aad74622262f841657d1687babea60623d065
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79824 )
Change subject: net: Enable LLDP on NICs
......................................................................
net: Enable LLDP on NICs
lldpad has to be configured to provide LLDP on network interfaces.
This change activates LLDP on all NICs.
Change-Id: I6cc0cc21a189bcdcff3f4ac3ad97620ed4ff8f50
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
M lib/vdsm/network/initializer.py
1 file changed, 20 insertions(+), 0 deletions(-)
Approvals:
Dominik Holler: Verified
Jenkins CI: Passed CI tests
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79824
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6cc0cc21a189bcdcff3f4ac3ad97620ed4ff8f50
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79405 )
Change subject: net: Add info lldp to lldp
......................................................................
net: Add info lldp to lldp
lldp is extended to provide informations received by LLDP.
The provided lldp information can be restricted by a filter.
The only implemented filter criteria is to restrict the lldp
information by a list of NIC names received the LLDP information.
Change-Id: I9102e4a52de954a97bf0fb7bbb6e85ffd3d992b5
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
M lib/vdsm/network/api.py
A lib/vdsm/network/lldp/info.py
2 files changed, 52 insertions(+), 0 deletions(-)
Approvals:
Dominik Holler: Verified
Jenkins CI: Passed CI tests
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79405
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9102e4a52de954a97bf0fb7bbb6e85ffd3d992b5
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79093 )
Change subject: net: Report lldp through new getLldp command
......................................................................
net: Report lldp through new getLldp command
Change-Id: I1e5e81cfbfe9c714d8173ecd6ee20f8b59bd14fe
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
M lib/vdsm/API.py
M lib/vdsm/api/vdsm-api.yml
M lib/vdsm/rpc/Bridge.py
M lib/vdsm/supervdsm_api/network.py
4 files changed, 79 insertions(+), 1 deletion(-)
Approvals:
Dominik Holler: Verified
Jenkins CI: Passed CI tests
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79093
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e5e81cfbfe9c714d8173ecd6ee20f8b59bd14fe
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78117 )
Change subject: net: Introduce the LLDPAD driver with an LLDP interface
......................................................................
net: Introduce the LLDPAD driver with an LLDP interface
The Link Layer Discovery Protocol (LLDP) is a vendor-neutral link layer
protocol in the Internet Protocol Suite used by network devices for
advertising their identity, capabilities, and neighbors on an IEEE 802
local area network, principally wired Ethernet.
This patch introduces an LLDP interface, implemented using the lldpad
service & tool.
Change-Id: Iaaa889789f7bbcc1cb3d9a9d0c8b02f1cf83bea9
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
M configure.ac
M lib/vdsm/network/Makefile.am
A lib/vdsm/network/lldp/Makefile.am
A lib/vdsm/network/lldp/__init__.py
A lib/vdsm/network/lldp/lldpad.py
A lib/vdsm/network/lldpad/Makefile.am
A lib/vdsm/network/lldpad/__init__.py
A lib/vdsm/network/lldpad/lldptool.py
M static/usr/lib/systemd/system/vdsmd.service.in
A tests/network/lldpad_test.py
M tests/network/nettestlib.py
M vdsm.spec.in
12 files changed, 587 insertions(+), 2 deletions(-)
Approvals:
Dominik Holler: Verified
Jenkins CI: Passed CI tests
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78117
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaaa889789f7bbcc1cb3d9a9d0c8b02f1cf83bea9
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80014 )
Change subject: net build: Unify module collection on the network dir
......................................................................
net build: Unify module collection on the network dir
In order to simplify and reduce the overhead when adding new modules
under the vdsm/network package, all *.py files are collected by the
makefile and all *.py* are specified in the spec.
Change-Id: I32eea60438b83c880f603794a29809b36861968a
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/Makefile.am
M vdsm.spec.in
2 files changed, 2 insertions(+), 46 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Leon Goldberg: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/80014
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32eea60438b83c880f603794a29809b36861968a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>