vdsm-patches December 2013

vdsm-patches@lists.fedorahosted.org

48 participants
493 discussions

Change in vdsm[master]: sp: asynchronous convertDomain in activateSD
by Federico Simoncelli 12 May '14

12 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: sp: asynchronous convertDomain in activateSD ...................................................................... sp: asynchronous convertDomain in activateSD Change-Id: I679a992f689ee6ae97c82c267d0da69b4f0e6725 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M vdsm/storage/hsm.py M vdsm/storage/sp.py 2 files changed, 42 insertions(+), 35 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/13634/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index ae35b11..5471c54 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -3396,7 +3396,9 @@ def upgradeStoragePool(self, spUUID, targetDomVersion): targetDomVersion = int(targetDomVersion) pool = self.getPool(spUUID) - pool._upgradePool(targetDomVersion) + # TODO: this request should become asynchronous using a task + pool._upgradeMasterDomain(targetDomVersion) + pool._upgradeRegularDomains() return {"upgradeStatus": "started"} @public diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index fe54dd9..374c948 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -119,7 +119,7 @@ Securable.__init__(self) self._formatConverter = DefaultFormatConverter() - self._domainsToUpgrade = [] + self._domainsToUpgrade = set() self.lock = threading.RLock() self._setUnsafe() self.spUUID = str(spUUID) @@ -207,14 +207,6 @@ return self._domainsToUpgrade.remove(sdUUID) - if len(self._domainsToUpgrade) == 0: - self.log.debug("All domains are upgraded, unregistering " - "from state change event") - try: - self.domainMonitor.onDomainConnectivityStateChange.\ - unregister(self._upgradeCallback) - except KeyError: - pass @unsecured def startSpm(self, prevID, prevLVER, scsiFencing, maxHostID, @@ -287,8 +279,9 @@ PMDK_SPM_ID: self.id}, __securityOverride=True) self._maxHostID = maxHostID - # Upgrade the master domain now if needed - self._upgradePool(expectedDomVersion, __securityOverride=True) + # Upgrade the master domain now + self._upgradeMasterDomain(expectedDomVersion, + __securityOverride=True) self.masterDomain.mountMaster() self.masterDomain.createMasterTree() @@ -308,6 +301,10 @@ # Once setSafe completes we are running as SPM self._setSafe() + + # Upgrade all the remaining domains + self._startUpUpgrade() + self._upgradeRegularDomains() # Mailbox issues SPM commands, therefore we start it AFTER spm # commands are allowed to run to prevent a race between the @@ -346,11 +343,17 @@ raise @unsecured + def _startUpUpgrade(self): + self.log.debug("Registering with state change event") + self.domainMonitor.onDomainConnectivityStateChange.register( + self._upgradeCallback) + + @unsecured def _shutDownUpgrade(self): self.log.debug("Shutting down upgrade process") with rmanager.acquireResource(STORAGE, "upgrade_" + self.spUUID, rm.LockType.exclusive): - domains = self._domainsToUpgrade[:] + domains = set(self._domainsToUpgrade) try: self.domainMonitor.onDomainConnectivityStateChange.unregister( self._upgradeCallback) @@ -434,7 +437,28 @@ self.spmRole = SPM_FREE - def _upgradePool(self, targetDomVersion): + def _upgradeRegularDomains(self): + with rmanager.acquireResource(STORAGE, "upgrade_" + self.spUUID, + rm.LockType.exclusive): + regularDomains = set(self.getDomains(activeOnly=True).keys()) + + try: + regularDomains.remove(self.masterDomain.sdUUID) + except ValueError: + pass + + # Removing the domains that are already in the upgrade process + sdUUIDThreadsToStart = regularDomains - self._domainsToUpgrade + + self.log.debug("Marking all domains for upgrade") + self._domainsToUpgrade.update(regularDomains) + + for sdUUID in sdUUIDThreadsToStart: + self.log.debug("Running upgrade thread for domain %s", sdUUID) + threading.Thread( + target=self._upgradeCallback, args=(sdUUID, True)).start() + + def _upgradeMasterDomain(self, targetDomVersion): with rmanager.acquireResource(STORAGE, "upgrade_" + self.spUUID, rm.LockType.exclusive): if len(self._domainsToUpgrade) > 0: @@ -446,22 +470,6 @@ with rmanager.acquireResource(STORAGE, self.masterDomain.sdUUID, rm.LockType.exclusive): self._convertDomain(self.masterDomain, str(targetDomVersion)) - - self.log.debug("Marking all domains for upgrade") - self._domainsToUpgrade = self.getDomains(activeOnly=True).keys() - try: - self._domainsToUpgrade.remove(self.masterDomain.sdUUID) - except ValueError: - pass - - self.log.debug("Registering with state change event") - self.domainMonitor.onDomainConnectivityStateChange.register( - self._upgradeCallback) - self.log.debug("Running initial domain upgrade threads") - for sdUUID in self._domainsToUpgrade: - threading.Thread(target=self._upgradeCallback, - args=(sdUUID, True), - kwargs={"__securityOverride": True}).start() @unsecured def __createMailboxMonitor(self): @@ -1109,15 +1117,12 @@ if domainStatuses[sdUUID] == sd.DOM_ACTIVE_STATUS: return True - # Domain conversion requires the links to be present - self._refreshDomainLinks(dom) - if dom.getDomainClass() == sd.DATA_DOMAIN: - self._convertDomain(dom) - dom.activate() # set domains also do rebuild domainStatuses[sdUUID] = sd.DOM_ACTIVE_STATUS self.setMetaParam(PMDK_DOMAINS, domainStatuses) + self._refreshDomainLinks(dom) + self._upgradeRegularDomains() self.updateMonitoringThreads() return True -- To view, visit http://gerrit.ovirt.org/13634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I679a992f689ee6ae97c82c267d0da69b4f0e6725 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

5 7

Change in vdsm[master]: Avoid prepare template by using unsafe qemu-img rebase
by ykaplan＠redhat.com 12 May '14

12 May '14

Yeela Kaplan has uploaded a new change for review. Change subject: Avoid prepare template by using unsafe qemu-img rebase ...................................................................... Avoid prepare template by using unsafe qemu-img rebase Change-Id: I959e49315b2539cdb9111edd1786590a22023907 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=979193 Signed-off-by: Yeela Kaplan <ykaplan(a)redhat.com> --- M vdsm/storage/blockVolume.py M vdsm/storage/fileVolume.py M vdsm/storage/volume.py 3 files changed, 31 insertions(+), 40 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/18793/1 diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py index effd3a5..c93a0b2 100644 --- a/vdsm/storage/blockVolume.py +++ b/vdsm/storage/blockVolume.py @@ -180,19 +180,9 @@ utils.rmFile(volPath) os.symlink(lvm.lvPath(dom.sdUUID, volUUID), volPath) - if not volParent: - cls.log.info("Request to create %s volume %s with size = %s " - "sectors", volume.type2name(volFormat), volPath, - size) - - if volFormat == volume.COW_FORMAT: - volume.createVolume(None, None, volPath, size, volFormat, - preallocate) - else: - # Create hardlink to template and its meta file - cls.log.info("Request to create snapshot %s/%s of volume %s/%s", - imgUUID, volUUID, srcImgUUID, srcVolUUID) - volParent.clone(imgPath, volUUID, volFormat, preallocate) + volume.Volume.createVolume(imgUUID, volUUID, size, volFormat, + preallocate, volParent, srcImgUUID, + srcVolUUID, imgPath, volPath) with cls._tagCreateLock: mdSlot = dom.mapMetaOffset(volUUID, VOLUME_MDNUMBLKS) diff --git a/vdsm/storage/fileVolume.py b/vdsm/storage/fileVolume.py index 4525b0e..614c7b1 100644 --- a/vdsm/storage/fileVolume.py +++ b/vdsm/storage/fileVolume.py @@ -145,19 +145,9 @@ cls.log.error("Unexpected error", exc_info=True) raise se.VolumesZeroingError(volPath) - if not volParent: - cls.log.info("Request to create %s volume %s with size = %s " - "sectors", volume.type2name(volFormat), volPath, - size) - - if volFormat == volume.COW_FORMAT: - volume.createVolume(None, None, volPath, size, volFormat, - preallocate) - else: - # Create hardlink to template and its meta file - cls.log.info("Request to create snapshot %s/%s of volume %s/%s", - imgUUID, volUUID, srcImgUUID, srcVolUUID) - volParent.clone(imgPath, volUUID, volFormat, preallocate) + volume.Volume.createVolume(imgUUID, volUUID, size, volFormat, + preallocate, volParent, srcImgUUID, + srcVolUUID, imgPath, volPath) # By definition the volume is a leaf cls.file_setrw(volPath, rw=True) diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py index 928a3e7..1722b7f 100644 --- a/vdsm/storage/volume.py +++ b/vdsm/storage/volume.py @@ -249,12 +249,11 @@ self.setParent(backingVol) self.recheckIfLeaf() - def clone(self, dst_image_dir, dst_volUUID, volFormat, preallocate): + def clone(self, dstVolPath, volFormat, preallocate): """ - Clone self volume to the specified dst_image_dir/dst_volUUID + Clone self volume to the specified dstVolPath """ wasleaf = False - dst_path = None taskName = "parent volume rollback: " + self.volUUID vars.task.pushRecovery( task.Recovery(taskName, "volume", "Volume", @@ -264,27 +263,23 @@ wasleaf = True self.setInternal() try: - self.prepare(rw=False) - dst_path = os.path.join(dst_image_dir, dst_volUUID) self.log.debug("Volume.clone: %s to %s" % - (self.volumePath, dst_path)) + (self.volumePath, dstVolPath)) size = int(self.getMetaParam(SIZE)) parent = self.getVolumePath() parent_format = fmt2str(self.getFormat()) # We should use parent's relative path instead of full path parent = os.path.join(os.path.basename(os.path.dirname(parent)), os.path.basename(parent)) - createVolume(parent, parent_format, dst_path, - size, volFormat, preallocate) - self.teardown(self.sdUUID, self.volUUID) + _createVolume(parent, parent_format, dstVolPath, + size, volFormat, preallocate) except Exception as e: # FIXME: might race with other clones if wasleaf: self.setLeaf() - self.teardown(self.sdUUID, self.volUUID) self.log.error("Volume.clone: can't clone: %s to %s" % - (self.volumePath, dst_path)) - raise se.CannotCloneVolume(self.volumePath, dst_path, str(e)) + (self.volumePath, dstVolPath)) + raise se.CannotCloneVolume(self.volumePath, dstVolPath, str(e)) def _shareLease(self, dstImgPath): """ @@ -386,6 +381,21 @@ if preallocate not in VOL_TYPE: raise se.IncorrectType(type2name(preallocate)) + + @classmethod + def createVolume(cls, imgUUID, volUUID, size, volFmt, preallocate, + volParent, srcImgUUID, srcVolUUID, imgPath, volPath): + if not volParent: + cls.log.info("Request to create %s volume %s with size = %s " + "sectors", type2name(volFmt), volPath, size) + + if volFmt == COW_FORMAT: + _createVolume(None, None, volPath, size, volFmt, preallocate) + else: + # Create hardlink to template and its meta file + cls.log.info("Request to create snapshot %s/%s of volume %s/%s", + imgUUID, volUUID, srcImgUUID, srcVolUUID) + volParent.clone(volPath, volFmt, preallocate) @classmethod def create(cls, repoPath, sdUUID, imgUUID, size, volFormat, preallocate, @@ -997,7 +1007,7 @@ pass -def createVolume(parent, parent_format, volume, size, format, prealloc): +def _createVolume(parent, parent_format, volume, size, format, prealloc): """ --- Create new volume. 'parent' - backing volume name @@ -1036,7 +1046,8 @@ # cwd = os.path.split(os.path.split(volume)[0])[0] # Temporary fix for qemu-img creation problem - cmd += ["-F", parent_format, "-b", os.path.join("..", parent), volume] + cmd += ["-u", "-F", parent_format, "-b", os.path.join("..", parent), + volume] cwd = os.path.split(volume)[0] else: size = int(size) -- To view, visit http://gerrit.ovirt.org/18793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I959e49315b2539cdb9111edd1786590a22023907 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>

5 11

Change in vdsm[master]: Make IRS methods bypass API.py
by smizrahi＠redhat.com 12 May '14

12 May '14

Saggi Mizrahi has uploaded a new change for review. Change subject: Make IRS methods bypass API.py ...................................................................... Make IRS methods bypass API.py Change-Id: Iaf7dc90462e47b9f067959df7325b57cbaa82241 Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com> --- M vdsm/BindingXMLRPC.py 1 file changed, 80 insertions(+), 432 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/7227/1 diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py index 0d74af6..2e0dce2 100644 --- a/vdsm/BindingXMLRPC.py +++ b/vdsm/BindingXMLRPC.py @@ -33,6 +33,7 @@ import API from vdsm.exception import VdsmException import fenceAgent +from functools import partial try: from gluster.api import getGlusterMethods @@ -388,358 +389,6 @@ api = API.Global() return api.setMOMPolicy(policy) - def domainActivate(self, sdUUID, spUUID, options=None): - domain = API.StorageDomain(sdUUID, spUUID) - return domain.activate() - - def domainAttach(self, sdUUID, spUUID, options=None): - domain = API.StorageDomain(sdUUID, spUUID) - return domain.attach(spUUID) - - def domainCreate(self, storageType, sdUUID, domainName, - typeSpecificArg, domClass, - domVersion=None, options=None): - domain = API.StorageDomain(sdUUID, spUUID=None) - return domain.create(storageType, typeSpecificArg, domainName, - domClass, domVersion) - - def domainDeactivate(self, sdUUID, spUUID, msdUUID, masterVersion, - options=None): - domain = API.StorageDomain(sdUUID, spUUID) - return domain.deactivate(msdUUID, masterVersion) - - def domainDetach(self, sdUUID, spUUID, msdUUID, masterVersion, - options=None): - domain = API.StorageDomain(sdUUID, spUUID) - return domain.detach(msdUUID, masterVersion, force=False) - - def domainDetachForced(self, sdUUID, spUUID, options=None): - domain = API.StorageDomain(sdUUID, spUUID) - return domain.detach(None, None, force=True) - - def domainExtend(self, sdUUID, spUUID, devlist, options=None): - domain = API.StorageDomain(sdUUID, spUUID) - return domain.extend(devlist) - - def domainFormat(self, sdUUID, - autoDetach=False, options=None): - domain = API.StorageDomain(sdUUID, spUUID=None) - return domain.format(autoDetach) - - def domainGetFileList(self, sdUUID, pattern='*', options=None): - domain = API.StorageDomain(sdUUID, spUUID=None) - return domain.getFileList(pattern) - - def domainGetImages(self, sdUUID, options=None): - domain = API.StorageDomain(sdUUID, spUUID=None) - return domain.getImages() - - def domainGetInfo(self, sdUUID, options=None): - domain = API.StorageDomain(sdUUID, spUUID=None) - return domain.getInfo() - - def domainGetStats(self, sdUUID, options=None): - domain = API.StorageDomain(sdUUID, spUUID=None) - return domain.getStats() - - def domainGetVolumes(self, sdUUID, spUUID, - imgUUID=API.Image.BLANK_UUID): - domain = API.StorageDomain(sdUUID, spUUID) - return domain.getVolumes(imgUUID) - - def domainSetDescription(self, sdUUID, description, options=None): - domain = API.StorageDomain(sdUUID, spUUID=None) - return domain.setDescription(description) - - def domainUploadVolume(self, sdUUID, spUUID, imgUUID, volUUID, - srcPath, size, method="rsync", options=None): - domain = API.StorageDomain(sdUUID, spUUID) - return domain.uploadVolume(imgUUID, volUUID, srcPath, size, method) - - def domainValidate(self, sdUUID, options=None): - domain = API.StorageDomain(sdUUID, spUUID=None) - return domain.validate() - - def imageDelete(self, sdUUID, spUUID, - imgUUID, postZero=False, force=False): - image = API.Image(imgUUID, spUUID, sdUUID) - return image.delete(postZero, force) - - def imageDeleteVolumes(self, sdUUID, spUUID, imgUUID, volumes, - postZero=False, force=False): - image = API.Image(imgUUID, spUUID, sdUUID) - return image.deleteVolumes(volumes, postZero, force) - - def imageMergeSnapshots(self, sdUUID, spUUID, vmUUID, imgUUID, - ancestor, successor, postZero=False): - image = API.Image(imgUUID, spUUID, sdUUID) - return image.mergeSnapshots(ancestor, successor, postZero) - - def imageMove(self, spUUID, srcDomUUID, dstDomUUID, imgUUID, vmUUID, - op, postZero=False, force=False): - image = API.Image(imgUUID, spUUID, srcDomUUID) - return image.move(dstDomUUID, op, postZero, force) - - def poolConnect(self, spUUID, hostID, scsiKey, msdUUID, masterVersion, - options=None): - pool = API.StoragePool(spUUID) - return pool.connect(hostID, scsiKey, msdUUID, masterVersion) - - def poolConnectStorageServer(self, domType, spUUID, conList, options=None): - pool = API.StoragePool(spUUID) - return pool.connectStorageServer(domType, conList) - - def poolCreate(self, poolType, spUUID, poolName, masterDom, domList, - masterVersion, lockPolicy=None, lockRenewalIntervalSec=None, - leaseTimeSec=None, ioOpTimeoutSec=None, - leaseRetries=None, options=None): - pool = API.StoragePool(spUUID) - return pool.create(poolName, masterDom, masterVersion, domList, - lockRenewalIntervalSec, leaseTimeSec, ioOpTimeoutSec, - leaseRetries) - - def poolDestroy(self, spUUID, hostID, scsiKey, options=None): - pool = API.StoragePool(spUUID) - return pool.destroy(hostID, scsiKey) - - def poolDisconnect(self, spUUID, hostID, scsiKey, remove=False, - options=None): - pool = API.StoragePool(spUUID) - return pool.disconnect(hostID, scsiKey, remove) - - def poolDisconnectStorageServer(self, domType, spUUID, conList, - options=None): - pool = API.StoragePool(spUUID) - return pool.disconnectStorageServer(domType, conList) - - def poolFenceSPMStorage(self, spUUID, lastOwner, lastLver, options=None): - pool = API.StoragePool(spUUID) - return pool.fence() - - def poolGetBackedUpVmsInfo(self, spUUID, sdUUID, - vmList=None, options=None): - pool = API.StoragePool(spUUID) - return pool.getBackedUpVmsInfo(sdUUID, vmList) - - def poolGetBackedUpVmsList(self, spUUID, sdUUID=None, options=None): - pool = API.StoragePool(spUUID) - return pool.getBackedUpVmsList(sdUUID) - - def poolGetFloppyList(self, spUUID, options=None): - pool = API.StoragePool(spUUID) - return pool.getFloppyList() - - def poolGetDomainsContainingImage(self, spUUID, imgUUID, datadomains=True, - options=None): - pool = API.StoragePool(spUUID) - return pool.getDomainsContainingImage(imgUUID, datadomains) - - def poolGetIsoList(self, spUUID, extension='iso', options=None): - pool = API.StoragePool(spUUID) - return pool.getIsoList(extension) - - def poolGetSpmStatus(self, spUUID, options=None): - pool = API.StoragePool(spUUID) - return pool.getSpmStatus() - - def poolGetInfo(self, spUUID, options=None): - pool = API.StoragePool(spUUID) - return pool.getInfo() - - def poolMoveMultipleImages(self, spUUID, srcDomUUID, dstDomUUID, imgDict, - vmUUID, force=False): - pool = API.StoragePool(spUUID) - return pool.moveMultipleImages(srcDomUUID, dstDomUUID, imgDict, force) - - def poolReconstructMaster(self, spUUID, poolName, masterDom, domDict, - masterVersion, lockPolicy=None, - lockRenewalIntervalSec=None, leaseTimeSec=None, - ioOpTimeoutSec=None, leaseRetries=None, - hostId=None, options=None): - pool = API.StoragePool(spUUID) - return pool.reconstructMaster(hostId, poolName, masterDom, - masterVersion, domDict, lockRenewalIntervalSec, leaseTimeSec, - ioOpTimeoutSec, leaseRetries) - - def poolRefresh(self, spUUID, msdUUID, masterVersion, options=None): - pool = API.StoragePool(spUUID) - return pool.refresh(msdUUID, masterVersion) - - def poolSetDescription(self, spUUID, description, options=None): - pool = API.StoragePool(spUUID) - return pool.setDescription(description) - - def poolSpmStart(self, spUUID, prevID, prevLVER, recoveryMode, - scsiFencing, maxHostID=None, - domVersion=None, options=None): - pool = API.StoragePool(spUUID) - return pool.spmStart(prevID, prevLVER, scsiFencing, - maxHostID, domVersion) - - def poolSpmStop(self, spUUID, options=None): - pool = API.StoragePool(spUUID) - return pool.spmStop() - - def poolUpgrade(self, spUUID, targetDomVersion): - pool = API.StoragePool(spUUID) - return pool.upgrade(targetDomVersion) - - def poolValidateStorageServerConnection(self, domType, spUUID, conList, - options=None): - pool = API.StoragePool(spUUID) - return pool.validateStorageServerConnection(domType, conList) - - def poolUpdateVMs(self, spUUID, vmList, sdUUID=None, options=None): - pool = API.StoragePool(spUUID) - return pool.updateVMs(vmList, sdUUID) - - def poolRemoveVm(self, spUUID, vmUUID, sdUUID=None, options=None): - pool = API.StoragePool(spUUID) - return pool.removeVM(vmUUID, sdUUID) - - def volumeCopy(self, sdUUID, spUUID, vmUUID, srcImgUUID, srcVolUUID, - dstImgUUID, dstVolUUID, description='', - dstSdUUID=API.StorageDomain.BLANK_UUID, - volType=API.Volume.Roles.SHARED, - volFormat=API.Volume.Formats.UNKNOWN, - preallocate=API.Volume.Types.UNKNOWN, postZero=False, - force=False): - volume = API.Volume(srcVolUUID, spUUID, sdUUID, srcImgUUID) - return volume.copy(dstSdUUID, dstImgUUID, dstVolUUID, - description, volType, volFormat, preallocate, postZero, - force) - - def volumeCreate(self, sdUUID, spUUID, imgUUID, size, volFormat, - preallocate, diskType, volUUID, desc, - srcImgUUID=API.Image.BLANK_UUID, - srcVolUUID=API.Volume.BLANK_UUID): - volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID) - return volume.create(size, volFormat, preallocate, diskType, - desc, srcImgUUID, srcVolUUID) - - def volumeExtend(self, sdUUID, spUUID, imgUUID, volUUID, size, - isShuttingDown=None): - volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID) - return volume.extend(size, isShuttingDown) - - def volumeGetInfo(self, sdUUID, spUUID, imgUUID, volUUID): - volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID) - return volume.getInfo() - - def volumeGetPath(self, sdUUID, spUUID, imgUUID, volUUID): - volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID) - return volume.getPath() - - def volumeGetSize(self, sdUUID, spUUID, imgUUID, volUUID): - volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID) - return volume.getSize() - - def volumePrepare(self, sdUUID, spUUID, imgUUID, volUUID, rw=True): - volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID) - return volume.prepare(rw) - - def volumeRefresh(self, sdUUID, spUUID, imgUUID, volUUID): - volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID) - return volume.refresh() - - def volumeSetDescription(self, sdUUID, spUUID, imgUUID, volUUID, - description): - volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID) - return volume.setDescription(description) - - def volumeSetLegality(self, sdUUID, spUUID, imgUUID, volUUID, legality): - volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID) - return volume.setLegality(legality) - - def volumeTearDown(self, sdUUID, spUUID, imgUUID, volUUID): - volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID) - return volume.tearDown() - - def taskClear(self, taskId): - task = API.Task(taskId) - return task.clear() - - def taskGetInfo(self, taskId): - task = API.Task(taskId) - return task.getInfo() - - def taskGetStatus(self, taskId): - task = API.Task(taskId) - return task.getStatus() - - def taskRevert(self, taskId): - task = API.Task(taskId) - return task.revert() - - def taskStop(self, taskId): - task = API.Task(taskId) - return task.stop() - - # Global storage methods - def tasksGetAllInfo(self): - api = API.Global() - return api.getAllTasksInfo() - - def tasksGetAllStatuses(self): - api = API.Global() - return api.getAllTasksStatuses() - - def iscsiDiscoverSendTargets(self, con, options=None): - iscsiConn = API.ISCSIConnection(con['connection'], - con['port'], con['user'], con['password']) - return iscsiConn.discoverSendTargets() - - def vgCreate(self, name, devlist, force=False): - vg = API.LVMVolumeGroup(self.cif) - return vg.create(name, devlist, force) - - def vgGetInfo(self, vgUUID, options=None): - vg = API.LVMVolumeGroup(vgUUID) - return vg.getInfo() - - def vgRemove(self, vgUUID, options=None): - vg = API.LVMVolumeGroup(vgUUID) - return vg.remove() - - def domainsGetList(self, spUUID=None, domainClass=None, storageType=None, - remotePath=None, options=None): - api = API.Global() - return api.getStorageDomains(spUUID, domainClass, storageType, - remotePath) - - def poolsGetConnectedList(self, options=None): - api = API.Global() - return api.getConnectedStoragePools() - - def storageRepoGetStats(self, options=None): - api = API.Global() - return api.getStorageRepoStats() - - def vgsGetList(self, storageType=None, options=None): - api = API.Global() - return api.getLVMVolumeGroups(storageType) - - def devicesGetList(self, storageType=None, options=None): - api = API.Global() - return api.getDeviceList(storageType) - - def devicesGetVisibility(self, guids, options=None): - api = API.Global() - return api.getDevicesVisibility(guids) - - def deviceGetInfo(self, guid, options=None): - api = API.Global() - return api.getDeviceInfo(guid) - - def storageServerConnectionRefsAcquire(self, conRefArgs): - return API.ConnectionRefs().acquire(conRefArgs) - - def storageServerConnectionRefsRelease(self, refIDs): - return API.ConnectionRefs().release(refIDs) - - def storageServerConnectionRefsStatuses(self): - return API.ConnectionRefs().statuses() - def getGlobalMethods(self): return ((self.vmDestroy, 'destroy'), (self.vmCreate, 'create'), @@ -785,86 +434,85 @@ (self.vmHotunplugNic, 'hotunplugNic')) def getIrsMethods(self): - return ((self.domainActivate, 'activateStorageDomain'), - (self.domainAttach, 'attachStorageDomain'), - (self.domainCreate, 'createStorageDomain'), - (self.domainDeactivate, 'deactivateStorageDomain'), - (self.domainDetach, 'detachStorageDomain'), - (self.domainDetachForced, 'forcedDetachStorageDomain'), - (self.domainExtend, 'extendStorageDomain'), - (self.domainFormat, 'formatStorageDomain'), - (self.domainGetFileList, 'getFileList'), - (self.domainGetImages, 'getImagesList'), - (self.domainGetInfo, 'getStorageDomainInfo'), - (self.domainGetStats, 'getStorageDomainStats'), - (self.domainGetVolumes, 'getVolumesList'), - (self.domainSetDescription, 'setStorageDomainDescription'), - (self.domainUploadVolume, 'uploadVolume'), - (self.domainValidate, 'validateStorageDomain'), - (self.imageDelete, 'deleteImage'), - (self.imageDeleteVolumes, 'deleteVolume'), - (self.imageMergeSnapshots, 'mergeSnapshots'), - (self.imageMove, 'moveImage'), - (self.poolConnect, 'connectStoragePool'), - (self.poolConnectStorageServer, 'connectStorageServer'), - (self.poolCreate, 'createStoragePool'), - (self.poolDestroy, 'destroyStoragePool'), - (self.poolDisconnect, 'disconnectStoragePool'), - (self.poolDisconnectStorageServer, 'disconnectStorageServer'), - (self.poolFenceSPMStorage, 'fenceSpmStorage'), - (self.poolGetBackedUpVmsInfo, 'getVmsInfo'), - (self.poolGetBackedUpVmsList, 'getVmsList'), - (self.poolGetFloppyList, 'getFloppyList'), - (self.poolGetDomainsContainingImage, 'getImageDomainsList'), - (self.poolGetIsoList, 'getIsoList'), - (self.poolGetSpmStatus, 'getSpmStatus'), - (self.poolGetInfo, 'getStoragePoolInfo'), - (self.poolMoveMultipleImages, 'moveMultipleImages'), - (self.poolReconstructMaster, 'reconstructMaster'), - (self.poolRefresh, 'refreshStoragePool'), - (self.poolSetDescription, 'setStoragePoolDescription'), - (self.poolSpmStart, 'spmStart'), - (self.poolSpmStop, 'spmStop'), - (self.poolUpgrade, 'upgradeStoragePool'), - (self.poolValidateStorageServerConnection, - 'validateStorageServerConnection'), - (self.poolUpdateVMs, 'updateVM'), - (self.poolRemoveVm, 'removeVM'), - (self.taskClear, 'clearTask'), - (self.taskGetInfo, 'getTaskInfo'), - (self.taskGetStatus, 'getTaskStatus'), - (self.taskRevert, 'revertTask'), - (self.taskStop, 'stopTask'), - (self.volumeCopy, 'copyImage'), - (self.volumeCreate, 'createVolume'), - (self.volumeExtend, 'extendVolume'), - (self.volumeGetInfo, 'getVolumeInfo'), - (self.volumeGetPath, 'getVolumePath'), - (self.volumeGetSize, 'getVolumeSize'), - (self.volumePrepare, 'prepareVolume'), - (self.volumeRefresh, 'refreshVolume'), - (self.volumeSetDescription, 'setVolumeDescription'), - (self.volumeSetLegality, 'setVolumeLegality'), - (self.volumeTearDown, 'teardownVolume'), - (self.tasksGetAllInfo, 'getAllTasksInfo'), - (self.tasksGetAllStatuses, 'getAllTasksStatuses'), - (self.iscsiDiscoverSendTargets, 'discoverSendTargets'), - (self.vgCreate, 'createVG'), - (self.vgGetInfo, 'getVGInfo'), - (self.vgRemove, 'removeVG'), - (self.domainsGetList, 'getStorageDomainsList'), - (self.poolsGetConnectedList, 'getConnectedStoragePoolsList'), - (self.storageRepoGetStats, 'repoStats'), - (self.vgsGetList, 'getVGList'), - (self.devicesGetList, 'getDeviceList'), - (self.devicesGetVisibility, 'getDevicesVisibility'), - (self.deviceGetInfo, 'getDeviceInfo'), - (self.storageServerConnectionRefsAcquire, - 'storageServer_ConnectionRefs_acquire'), - (self.storageServerConnectionRefsRelease, - 'storageServer_ConnectionRefs_release'), - (self.storageServerConnectionRefsStatuses, - 'storageServer_ConnectionRefs_statuses'),) + passThroughMethods = ( + 'activateStorageDomain', + 'attachStorageDomain', + 'createStorageDomain', + 'deactivateStorageDomain', + 'detachStorageDomain', + 'forcedDetachStorageDomain', + 'extendStorageDomain', + 'formatStorageDomain', + 'getFileList', + 'getImagesList', + 'getStorageDomainInfo', + 'getStorageDomainStats', + 'getVolumesList', + 'setStorageDomainDescription', + 'uploadVolume', + 'validateStorageDomain', + 'deleteImage', + 'deleteVolume', + 'mergeSnapshots', + 'moveImage', + 'connectStoragePool', + 'connectStorageServer', + 'createStoragePool', + 'destroyStoragePool', + 'disconnectStoragePool', + 'disconnectStorageServer', + 'fenceSpmStorage', + 'getVmsInfo', + 'getVmsList', + 'getFloppyList', + 'getImageDomainsList', + 'getIsoList', + 'getSpmStatus', + 'getStoragePoolInfo', + 'moveMultipleImages', + 'reconstructMaster', + 'refreshStoragePool', + 'setStoragePoolDescription', + 'spmStart', + 'spmStop', + 'upgradeStoragePool', + 'validateStorageServerConnection', + 'updateVM', + 'removeVM', + 'clearTask', + 'getTaskInfo', + 'getTaskStatus', + 'revertTask', + 'stopTask', + 'copyImage', + 'createVolume', + 'extendVolume', + 'getVolumeInfo', + 'getVolumePath', + 'getVolumeSize', + 'prepareVolume', + 'refreshVolume', + 'setVolumeDescription', + 'setVolumeLegality', + 'teardownVolume', + 'getAllTasksInfo', + 'getAllTasksStatuses', + 'discoverSendTargets', + 'createVG', + 'getVGInfo', + 'removeVG', + 'getStorageDomainsList', + 'getConnectedStoragePoolsList', + 'repoStats', + 'getVGList', + 'getDeviceList', + 'getDevicesVisibility', + 'getDeviceInfo', + 'storageServer_ConnectionRefs_acquire', + 'storageServer_ConnectionRefs_release', + 'storageServer_ConnectionRefs_statuses',) + return zip(map(partial(getattr, self.cif.irs), passThroughMethods), + passThroughMethods) def wrapApiMethod(f): -- To view, visit http://gerrit.ovirt.org/7227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaf7dc90462e47b9f067959df7325b57cbaa82241 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>

6 12

Change in vdsm[master]: [WIP] Add the base commands to vdsm-tool
by Federico Simoncelli 12 May '14

12 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Add the base commands to vdsm-tool ...................................................................... [WIP] Add the base commands to vdsm-tool Change-Id: Id3f49dc3cbb4dfba86a85ab9348d19684445f40e --- M vdsm-tool/Makefile.am A vdsm-tool/base.py M vdsm.spec.in 3 files changed, 52 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/388/1 -- To view, visit http://gerrit.ovirt.org/388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id3f49dc3cbb4dfba86a85ab9348d19684445f40e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

2 2

Change in vdsm[master]: [WIP] Add the daemon commands to vdsm-tool
by Federico Simoncelli 12 May '14

12 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Add the daemon commands to vdsm-tool ...................................................................... [WIP] Add the daemon commands to vdsm-tool Change-Id: Ieafb9886f3ffb2433478203186dd94005b2a51e8 --- M vdsm-tool/Makefile.am A vdsm-tool/daemon.py M vdsm.spec.in 3 files changed, 52 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/389/1 -- To view, visit http://gerrit.ovirt.org/389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieafb9886f3ffb2433478203186dd94005b2a51e8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

2 2

Change in vdsm[master]: [WIP] Enable deleteVolume for the merged internal volumes
by Federico Simoncelli 12 May '14

12 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Enable deleteVolume for the merged internal volumes ...................................................................... [WIP] Enable deleteVolume for the merged internal volumes Change-Id: I99044c9de79ee3c74ed1c010f6e573bcd3695da2 --- M vdsm/storage/volume.py 1 file changed, 20 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/2672/1 -- To view, visit http://gerrit.ovirt.org/2672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I99044c9de79ee3c74ed1c010f6e573bcd3695da2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

3 3

Change in vdsm[master]: [WIP] Adding Image.release() to remove the merged volumes
by Federico Simoncelli 12 May '14

12 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Adding Image.release() to remove the merged volumes ...................................................................... [WIP] Adding Image.release() to remove the merged volumes The new Image.release() method can be used to remove the internal volumes that were live merged by a VM. Change-Id: I50aaea4e52ea2c6a10cdc68e134ae606dcd81e24 --- M vdsm/storage/image.py 1 file changed, 43 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/2883/1 -- To view, visit http://gerrit.ovirt.org/2883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I50aaea4e52ea2c6a10cdc68e134ae606dcd81e24 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

2 2

Change in vdsm[master]: [WIP] Add releaseVolumes command to the SPM
by Federico Simoncelli 12 May '14

12 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Add releaseVolumes command to the SPM ...................................................................... [WIP] Add releaseVolumes command to the SPM We don't actually need this. I'm using it for testing until we decide where to plug the release method. Change-Id: I7784f319d0beb5f5d88b83a99c48d4843b3c9953 --- M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/storage/hsm.py M vdsm/storage/sp.py 4 files changed, 42 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/2884/1 -- To view, visit http://gerrit.ovirt.org/2884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7784f319d0beb5f5d88b83a99c48d4843b3c9953 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

2 2

Change in vdsm[master]: Rename validateImage to validateMoveImage
by Federico Simoncelli 11 May '14

11 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: Rename validateImage to validateMoveImage ...................................................................... Rename validateImage to validateMoveImage Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> Change-Id: I62746c28e7c5a7902de19090ec6a851ffe10a7fd --- M vdsm/storage/hsm.py M vdsm/storage/sp.py 2 files changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/3490/1 -- To view, visit http://gerrit.ovirt.org/3490 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I62746c28e7c5a7902de19090ec6a851ffe10a7fd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

3 4

Change in vdsm[master]: Add the hostId parameter to reconstructMaster
by Federico Simoncelli 11 May '14

11 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: Add the hostId parameter to reconstructMaster ...................................................................... Add the hostId parameter to reconstructMaster Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> Change-Id: If665af4ed8be9b5b53dffc7e1fc258b818bf7f98 --- M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/storage/hsm.py M vdsm/storage/sp.py 4 files changed, 37 insertions(+), 39 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/5068/1 -- To view, visit http://gerrit.ovirt.org/5068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If665af4ed8be9b5b53dffc7e1fc258b818bf7f98 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

6 16

← Newer
1
...
8
9
10
11
12
13
14
...
50
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches December 2013