Change in vdsm[master]: health: Name health monitor thread
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: health: Name health monitor thread
......................................................................
health: Name health monitor thread
Change-Id: I89931fc3a1e51828961c9288273645528f7a15de
Bug-Url: https://bugzilla.redhat.com/1141422
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/66105
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/health.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/66105
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I89931fc3a1e51828961c9288273645528f7a15de
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in vdsm[master]: health: Name health monitor thread
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: health: Name health monitor thread
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/66105
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89931fc3a1e51828961c9288273645528f7a15de
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 6 months
Change in vdsm[master]: v2v: Name v2v import threads
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: Name v2v import threads
......................................................................
v2v: Name v2v import threads
Change-Id: I1a3b019044e998dd697affb15b53062f90ab3229
Bug-Url: https://bugzilla.redhat.com/1141422
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/66108
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Shahar Havivi <shavivi(a)redhat.com>
Continuous-Integration: Jenkins CI
---
M lib/vdsm/v2v.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Nir Soffer: Verified
Shahar Havivi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/66108
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a3b019044e998dd697affb15b53062f90ab3229
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in vdsm[master]: yajsonrpc: py3: stomp.py string/unicode compliance
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: yajsonrpc: py3: stomp.py string/unicode compliance
......................................................................
Patch Set 5:
Giving this a quick ovirt-system-test run is a great verification.
--
To view, visit https://gerrit.ovirt.org/63212
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77ee8120e85435a93e54bf16e9192d53bd48fc0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 6 months
Change in vdsm[master]: jsonrpc: decode properly messages
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: decode properly messages
......................................................................
Patch Set 1:
Was this introduced by the recent "broker cleanup" patch?
--
To view, visit https://gerrit.ovirt.org/66282
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ae799e69d6a6bce4e48d161373caad4f9e45567
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 6 months
Change in vdsm[master]: net: acquire ifcfg files to be used by VDSM - refactoring
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: acquire ifcfg files to be used by VDSM - refactoring
......................................................................
net: acquire ifcfg files to be used by VDSM - refactoring
Refactoring the ifcfg file name normalization, in order to add special
handling for ifcfg files that represent VLAN devices in a future patch.
Change-Id: Ieeac4075fbb3869a99e94de04953a5ade0db26ef
Bug-Url: https://bugzilla.redhat.com/1390474
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/65996
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Continuous-Integration: Jenkins CI
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 22 insertions(+), 11 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/65996
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeac4075fbb3869a99e94de04953a5ade0db26ef
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in vdsm[master]: build: no one needs python-rtslib
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: build: no one needs python-rtslib
......................................................................
build: no one needs python-rtslib
commit df5ebfd removed all reference to rtslib. There is no need to pull
the package any more.
Change-Id: Iac4280c1ed36693e61bcfb80ae55c1313b762344
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M automation/build-artifacts.packages.el7
M automation/build-artifacts.packages.fc24
M automation/check-merged.packages.el7
M automation/check-merged.packages.fc24
M automation/check-patch.packages.el7
5 files changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/66247/1
diff --git a/automation/build-artifacts.packages.el7 b/automation/build-artifacts.packages.el7
index 7f2a880..58927c9 100644
--- a/automation/build-artifacts.packages.el7
+++ b/automation/build-artifacts.packages.el7
@@ -19,7 +19,6 @@
python-mock
python-netaddr
python-pthreading
-python-rtslib
python-setuptools
python3-netaddr
python3-nose
diff --git a/automation/build-artifacts.packages.fc24 b/automation/build-artifacts.packages.fc24
index 08c7506..84be9bd 100644
--- a/automation/build-artifacts.packages.fc24
+++ b/automation/build-artifacts.packages.fc24
@@ -19,7 +19,6 @@
python-mock
python-netaddr
python-pthreading
-python-rtslib
python-setuptools
python3-decorator
python3-netaddr
diff --git a/automation/check-merged.packages.el7 b/automation/check-merged.packages.el7
index 1c43150..aaee0b1 100644
--- a/automation/check-merged.packages.el7
+++ b/automation/check-merged.packages.el7
@@ -18,7 +18,6 @@
python-mock
python-netaddr
python-pthreading
-python-rtslib
python-six
python34-nose
python34-six
diff --git a/automation/check-merged.packages.fc24 b/automation/check-merged.packages.fc24
index 83cccaa..cb869f7 100644
--- a/automation/check-merged.packages.fc24
+++ b/automation/check-merged.packages.fc24
@@ -22,7 +22,6 @@
python-mock
python-netaddr
python-pthreading
-python-rtslib
python-six
python3-decorator
python3-netaddr
diff --git a/automation/check-patch.packages.el7 b/automation/check-patch.packages.el7
index 937f0ea..e702fe2 100644
--- a/automation/check-patch.packages.el7
+++ b/automation/check-patch.packages.el7
@@ -17,7 +17,6 @@
python-mock
python-netaddr
python-pthreading
-python-rtslib
python-setuptools
python-six
rpm-build
--
To view, visit https://gerrit.ovirt.org/66247
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac4280c1ed36693e61bcfb80ae55c1313b762344
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 6 months
Change in vdsm[master]: utils: add custom closing context manager
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: add custom closing context manager
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65982
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I29e9ed0f44603dd5299be5e3b814d08833055a94
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 6 months
Change in vdsm[master]: build: check-patch.el7 does not require py3
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: build: check-patch.el7 does not require py3
......................................................................
build: check-patch.el7 does not require py3
We do not run py3 tests on el7, so we should not pull the related
packages.
Change-Id: Ic0540b25a4009cd7cafe189b03f47c3c8faf165e
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M automation/check-patch.packages.el7
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/66246/1
diff --git a/automation/check-patch.packages.el7 b/automation/check-patch.packages.el7
index bfb21e4..937f0ea 100644
--- a/automation/check-patch.packages.el7
+++ b/automation/check-patch.packages.el7
@@ -20,9 +20,6 @@
python-rtslib
python-setuptools
python-six
-python34-nose
-python34-six
-python34
rpm-build
sanlock-python
sudo
--
To view, visit https://gerrit.ovirt.org/66246
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0540b25a4009cd7cafe189b03f47c3c8faf165e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 6 months
Change in vdsm[master]: build: lago not required for check-patch
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: build: lago not required for check-patch
......................................................................
build: lago not required for check-patch
in commit f247a0cff3 I've mistakenly copied lago dependencies from
check-merged.packages.el7 to check-patch.packages.el7.
This patch removes the redundant requirements.
Change-Id: Ie4a3666e6a140dd74cdeff1521614ae0051a9ead
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M automation/check-patch.packages.el7
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/66245/1
diff --git a/automation/check-patch.packages.el7 b/automation/check-patch.packages.el7
index 35151e4..bfb21e4 100644
--- a/automation/check-patch.packages.el7
+++ b/automation/check-patch.packages.el7
@@ -2,8 +2,6 @@
automake
gdb
git
-lago
-lago-ovirt
libguestfs-tools-c
m2crypto
make
@@ -30,5 +28,3 @@
sudo
yum
yum-utils
-# Needed by lago
-grubby
--
To view, visit https://gerrit.ovirt.org/66245
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4a3666e6a140dd74cdeff1521614ae0051a9ead
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 6 months