Change in vdsm[master]: Using %{?_smp_mflags} for make calls
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has abandoned this change.
Change subject: Using %{?_smp_mflags} for make calls
......................................................................
Abandoned
--
To view, visit https://gerrit.ovirt.org/62163
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I290734e0ac4db6d6891428a9c149d631f5b705f8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in vdsm[master]: Adding units to memory metrics name according to metrics2.0 ...
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has abandoned this change.
Change subject: Adding units to memory metrics name according to metrics2.0 spec
......................................................................
Abandoned
not needed
--
To view, visit https://gerrit.ovirt.org/62155
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1020b89c5ebb2412750352d6c2131097dcbaf407
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in vdsm[master]: Adding units to cpu metrics name according to metrics2.0 spec
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has abandoned this change.
Change subject: Adding units to cpu metrics name according to metrics2.0 spec
......................................................................
Abandoned
not needed
--
To view, visit https://gerrit.ovirt.org/62156
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I366280bf1c3783fdbbdd7459e49ae7fcf5e8b598
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in vdsm[master]: Adding percent suffix to metric name spacing
by ybronhei＠redhat.com
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding percent suffix to metric name spacing
......................................................................
Adding percent suffix to metric name spacing
Change-Id: Ibe87f2b9b31aaa9555b2df68689b5e9edbe398b9
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M lib/vdsm/health.py
M lib/vdsm/host/api.py
M lib/vdsm/metrics/__init__.py
3 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/62335/1
diff --git a/lib/vdsm/health.py b/lib/vdsm/health.py
index 94c9f14..7b9aede 100644
--- a/lib/vdsm/health.py
+++ b/lib/vdsm/health.py
@@ -30,6 +30,7 @@
from . import host
from vdsm.metrics import MB
+from vdsm.metrics import PERCENT
from vdsm.metrics import send
_monitor = None
@@ -128,8 +129,8 @@
report = {}
report[prefix + '.gc.uncollectable'] = \
self._stats['uncollectable_obj']
- report[prefix + '.cpu.user_pct'] = self._stats['utime_pct']
- report[prefix + '.cpu.sys_pct'] = self._stats['stime_pct']
+ report[prefix + '.cpu.user' + PERCENT] = self._stats['utime_pct']
+ report[prefix + '.cpu.sys' + PERCENT] = self._stats['stime_pct']
report[prefix + '.memory.rss' + MB] = self._stats['rss']
report[prefix + '.threads_count'] = self._stats['threads']
send(report)
diff --git a/lib/vdsm/host/api.py b/lib/vdsm/host/api.py
index 0fb7e3f..52f0e0c 100644
--- a/lib/vdsm/host/api.py
+++ b/lib/vdsm/host/api.py
@@ -31,6 +31,7 @@
from vdsm.define import Kbytes, Mbytes
from vdsm.metrics import JIFFIES
from vdsm.metrics import MB
+from vdsm.metrics import PERCENT
from vdsm.metrics import send
from vdsm.virt import vmstatus
@@ -117,7 +118,7 @@
if 'ksmPages' in hoststats:
data[prefix + '.cpu.ksm_pages'] = hoststats['ksmPages']
- data[prefix + '.cpu.ksm_cpu_precent'] = hoststats['ksmCpu']
+ data[prefix + '.cpu.ksm_cpu' + PERCENT] = hoststats['ksmCpu']
if hoststats['haStats']['configured']:
data[prefix + '.ha_score'] = hoststats['haScore']
diff --git a/lib/vdsm/metrics/__init__.py b/lib/vdsm/metrics/__init__.py
index 1007310..f7714e0 100644
--- a/lib/vdsm/metrics/__init__.py
+++ b/lib/vdsm/metrics/__init__.py
@@ -26,6 +26,7 @@
# METRIC UNIT SUFFIX REPRESENTATION
MB = '_M'
JIFFIES = '_jiff'
+PERCENT = '_percent'
_reporter = None
--
To view, visit https://gerrit.ovirt.org/62335
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe87f2b9b31aaa9555b2df68689b5e9edbe398b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
7 years, 6 months
Change in vdsm[master]: Revert "Enable metrics by default"
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Revert "Enable metrics by default"
......................................................................
Revert "Enable metrics by default"
This reverts commit b892ccece0e3c4b050b4bee80f4705978a80fa82.
This requires python-statsd first as part of vdsm requirements.
Change-Id: I1a38af2b91688903158df45036da44e3f001307a
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M lib/vdsm/config.py.in
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/66256/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index d606da2..47184ab 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -452,8 +452,8 @@
# Section: [metrics]
('metrics', [
- ('enabled', 'true',
- 'Enable metrics collection (default true)'),
+ ('enabled', 'false',
+ 'Enable metrics collection (default false)'),
('collector_address', 'localhost',
'Metrics collector address (default localhost)'),
--
To view, visit https://gerrit.ovirt.org/66256
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a38af2b91688903158df45036da44e3f001307a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
7 years, 6 months
Change in vdsm[master]: hook-fcoe is arch depended
by ybronhei＠redhat.com
Yaniv Bronhaim has uploaded a new change for review.
Change subject: hook-fcoe is arch depended
......................................................................
hook-fcoe is arch depended
Using %post script in sub-package of arch depended package requires to
declare the package as arch depended.
Change-Id: Ic59d7e29a75b13e1fc39b58a8d1252d6d2971058
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/62454/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index edd8e82..728a534 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -681,7 +681,6 @@
%package hook-fcoe
Summary: Hook to enable FCoE support
-BuildArch: noarch
Requires: %{name} = %{version}-%{release}
Requires: fcoe-utils
--
To view, visit https://gerrit.ovirt.org/62454
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic59d7e29a75b13e1fc39b58a8d1252d6d2971058
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
7 years, 6 months
Change in vdsm[master]: Revert "Remove __init__.py file from lib64 vdsm python direc...
by ybronhei＠redhat.com
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Revert "Remove __init__.py file from lib64 vdsm python directory"
......................................................................
Revert "Remove __init__.py file from lib64 vdsm python directory"
This reverts commit 9f9e8b37c6fb120f1bb40514c9d22c9d5602dded. Which is
not needed anymore (we stop supporting upgrade from vdsm <=17). Without
the %post script we can declare vdsm-python as noarch.
Change-Id: Id06b502c714074a62c8ac6b5d5cb9d350472137b
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/62453/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index edd8e82..8aaa866 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -347,19 +347,6 @@
%description python
Shared libraries between the various VDSM packages.
-%post python
-# REQUIRED_FOR: Upgrade from 4.14 to 4.17
-# HACK: Remove vdsm python lib __init__ file if installed on old location
-# https://bugzilla.redhat.com/show_bug.cgi?id=1279167
-if [ "$1" -ge 2 ]; then
- if [ -d "%{python2_sitearch}/%{vdsm_name}" ]; then
- logger -t '%{vdsm_name}' \
- 'Disabling old vdsm package in %{python2_sitearch}/%{vdsm_name}.' \
- 'Removing %{python2_sitearch}/%{vdsm_name}/init.py*'
- rm -f %{python2_sitearch}/%{vdsm_name}/__init__.py*
- fi
-fi
-
%package tests
Summary: VDSM Test Suite
BuildArch: noarch
--
To view, visit https://gerrit.ovirt.org/62453
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id06b502c714074a62c8ac6b5d5cb9d350472137b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
7 years, 6 months
Change in vdsm[master]: Remove host uuid from metrics
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Remove host uuid from metrics
......................................................................
Remove host uuid from metrics
The uuid string is not required as it comes to the metrics store from
the collectd service.
Change-Id: I2138f5c1b9554bc8140481f723ca7dcb7379a148
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M lib/vdsm/host/api.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/66230/1
diff --git a/lib/vdsm/host/api.py b/lib/vdsm/host/api.py
index 90ee846..de7e741 100644
--- a/lib/vdsm/host/api.py
+++ b/lib/vdsm/host/api.py
@@ -82,7 +82,7 @@
def send_metrics(hoststats):
- prefix = "hosts." + uuid()
+ prefix = "hosts"
data = {}
try:
--
To view, visit https://gerrit.ovirt.org/66230
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2138f5c1b9554bc8140481f723ca7dcb7379a148
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
7 years, 6 months
Change in vdsm[master]: Rename network-interface prefix to nic
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Rename network-interface prefix to nic
......................................................................
Rename network-interface prefix to nic
To avoid report of long metric names. We are limited to 63 chars
Change-Id: I051817fac598337cb9647440aa3a4bc5b866e1c4
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M lib/vdsm/host/api.py
M lib/vdsm/virt/vmstats.py
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/66231/1
diff --git a/lib/vdsm/host/api.py b/lib/vdsm/host/api.py
index 8a52d2a..138b6e8 100644
--- a/lib/vdsm/host/api.py
+++ b/lib/vdsm/host/api.py
@@ -122,7 +122,7 @@
if 'network' in hoststats:
for interface in hoststats['network']:
if_info = hoststats['network'][interface]
- net_prefix = prefix + '.network_interfaces.' + interface
+ net_prefix = prefix + '.nic.' + interface
data[net_prefix + '.speed'] = if_info['speed']
data[net_prefix + '.rx_rate'] = if_info['rxRate']
data[net_prefix + '.tx_rate'] = if_info['txRate']
diff --git a/lib/vdsm/virt/vmstats.py b/lib/vdsm/virt/vmstats.py
index 8e271cb..4fcaaf5 100644
--- a/lib/vdsm/virt/vmstats.py
+++ b/lib/vdsm/virt/vmstats.py
@@ -241,7 +241,7 @@
if 'network' in stat:
for interface in stat['network']:
- netprefix = prefix + '.network_interfaces.' + interface
+ netprefix = prefix + '.nic.' + interface
if_info = stat['network'][interface]
data[netprefix + '.speed'] = if_info['speed']
data[netprefix + '.rx.bytes'] = if_info['rx']
--
To view, visit https://gerrit.ovirt.org/66231
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I051817fac598337cb9647440aa3a4bc5b866e1c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
7 years, 6 months
Change in vdsm[master]: Rename vm_disk to disk to shorten metric length
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Rename vm_disk to disk to shorten metric length
......................................................................
Rename vm_disk to disk to shorten metric length
Change-Id: I1758ab7526c63fab6afecd1bfff91b930e9eed41
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M lib/vdsm/virt/vmstats.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/66232/1
diff --git a/lib/vdsm/virt/vmstats.py b/lib/vdsm/virt/vmstats.py
index 4fcaaf5..954e95e 100644
--- a/lib/vdsm/virt/vmstats.py
+++ b/lib/vdsm/virt/vmstats.py
@@ -211,7 +211,7 @@
if 'disks' in stat:
for disk in stat['disks']:
- diskprefix = prefix + '.vm_disk.' + disk
+ diskprefix = prefix + '.disk.' + disk
diskinfo = stat['disks'][disk]
data[diskprefix + '.read.latency'] = \
--
To view, visit https://gerrit.ovirt.org/66232
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1758ab7526c63fab6afecd1bfff91b930e9eed41
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
7 years, 6 months