Change in vdsm[master]: net: configurators - refactor source route flow (no logic ch...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: configurators - refactor source route flow (no logic change)
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/69261/5//COMMIT_MSG
Commit Message:
Line 10: depending on the sourceroute module.
Line 11: This is causing uneeded complexity and is design wide wrong.
Line 12:
Line 13: This patch reorganize the calls to source route (with no logic change)
Line 14: and moves it to the concrete classes (ifcfg and iproute2).
... causing minor code duplication.
Line 15:
Line 16: Change-Id: Id5bf8453105bac9830952ffdb314a3da9be56230
--
To view, visit https://gerrit.ovirt.org/69261
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5bf8453105bac9830952ffdb314a3da9be56230
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 5 months
Change in vdsm[master]: net: configurators - refactor source route flow (no logic ch...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: configurators - refactor source route flow (no logic change)
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69261
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5bf8453105bac9830952ffdb314a3da9be56230
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: network: fix invalid argument names in __exit__
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: fix invalid argument names in __exit__
......................................................................
Patch Set 1: Code-Review+2
regards from younger Petr ;-)
--
To view, visit https://gerrit.ovirt.org/69499
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia34211d2ae488c14727f2a6b1b932fc050f44761
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: tests/README: resource leak plugins: succinct doc
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: tests/README: resource leak plugins: succinct doc
......................................................................
tests/README: resource leak plugins: succinct doc
I find the 3-time repetition a bit boring. This patch unites them to
one.
Change-Id: I5c2890b6567ccf068d05a3c8efc7bb98e5774010
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/README
1 file changed, 6 insertions(+), 29 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/69422/1
diff --git a/tests/README b/tests/README
index ee15be0..82499f5 100644
--- a/tests/README
+++ b/tests/README
@@ -42,40 +42,17 @@
Stress tests are also enabled if NOSE_STRESS_TESTS environment variable is set.
-Enabling threads leak check
----------------------------
+Enabling resource leak checks
+-----------------------------
-To find tests leaking threads, you can enable the thread leak checker plugin:
+To find tests leaking various resources, you can enable any of the following
+resources leak checker plugins:
- ./run_tests_local.sh --with-thread-leak-check filename [...]
-
-To run the entire test suit with thread leak detection:
-
- make check NOSE_WITH_THREAD_LEAK_CHECK=1
-
-Enabling processs leak check
-----------------------------
-
-To find tests leaking child processes, you can enable the process leak checker
-plugin:
-
- ./run_tests_local.sh --with-process-leak-check filename [...]
+ ./run_tests_local.sh --with-thread-leak-check --with-process-leak-check --with-file-leak-check filename [...]
To run the entire test suit with process leak detection:
- make check NOSE_WITH_PROCESS_LEAK_CHECK=1
-
-Enabling file leak check
-------------------------
-
-To find tests leaking file descriptors, you can enable the process leak checker
-plugin:
-
- ./run_tests_local.sh --with-file-leak-check filename [...]
-
-To run the entire test suit with file leak detection:
-
- make check NOSE_WITH_FILE_LEAK_CHECK=1
+ make check NOSE_WITH_THREAD_LEAK_CHECK=1 NOSE_WITH_PROCESS_LEAK_CHECK=1 NOSE_WITH_FILE_LEAK_CHECK=1
Control verbose level:
---------------------
--
To view, visit https://gerrit.ovirt.org/69422
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c2890b6567ccf068d05a3c8efc7bb98e5774010
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 5 months
Change in vdsm[master]: net test: Bonds need a slave to be considered operational up
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Bonds need a slave to be considered operational up
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/69280/2/tests/network/nmnettestlib.py
File tests/network/nmnettestlib.py:
PS2, Line 105: _exec_cmd(command)
> We already use _exec_cmd for other needs here.
I think I can live with this (small) code duplication.
--
To view, visit https://gerrit.ovirt.org/69280
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4f89593ab02617ea768715fb5293e1b4b550808
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 5 months
Change in vdsm[master]: net func test: Existing NM test should cleanup even if it fails
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net func test: Existing NM test should cleanup even if it fails
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/69276/1/tests/network/func_net_basic_test.py
File tests/network/func_net_basic_test.py:
Line 105: iface = iface_name()
Line 106: NET = {NETWORK_NAME: {'bonding': iface, 'switch': self.switch}}
Line 107: with nm_connections(iface, IPv4_ADDRESS, con_count=3):
Line 108: try:
Line 109: with self.setupNetworks(NET, {}, NOCHK):
> The original problem is that the setupNetworks is internally asserting kern
Maybe instead of removing the acquired bond in "finally", you'd handle it after catching the specific error that you are expecting?
Line 110: self.assertNetwork(NETWORK_NAME, NET[NETWORK_NAME])
Line 111: finally:
Line 112: # The bond was acquired, therefore VDSM needs to clean it.
Line 113: BONDREMOVE = {iface: {'remove': True}}
--
To view, visit https://gerrit.ovirt.org/69276
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If66640134404be54792cf69a22056b64a2c94b85
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 5 months
Change in vdsm[master]: net: rename sourceroutethread module to dhclient_monitor
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: rename sourceroutethread module to dhclient_monitor
......................................................................
net: rename sourceroutethread module to dhclient_monitor
The module is monitoring dhclient responses and triggers sourceroute
actions per the data.
As we intend to use this mechanism for other actions as well, it has
been renamed to a name that describes better its functionality.
Change-Id: I55f253ab228db0cb8b6626bbf09f139d618e2e09
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/Makefile.am
R lib/vdsm/network/dhclient_monitor.py
M lib/vdsm/supervdsm_server.py
M vdsm.spec.in
4 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/69195
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I55f253ab228db0cb8b6626bbf09f139d618e2e09
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: net: Aggregate network initializations under one roof
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Aggregate network initializations under one roof
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/69198/2/lib/vdsm/supervdsm_server.py
File lib/vdsm/supervdsm_server.py:
Line 66: from vdsm.storage.iscsi import getDevIscsiInfo as _getdeviSCSIinfo
Line 67: from vdsm.storage.iscsi import readSessionInfo as _readSessionInfo
Line 68: from vdsm.supervdsm import _SuperVdsmManager
Line 69:
Line 70: from vdsm.network import initializer as network_initializer
> For supervdsm, we will (hopefully) never need to touch this service module
yes, I would really like you to take it out of its current location down the branch. I may understand the need for this patch closer to the final state of the refactoring.
Line 71:
Line 72: from vdsm.storage.multipath import getScsiSerial as _getScsiSerial
Line 73: from vdsm.storage import multipath
Line 74: from vdsm.constants import METADATA_GROUP, \
--
To view, visit https://gerrit.ovirt.org/69198
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90e002bdb029f796efeab2ff5e89234b8ce2200f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 5 months
Change in vdsm[master]: net: rename sourceroutethread module to dhclient_monitor
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: rename sourceroutethread module to dhclient_monitor
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69195
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55f253ab228db0cb8b6626bbf09f139d618e2e09
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[ovirt-4.1]: net: drop special ovirt-node handling from netconfpersistence
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: drop special ovirt-node handling from netconfpersistence
......................................................................
net: drop special ovirt-node handling from netconfpersistence
The removed code was introduced in https://gerrit.ovirt.org/50984
to solve https://bugzilla.redhat.com/1293617 in vintage ovirt-node
In current ovirt-node implementation, files do not have any different
owneership or permission. So this code can be dropped.
Change-Id: I8ee5300a6e8a59638d7754d1f66c13118bdd7edd
Signed-off-by: Petr Horáček <phoracek(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1349391
---
M lib/vdsm/network/netconfpersistence.py
M tests/network/conf_persistence_test.py
2 files changed, 0 insertions(+), 11 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69496
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ee5300a6e8a59638d7754d1f66c13118bdd7edd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months