Change in vdsm[ovirt-4.1]: storage: Add API for SDM update_volume
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: storage: Add API for SDM update_volume
......................................................................
Patch Set 2: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/69376
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I698492f022ce5f7b82ed121977e3c03ee7b93db1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[ovirt-4.1]: storage: Add API for SDM update_volume
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: storage: Add API for SDM update_volume
......................................................................
Patch Set 2:
please update the bug with the next Target Release version in 4.1
--
To view, visit https://gerrit.ovirt.org/69376
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I698492f022ce5f7b82ed121977e3c03ee7b93db1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[ovirt-4.1]: storage: rename volume attributes class
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: storage: rename volume attributes class
......................................................................
storage: rename volume attributes class
amend_volume should change only qcow2 metadata, and we want to add
update_volume for updating ovirt volume metadata. The new verb will use
VolumeAttributes for volume metadata.
See engine patch: Ibbfbf32d3bd46437e84dfad45987b738e280f0e6
Bug-Url: https://bugzilla.redhat.com/1409380
Change-Id: Iab10e868b69f42543c12873c1014979d2efafa1e
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M lib/api/vdsm-api.yml
M tests/storage_sdm_amend_volume_test.py
M vdsm/API.py
M vdsm/storage/hsm.py
M vdsm/storage/sdm/api/amend_volume.py
5 files changed, 25 insertions(+), 26 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/69374
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab10e868b69f42543c12873c1014979d2efafa1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[ovirt-4.1]: storage: rename volume attributes class
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: storage: rename volume attributes class
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69374
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab10e868b69f42543c12873c1014979d2efafa1e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[ovirt-4.1]: storage: Add API for SDM update_volume
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: storage: Add API for SDM update_volume
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69376
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I698492f022ce5f7b82ed121977e3c03ee7b93db1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: vdsm: remove os.setgrp() call
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: remove os.setgrp() call
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/69448
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18914b2a45f49fd02b416db325111d969238bff
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: vdsm: move logic to python module and create wrapper
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: move logic to python module and create wrapper
......................................................................
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/69184
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c0c7c6cc36ab431214a4d6a4b598f67fbb3636e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: virt: bugfix: use normalized literal ip addresses for migration
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: bugfix: use normalized literal ip addresses for migration
......................................................................
virt: bugfix: use normalized literal ip addresses for migration
Destination/migration qemu uris require valid literal ip
addresses (in accordance with rfc2732).
While ipv4 addresses don't require any modification,
ipv6 addresses may need to be enclosed with square brackets.
During the formation of the uri's, use normalize_literal_addr to
ensure that the uri's are formatted properly.
Change-Id: Idff68ceffa45fe1d9be35be81371e92dbe643f4a
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M lib/vdsm/virt/migration.py
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved; Passed CI tests
Leon Goldberg: Verified
Martin Polednik: Looks good to me, but someone else must approve
Edward Haas: Looks good to me, but someone else must approve
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/69286
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idff68ceffa45fe1d9be35be81371e92dbe643f4a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[master]: virt: bugfix: use normalized literal ip addresses for migration
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: bugfix: use normalized literal ip addresses for migration
......................................................................
Patch Set 11: Continuous-Integration+1
16:57:27 ERROR: test_set_from_parent(frozenset({0, 3})) (tasksetTests.AffinityTests)
16:57:27 ----------------------------------------------------------------------
16:57:27 Traceback (most recent call last):
16:57:27 File "/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/testlib.py", line 141, in wrapper
16:57:27 return f(self, *args)
16:57:27 File "/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/tasksetTests.py", line 74, in test_set_from_parent
16:57:27 raise RuntimeError("helper child process not running!")
16:57:27 RuntimeError: helper child process not running!
--
To view, visit https://gerrit.ovirt.org/69286
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idff68ceffa45fe1d9be35be81371e92dbe643f4a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: [WIP] tests: CountFilesPlugin
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: [WIP] tests: CountFilesPlugin
......................................................................
[WIP] tests: CountFilesPlugin
A proper test should clean after itself, and close all the files it had
opened. Enabling this plugin, with --with-countfiles, shows which test
(or its tested code), fail to do so.
Change-Id: Ic71224f3c24b04cf4d08889338722cf248bcb2a9
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/testValidation.py
M tests/testlib.py
2 files changed, 32 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/69042/1
diff --git a/tests/testValidation.py b/tests/testValidation.py
index a4b6789..ed84c19 100644
--- a/tests/testValidation.py
+++ b/tests/testValidation.py
@@ -107,6 +107,36 @@
raise Exception('thread leak: %s ' % diff)
+class CountFilesPlugin(Plugin):
+ """
+ Check whether a test (or the code it triggers) open files and do not close
+ them.
+ """
+ name = 'countfiles'
+
+ def _readlink_if_exists(self, path):
+ try:
+ return os.readlink(path)
+ except OSError as e:
+ if e.errno != errno.ENOENT:
+ raise
+
+ def _open_files(self):
+ fddir = '/proc/%s/fd/' % os.getpid()
+
+ return frozenset(
+ self._readlink_if_exists(fddir + path) for path
+ in os.listdir(fddir))
+
+ def startTest(self, test):
+ self._start_files = self._open_files()
+
+ def stopTest(self, test):
+ diff = self._open_files() - self._start_files
+ if diff:
+ raise Exception('file leak: %s ' % diff)
+
+
def ValidateRunningAsRoot(f):
@wraps(f)
def wrapper(*args, **kwargs):
diff --git a/tests/testlib.py b/tests/testlib.py
index 8a55e6e..694457d 100644
--- a/tests/testlib.py
+++ b/tests/testlib.py
@@ -59,7 +59,7 @@
from monkeypatch import Patch
from testValidation import (
- SlowTestsPlugin, StressTestsPlugin, CountThreadsPlugin)
+ SlowTestsPlugin, StressTestsPlugin, CountThreadsPlugin, CountFilesPlugin)
# /tmp may use tempfs filesystem, not suitable for some of the test assuming a
# filesystem with direct io support.
@@ -435,6 +435,7 @@
conf.plugins.addPlugin(SlowTestsPlugin())
conf.plugins.addPlugin(StressTestsPlugin())
conf.plugins.addPlugin(CountThreadsPlugin())
+ conf.plugins.addPlugin(CountFilesPlugin())
runner = VdsmTestRunner(stream=conf.stream,
verbosity=conf.verbosity,
--
To view, visit https://gerrit.ovirt.org/69042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic71224f3c24b04cf4d08889338722cf248bcb2a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 4 months