Change in vdsm[master]: test: Remove testEmptyAddress test which does not ran
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: test: Remove testEmptyAddress test which does not ran
......................................................................
test: Remove testEmptyAddress test which does not ran
The test used the @brokentest decorator wrongly and never run.
As xmlrpc is decprecated, we can remove this test.
Change-Id: Id1c75e99a7212348567f28806dc025491709a190
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M tests/vdsClientTests.py
1 file changed, 0 insertions(+), 9 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/69360
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1c75e99a7212348567f28806dc025491709a190
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: testValidation: Raise TypeError on decorator misuse
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: testValidation: Raise TypeError on decorator misuse
......................................................................
testValidation: Raise TypeError on decorator misuse
Protect test validation decorators which require the decorator to be
used as a function call.
If such a decorator is used differently, a TypeError is raised.
Change-Id: Ic7c5459c939069a9e75aee6e559f7b115b4b0c3b
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M tests/testValidation.py
1 file changed, 22 insertions(+), 27 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/69334
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7c5459c939069a9e75aee6e559f7b115b4b0c3b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: testValidation: Raise TypeError on decorator misuse
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: testValidation: Raise TypeError on decorator misuse
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69334
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7c5459c939069a9e75aee6e559f7b115b4b0c3b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: testValidation: Add @xfail decorator
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: testValidation: Add @xfail decorator
......................................................................
testValidation: Add @xfail decorator
This decorator should be used to mark good tests as expected failure. In
this case the test is good, but the code is broken, and cannot be fix
yet.
The test will skip with the reason message if the test fail, and fail if
the test succeeds, since this means the code is working and we can
remove this decorator.
This is a poor man implementation of pytest.mark.xfail, see
http://doc.pytest.org/en/latest/skipping.html
Usage::
@xfail("why this test canonot pass now...")
def test_broken_code(self):
...
Change-Id: Ib1ff3996ced0362ca5b2f4718b46f0bac3e32fc8
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M tests/testValidation.py
1 file changed, 43 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/69321
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1ff3996ced0362ca5b2f4718b46f0bac3e32fc8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: testValidation: Add @xfail decorator
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: testValidation: Add @xfail decorator
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69321
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1ff3996ced0362ca5b2f4718b46f0bac3e32fc8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: vdsm: remove os.setgrp() call
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: remove os.setgrp() call
......................................................................
vdsm: remove os.setgrp() call
This is a leftover from rhel6 and not needed anymore.
Change-Id: Ic18914b2a45f49fd02b416db325111d969238bff
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M vdsm/vdsm
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Nir Soffer: Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/69448
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic18914b2a45f49fd02b416db325111d969238bff
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: rpmlint: silence isolatedprivatevlan-related error
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: rpmlint: silence isolatedprivatevlan-related error
......................................................................
rpmlint: silence isolatedprivatevlan-related error
This hook was hardly ever used, but regardless of its destiny, it should
not produce rpmlint errors.
Reviewed-on: https://gerrit.ovirt.org/#/q/Idd0eda6ff359ac6d7e66e516ddb062dd7dbd466b
Change-Id: Idd0eda6ff359ac6d7e66e516ddb062dd7dbd466b
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm.spec.in
M vdsm_hooks/isolatedprivatevlan/Makefile.am
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/69445/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index c005191..9bcb651 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1495,7 +1495,7 @@
%files hook-isolatedprivatevlan
%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_isolatedprivatevlan
-%config(noreplace) %{_sysconfdir}/libvirt/nwfilter/isolatedprivatevlan-vdsm.xml
+%{_sysconfdir}/libvirt/nwfilter/isolatedprivatevlan-vdsm.xml
%files hook-macbind
%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_macbind
diff --git a/vdsm_hooks/isolatedprivatevlan/Makefile.am b/vdsm_hooks/isolatedprivatevlan/Makefile.am
index c06c80f..15a83d4 100644
--- a/vdsm_hooks/isolatedprivatevlan/Makefile.am
+++ b/vdsm_hooks/isolatedprivatevlan/Makefile.am
@@ -28,7 +28,7 @@
$(DESTDIR)$(vdsmhooksdir)/before_vm_start/50_isolatedprivatevlan
$(MKDIR_P) $(DESTDIR)$(sysconfdir)/libvirt/nwfilter
- $(INSTALL_SCRIPT) $(srcdir)/isolatedprivatevlan-vdsm.xml \
+ $(INSTALL_DATA) $(srcdir)/isolatedprivatevlan-vdsm.xml \
$(DESTDIR)$(sysconfdir)/libvirt/nwfilter/isolatedprivatevlan-vdsm.xml
uninstall-local:
--
To view, visit https://gerrit.ovirt.org/69445
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd0eda6ff359ac6d7e66e516ddb062dd7dbd466b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 5 months
Change in vdsm[master]: vdsm: move try except block inside main function
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: move try except block inside main function
......................................................................
vdsm: move try except block inside main function
This change is part of the effort of moving python scripts to
modules containing the actual code.
having try except block inside __main__ prevents us from
getting rid of this block.
Change-Id: Ib41ffa8d22a8b52e74fa46a24943fdfdce43fe87
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M vdsm/vdsm
1 file changed, 16 insertions(+), 17 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69183
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib41ffa8d22a8b52e74fa46a24943fdfdce43fe87
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: vdsm: move try except block inside main function
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: move try except block inside main function
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69183
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib41ffa8d22a8b52e74fa46a24943fdfdce43fe87
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[ovirt-4.1]: storage: Add API for SDM update_volume
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: storage: Add API for SDM update_volume
......................................................................
storage: Add API for SDM update_volume
Add API for SDM.update_volume verb that allows to change
volume metadata from any host.
The supported metadata that can be changed:
- description of the volume
- volume type (allow making a leaf volume shared)
- legality (legal/illegal)
- generation
Bug-Url: https://bugzilla.redhat.com/1409380
Change-Id: I698492f022ce5f7b82ed121977e3c03ee7b93db1
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M lib/api/vdsm-api.yml
M lib/vdsm/storage/exception.py
M lib/vdsm/storage/types.py
M tests/Makefile.am
A tests/storage_sdm_update_volume_test.py
M tests/storagetestlib.py
M vdsm.spec.in
M vdsm/API.py
M vdsm/storage/hsm.py
M vdsm/storage/sdm/api/Makefile.am
A vdsm/storage/sdm/api/update_volume.py
M vdsm/storage/volume.py
12 files changed, 475 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/69376
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I698492f022ce5f7b82ed121977e3c03ee7b93db1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months