Adam Litke has posted comments on this change.
Change subject: cancel the core dump of a VM
......................................................................
Patch Set 12:
(2 comments)
http://gerrit.ovirt.org/#/c/11130/12//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2013-01-17 12:42:26 +0800
Line 4: Commit: Adam Litke <alitke(a)redhat.com>
Line 5: CommitDate: 2014-01-21 10:31:49 -0500
Line 6:
Line 7: cancel the core dump of a VM
The message goes straight to the point, but I think this is too
succint.
Done
Line 8:
Line 9: Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad
Line 10: Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
http://gerrit.ovirt.org/#/c/11130/12/vdsm/vm.py
File vdsm/vm.py:
Line 442: if memoryOnly:
Line 443: self.memoryOnly = True
Line 444: self.flags |= libvirt.VIR_DUMP_MEMORY_ONLY
Line 445: else:
Line 446: self.memoryOnly = False
why not just
Done
Line 447:
Line 448: self.status = {'code': CoreDumpThread.Status.NONE,
Line 449: 'message': 'No core dump operation'}
Line 450:
--
To view, visit
http://gerrit.ovirt.org/11130
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes