ShaoHe Feng has uploaded a new change for review.
Change subject: cancel the core dump of a VM ......................................................................
cancel the core dump of a VM
Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Signed-off-by: ShaoHe Feng shaohef@linux.vnet.ibm.com --- M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/define.py M vdsm/vm.py M vdsm_api/vdsmapi-schema.json M vdsm_cli/vdsClient.py 6 files changed, 62 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/11130/1
diff --git a/vdsm/API.py b/vdsm/API.py index 4f5eed8..c5f7d40 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -293,6 +293,15 @@ return errCode['noVM'] return v.coreDump(to, dumpParams)
+ def dumpCancel(self): + """ + Cancel a currently outgoing core dump process. + """ + v = self._cif.vmContainer.get(self._UUID) + if not v: + return errCode['noVM'] + return v.dumpCancel() + def desktopLock(self): """ Lock user session in guest operating system using guest agent. diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py index 9fcbefd..17d97b1 100644 --- a/vdsm/BindingXMLRPC.py +++ b/vdsm/BindingXMLRPC.py @@ -215,6 +215,10 @@ vm = API.VM(vmId) return vm.coreDump(to, params)
+ def vmCoreDumpCancel(self, vmId): + vm = API.VM(vmId) + return vm.dumpCancel() + def vmReset(self, vmId): vm = API.VM(vmId) return vm.reset() @@ -764,6 +768,7 @@ (self.vmPause, 'pause'), (self.vmCont, 'cont'), (self.vmCoreDump, 'coreDump'), + (self.vmCoreDumpCancel, 'dumpCancel'), (self.vmSnapshot, 'snapshot'), (self.vmMerge, 'merge'), (self.vmMergeStatus, 'mergeStatus'), diff --git a/vdsm/define.py b/vdsm/define.py index 84aacad..e1d428c 100644 --- a/vdsm/define.py +++ b/vdsm/define.py @@ -134,6 +134,9 @@ {'code': 58, 'message': 'Failed to generate coreDump file'}}, + 'dumpCancelErr': {'status': + {'code': 59, + 'message': 'Failed to cancel dump'}}, 'recovery': {'status': {'code': 99, 'message': diff --git a/vdsm/vm.py b/vdsm/vm.py index be947c6..0a40e97 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -1345,3 +1345,29 @@ return check finally: self._guestCpuLock.release() + + def dumpCancel(self): + def reportError(self, key='dumpCancelErr', msg=None): + if msg is None: + error = errCode[key] + else: + error = {'status': + {'code': errCode[key]['status']['code'], + 'message': msg}} + self.log.error("Failed to cancel core dump. " + msg, + exc_info=True) + return error + + self._acquireCpuLockWithTimeout() + try: + if not self.isDoingDump(): + return reportError(msg='no core dump in process') + if self.dumpMode() == "memory": + return reportError(msg='invalid to cancel memory dump') + self._doCoredumpThread.stop() + return {'status': {'code': 0, + 'message': 'core dump process stopped'}} + except Exception, e: + return reportError(msg=e.message) + finally: + self._guestCpuLock.release() diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json index 63b0fb1..39d1cba 100644 --- a/vdsm_api/vdsmapi-schema.json +++ b/vdsm_api/vdsmapi-schema.json @@ -5474,6 +5474,16 @@ 'data': {'to': 'str', 'params': 'DumpParams'}}
## +# @VM.dumpCancel: +# +# Cancel the currently outgoing core dump process. +# +# Since: 4.10.4 +# +## +{'command': {'class': 'VM', 'name': 'dumpCancel'}} + +## # @VM.monitorCommand: # # Send a command to the qemu monitor. diff --git a/vdsm_cli/vdsClient.py b/vdsm_cli/vdsClient.py index c4171d9..32ad348 100644 --- a/vdsm_cli/vdsClient.py +++ b/vdsm_cli/vdsClient.py @@ -1669,6 +1669,11 @@
return status['status']['code'], status['status']['message']
+ def do_dumpCancel(self, args): + vmId = args[0] + response = self.s.dumpCancel(vmId) + return response['status']['code'], response['status']['message'] + def coreDump(self, args): dumpParams = {'crash': False, 'live': False, @@ -2413,6 +2418,10 @@ 'Start live replication to the destination ' 'domain' )), + 'coreDumpCancel': (serv.do_dumpCancel, + ('<vmId>', + 'cancel machine core dump' + )), 'coreDump': (serv.coreDump, ('<vmId> <file> [live=<True|False>] ' '[crash=<True|False>] [bypass-cache=<True|False>] '
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/796/ (1/2)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/761/ (2/2)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/761/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/796/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/801/ (1/2)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/766/ (2/2)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/766/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/801/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/815/ (1/2)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/780/ (2/2)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 3: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/780/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/815/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/818/ (1/2)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/783/ (2/2)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/783/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/818/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/86/ (1/3)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/975/ (2/3)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/940/ (3/3)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 5: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/940/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/975/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/86/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 6:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/100/ (1/3)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 6:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/989/ (2/3)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 6:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/954/ (3/3)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 6: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/954/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/989/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/100/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 7:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/103/ (2/3)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 7:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/992/ (1/3)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 7:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/957/ (3/3)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 7: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/957/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/992/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/103/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
ShaoHe Feng has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 7: I would prefer that you didn't submit this
(3 inline comments)
.................................................... File vdsm/API.py Line 299: if not v: Line 300: return errCode['noVM'] Line 301: return v.coreDump(to, dumpParams) Line 302: Line 303: def dumpCancel(self): coreDumpCancel Line 304: """ Line 305: Cancel a currently outgoing core dump process. Line 306: """ Line 307: v = self._cif.vmContainer.get(self._UUID)
.................................................... File vdsm_api/vdsmapi-schema.json Line 5510: {'command': {'class': 'VM', 'name': 'coreDump'}, Line 5511: 'data': {'to': 'str', 'params': 'DumpParams'}} Line 5512: Line 5513: ## Line 5514: # @VM.dumpCancel: coreDumpCancel Line 5515: # Line 5516: # Cancel the currently outgoing core dump process. Line 5517: # Line 5518: # Since: 4.10.4
Line 5517: # Line 5518: # Since: 4.10.4 Line 5519: # Line 5520: ## Line 5521: {'command': {'class': 'VM', 'name': 'dumpCancel'}} coreDumpCancel Line 5522: Line 5523: ## Line 5524: # @VM.monitorCommand: Line 5525: #
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 8:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1363/ (1/3)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 8:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/472/ (2/3)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 8:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1325/ (3/3)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1325/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1363/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/472/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 9:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/473/ (2/3)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 9:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1364/ (3/3)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 9:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1326/ (1/3)
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1326/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1364/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/473/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Saggi Mizrahi has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 9:
(1 comment)
.................................................... File vdsm_api/vdsmapi-schema.json Line 5558: # Line 5559: # Since: 4.10.4 Line 5560: # Line 5561: ## Line 5562: {'command': {'class': 'VM', 'name': 'coreDumpCancel'}} Doesn't this return something other than regular status code? Line 5563: Line 5564: ## Line 5565: # @VM.monitorCommand: Line 5566: #
Itamar Heim has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 9:
ping
Adam Litke has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 9:
(1 comment)
.................................................... File vdsm_api/vdsmapi-schema.json Line 5558: # Line 5559: # Since: 4.10.4 Line 5560: # Line 5561: ## Line 5562: {'command': {'class': 'VM', 'name': 'coreDumpCancel'}} I don't think it needs to. Either the dump is cancelled (status OK) or it failed (return error code and message) Line 5563: Line 5564: ## Line 5565: # @VM.monitorCommand: Line 5566: #
Adam Litke has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 10: Verified+1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6725/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6638/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5833/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6735/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6648/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5843/ : SUCCESS
Adam Litke has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 11: Verified+1
Vinzenz Feenstra has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/11130/11/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json:
Line 5925: # Line 5926: # Since: 4.14.1 Line 5927: # Line 5928: ## Line 5929: {'command': {'class': 'VM', 'name': 'coreDumpCancel'}} data': {'vmID': 'UUID'}}? Line 5930: Line 5931: ## Line 5932: # @VM.monitorCommand: Line 5933: #
Adam Litke has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 12: Verified+1
Rebase and fixed minor comment related to Exceptions from last patchset.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 12: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6012/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6802/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6906/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_storage_functional_tests/46/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 12: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/11130/12//COMMIT_MSG Commit Message:
Line 3: AuthorDate: 2013-01-17 12:42:26 +0800 Line 4: Commit: Adam Litke alitke@redhat.com Line 5: CommitDate: 2014-01-21 10:31:49 -0500 Line 6: Line 7: cancel the core dump of a VM The message goes straight to the point, but I think this is too succint. Line 8: Line 9: Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Line 10: Signed-off-by: ShaoHe Feng shaohef@linux.vnet.ibm.com
http://gerrit.ovirt.org/#/c/11130/12/vdsm/vm.py File vdsm/vm.py:
Line 446: False why not just
self.memoryOnly = memoryOnly if self.memoryOnly: self.flags |= libvirt.VIR_DUMP_MEMORY_ONLY
Line 3033: if self._coredumpThread.memoryOnly: Line 3034: return reportError(msg='invalid to cancel memory dump') Line 3035: self._coredumpThread.stop() Line 3036: return {'status': doneCode} Line 3037: except Exception as e: Please narrow this exception handler if feasible Line 3038: self.log.error("Failed to cancel core dump. " + e.message) Line 3039: return reportError(msg=e.message) Line 3040: finally: Line 3041: self._guestCpuLock.release()
Adam Litke has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 12:
(2 comments)
http://gerrit.ovirt.org/#/c/11130/12//COMMIT_MSG Commit Message:
Line 3: AuthorDate: 2013-01-17 12:42:26 +0800 Line 4: Commit: Adam Litke alitke@redhat.com Line 5: CommitDate: 2014-01-21 10:31:49 -0500 Line 6: Line 7: cancel the core dump of a VM
The message goes straight to the point, but I think this is too succint.
Done Line 8: Line 9: Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Line 10: Signed-off-by: ShaoHe Feng shaohef@linux.vnet.ibm.com
http://gerrit.ovirt.org/#/c/11130/12/vdsm/vm.py File vdsm/vm.py:
Line 442: if memoryOnly: Line 443: self.memoryOnly = True Line 444: self.flags |= libvirt.VIR_DUMP_MEMORY_ONLY Line 445: else: Line 446: self.memoryOnly = False
why not just
Done Line 447: Line 448: self.status = {'code': CoreDumpThread.Status.NONE, Line 449: 'message': 'No core dump operation'} Line 450:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 13: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7293/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6391/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7175/ : SUCCESS
Itamar Heim has posted comments on this change.
Change subject: cancel the core dump of a VM ......................................................................
Patch Set 13:
ping?
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: add support to cancel the core dump of a VM. ......................................................................
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9032/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9816/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/740/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_ge... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9972/ : SUCCESS
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: add support to cancel the core dump of a VM. ......................................................................
Patch Set 14: Code-Review+1
Francesco Romani has posted comments on this change.
Change subject: virt: add support to cancel the core dump of a VM. ......................................................................
Patch Set 15:
changes: - shed duplicate code by leveraging the new Vm._report{Error,Exception} methods - update version information in schema
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: add support to cancel the core dump of a VM. ......................................................................
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9138/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9923/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/804/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10078/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5005/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3162/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_ge... : There was an infra issue, please contact infra@ovirt.org
Adam Litke has posted comments on this change.
Change subject: virt: add support to cancel the core dump of a VM. ......................................................................
Patch Set 15:
(1 comment)
http://gerrit.ovirt.org/#/c/11130/15/vdsm/virt/coredump.py File vdsm/virt/coredump.py:
Line 49: if postAction: Line 50: self.flags |= CoreDumpThread.postActionFlags[postAction] Line 51: if bypassCache: Line 52: self.flags |= libvirt.VIR_DUMP_BYPASS_CACHE Line 53: self.memoryOnly = memoryOnly What is this needed for? Line 54: if memoryOnly: Line 55: self.flags |= libvirt.VIR_DUMP_MEMORY_ONLY Line 56: Line 57: self.status = {'code': CoreDumpThread.Status.NONE,
Francesco Romani has posted comments on this change.
Change subject: virt: add support to cancel the core dump of a VM. ......................................................................
Patch Set 15:
(1 comment)
http://gerrit.ovirt.org/#/c/11130/15/vdsm/virt/coredump.py File vdsm/virt/coredump.py:
Line 49: if postAction: Line 50: self.flags |= CoreDumpThread.postActionFlags[postAction] Line 51: if bypassCache: Line 52: self.flags |= libvirt.VIR_DUMP_BYPASS_CACHE Line 53: self.memoryOnly = memoryOnly
What is this needed for?
Looks like is no longer needed. Will remove. Line 54: if memoryOnly: Line 55: self.flags |= libvirt.VIR_DUMP_MEMORY_ONLY Line 56: Line 57: self.status = {'code': CoreDumpThread.Status.NONE,
Francesco Romani has posted comments on this change.
Change subject: virt: add support to cancel the core dump of a VM. ......................................................................
Patch Set 15:
(1 comment)
http://gerrit.ovirt.org/#/c/11130/15/vdsm/virt/coredump.py File vdsm/virt/coredump.py:
Line 49: if postAction: Line 50: self.flags |= CoreDumpThread.postActionFlags[postAction] Line 51: if bypassCache: Line 52: self.flags |= libvirt.VIR_DUMP_BYPASS_CACHE Line 53: self.memoryOnly = memoryOnly
Looks like is no longer needed. Will remove.
Sorry, talked too early. It is used in vm.py in coreDumpCancel as part of the early checks. Line 54: if memoryOnly: Line 55: self.flags |= libvirt.VIR_DUMP_MEMORY_ONLY Line 56: Line 57: self.status = {'code': CoreDumpThread.Status.NONE,
Francesco Romani has posted comments on this change.
Change subject: virt: add support to cancel the core dump of a VM. ......................................................................
Patch Set 16:
changes: - move checks from vm.py to coredump.py to reduce the load in vm.py and to show clearly what the field memory_only is for.
Itamar Heim has posted comments on this change.
Change subject: virt: add support to cancel the core dump of a VM. ......................................................................
Patch Set 16:
ping
Jenkins CI RO has posted comments on this change.
Change subject: virt: add support to cancel the core dump of a VM. ......................................................................
Patch Set 16:
Abandoned due to no activity - please restore if still relevant
Jenkins CI RO has abandoned this change.
Change subject: virt: add support to cancel the core dump of a VM. ......................................................................
Abandoned
Abandoned due to no activity - please restore if still relevant
automation@ovirt.org has posted comments on this change.
Change subject: virt: add support to cancel the core dump of a VM. ......................................................................
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
vdsm-patches@lists.fedorahosted.org