Change in vdsm[master]: cancel the core dump of a VM

Francesco Romani has posted comments on this change.

Change subject: cancel the core dump of a VM
......................................................................


Patch Set 12: Code-Review-1

(3 comments)

http://gerrit.ovirt.org/#/c/11130/12//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2013-01-17 12:42:26 +0800
Line 4: Commit:     Adam Litke <alitke(a)redhat.com&gt;
Line 5: CommitDate: 2014-01-21 10:31:49 -0500
Line 6: 
Line 7: cancel the core dump of a VM
The message goes straight to the point, but I think this is too succint.
Line 8: 
Line 9: Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad
Line 10: Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;


http://gerrit.ovirt.org/#/c/11130/12/vdsm/vm.py
File vdsm/vm.py:

Line 446: False
why not just

  self.memoryOnly = memoryOnly
  if self.memoryOnly:
    self.flags |= libvirt.VIR_DUMP_MEMORY_ONLY


Line 3033:             if self._coredumpThread.memoryOnly:
Line 3034:                 return reportError(msg='invalid to cancel memory
dump')
Line 3035:             self._coredumpThread.stop()
Line 3036:             return {'status': doneCode}
Line 3037:         except Exception as e:
Please narrow this exception handler if feasible
Line 3038:             self.log.error("Failed to cancel core dump. " +
e.message)
Line 3039:             return reportError(msg=e.message)
Line 3040:         finally:
Line 3041:             self._guestCpuLock.release()


-- 
To view, visit http://gerrit.ovirt.org/11130
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes