Change in vdsm[master]: replace external ifconfig cmdline with ioctl/socket and sysf...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: replace external ifconfig cmdline with ioctl/socket and sysfs in netinfo
......................................................................


Patch Set 2: I would prefer that you didn't submit this

we already depend on python-ethtool (see git grep ethtool). I quiver of the thought of
depending on magic Linux numbers like 0x8915.

If you do not mind too strongly, please use the higher-level abstraction of ethtool. We
have higher obstacles than this for entry to Debian.

--
To view, visit http://gerrit.ovirt.org/3361
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com&gt;