Change in vdsm[master]: replace extern ifconfig commandline with ioctl/socket and sy...

Change in vdsm[master]: Add...

Change in vdsm[master]: Create...

mhuntxu＠gmail.com

Friday, 6 April 2012 Fri, 6 Apr '12

5:11 a.m.

Hunt Xu has uploaded a new change for review. Change subject: replace extern ifconfig commandline with ioctl/socket and sysfs in netinfo ...................................................................... replace extern ifconfig commandline with ioctl/socket and sysfs in netinfo Since ifconfig output format has been changed recently(see https://bugzilla.redhat.com/show_bug.cgi?id=784314), instead of parsing ifconfig's output, use ioctl and socket to get ip address and netmask of an interface, and get hardware address via /sys/class/net/INTERFACE/address. This makes vdsm could run normally on some bleeding edge distributions such as Archlinux or F17 on which new version ifconfig have already been deployed. Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 --- M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/netinfo.py M vdsm_cli/vdscli.py.in M vdsm_reg/deployUtil.py.in 5 files changed, 56 insertions(+), 49 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/3361/1 -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com>

Show replies by date

Roy Golan

Thursday, 10 May Thu, 10 May

10:15 a.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Roy Golan has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 10: make rpm on F17 have the new test failed: TestNetinfo testNetmaskConversions ERROR -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Naori <davidnaori3(a)gmail.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

6:05 a.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Dan Kenigsberg has submitted this change and it was merged. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... replace ifconfig cmdline with ethtool and sysfs in netinfo Since ifconfig output format has been changed recently(see https://bugzilla.redhat.com/show_bug.cgi?id=784314), instead of parsing ifconfig's output, use ethtool module to get ip address and netmask of an interface, and get hardware address via /sys/class/net/INTERFACE/address. This makes vdsm could run normally on some bleeding edge distributions such as Archlinux or F17 on which new version ifconfig has already been deployed. Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Signed-off-by: huntxu <mhuntxu(a)gmail.com> --- M AUTHORS M tests/Makefile.am A tests/netinfoTests.py A tests/netmaskconversions M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/netinfo.py M vdsm_cli/vdscli.py.in M vdsm_reg/deployUtil.py.in 9 files changed, 109 insertions(+), 50 deletions(-) Approvals: Lei Li: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Naori <davidnaori3(a)gmail.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

6:05 a.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Dan Kenigsberg has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 10: Looks good to me, approved thanks! -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Naori <davidnaori3(a)gmail.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

lilei＠linux.vnet.ibm.com

4:07 a.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Lei Li has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 10: Verified; Looks good to me, but someone else must approve (1 inline comment) Tested on Fedora 16. .................................................... File vdsm/netinfo.py Line 141: Well, a little complex, I spent two hours trying to think out a better way for this bitmask convert but failed... : ) -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Naori <davidnaori3(a)gmail.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

Wednesday, 9 May Wed, 9 May

11:33 p.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Dan Kenigsberg has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 10: Looks good to me, but someone else must approve (1 inline comment) Thanks! .................................................... File tests/netmaskconversions Line 1: #bitmask address I do not see the great benefit of putting this in a separate file. but fine, I suppose it is a matter of taste. -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Naori <davidnaori3(a)gmail.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

4:09 p.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Dan Kenigsberg has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 9: I would prefer that you didn't submit this thanks! may I repeat my request for a simple unit test for the new bitmask_to_address() function? -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Naori <davidnaori3(a)gmail.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

Wednesday, 25 April Wed, 25 Apr

9:38 a.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Dan Kenigsberg has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 8: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/netinfo.py Line 143: netmask_hex = ((1L<<netmask)-1)<<(32-netmask) could you split this to a new function? it begs for a unit test... -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Naori <davidnaori3(a)gmail.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

davidnaori3＠gmail.com

Tuesday, 24 April Tue, 24 Apr

4:33 a.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

David Naori has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 7: Fails (1 inline comment) .................................................... File vdsm/netinfo.py Line 143: return intToAddress((1L<<netmask)-1)

...

>> intToAddress((1L<<27)-1)

'255.255.255.7' should be 255.255.255.224 -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Naori <davidnaori3(a)gmail.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

mhuntxu＠gmail.com

Sunday, 22 April Sun, 22 Apr

9:28 p.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Hunt Xu has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 7: Verified rebased -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

10:29 a.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Dan Kenigsberg has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 7: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

Dan Kenigsberg

Saturday, 21 April Sat, 21 Apr

3:54 p.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Dan Kenigsberg

Wednesday, 18 April Wed, 18 Apr

4:52 p.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Dan Kenigsberg has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

peet＠redhat.com

9:50 a.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Peter V. Saveliev has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

xiawenc＠linux.vnet.ibm.com

Tuesday, 10 April Tue, 10 Apr

9:52 p.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Wenchao Xia has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 6: Looks good to me, but someone else must approve using library is better than parsing command output, which allow the library handle the difference on different distribution. -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

lilei＠linux.vnet.ibm.com

3:22 a.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Lei Li has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

lilei＠linux.vnet.ibm.com

2:46 a.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Lei Li has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 5: Fails; I would prefer that you didn't submit this (1 inline comment) Below is a simple reproduction of the function ethtool.get_devices() issue, for the detail you can see my comment. configure a second ip adrress on an interface as: eth0 Link encap:Ethernet HWaddr 00:26:2D:F3:14:B5 inet addr:9.115.xxx.xxx Bcast:9.115.xxx.xxx Mask:255.255.255.0 inet6 addr: fe80::226:2dff:fef3:14b5/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:94196 errors:0 dropped:0 overruns:0 frame:0 TX packets:72577 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:86679258 (82.6 MiB) TX bytes:8163340 (7.7 MiB) Interrupt:20 Memory:f2600000-f2620000 eth0:1 Link encap:Ethernet HWaddr 00:26:2D:F3:14:B5 inet addr:9.115.xxx.xxx Bcast:9.115.xxx.xxx Mask:255.255.255.0 UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 Interrupt:20 Memory:f2600000-f2620000 [root@localhost network-scripts]# python Python 2.7.2 (default, Oct 27 2011, 01:40:22) [GCC 4.6.1 20111003 (Red Hat 4.6.1-10)] on linux2 Type "help", "copyright", "credits" or "license" for more information.

...

>> import ethtool >> interface = ethtool.get_devices() >> interfaces = ethtool.get_active_devices() >> interface

['lo', 'wlan0', 'eth0']

...

>> interfaces

['lo', 'eth0', 'eth0:1', 'wlan0'] .................................................... File vdsm/netinfo.py Line 298: return filter(None, [ getaddr(i) for i in ethtool.get_devices() ]) As Dan said, host may have aliases. ethtool.get_devices() can not get virtual IP addresses if they were configured on an active network interface. So I think it would be better to use the ethtool.get_active_devices() function instead. -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

smizrahi＠redhat.com

Monday, 9 April Mon, 9 Apr

8:15 p.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Saggi Mizrahi has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 5: Looks good to me, but someone else must approve I actually been wanting to do this for a long time. Good job overall. Just make sure that if no one is calling ifcofig to remove it from constants and from suduers -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

mhuntxu＠gmail.com

6:11 a.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Hunt Xu has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 3: I would prefer that you didn't submit this should remove the _IFREQ_SIZE constant, resubmit later -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com>

Dan Kenigsberg

7:09 a.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Dan Kenigsberg has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 4: I would prefer that you didn't submit this (3 inline comments) oh, and this requires some serious testing on our two major platforms. .................................................... File vdsm/netinfo.py Line 133: addr = dev_info_list[0].ipv4_address I do not understand the motivation of your comment. are you trying to explain why you cannot use ethtool.get_ipaddr() ? Line 297: "Return a list of the host's IP addresses" that's not exactly the same thing, as the host may have aliases and whatever other net devices. currently this function is not used, so you may either fix it to keep returning all addresses (directly via ethtool) or kill the function. .................................................... File vdsm_reg/deployUtil.py.in Line 350: arNICs = None leaving this here makes pyflakes cry -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com>

mhuntxu＠gmail.com

6:27 a.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Hunt Xu has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 4: Verified (3 inline comments) patch set 4 is now with python-ethtool .................................................... File vdsm/netinfo.py Line 133: addr = dev_info_list[0].ipv4_address ethtool.get_ipaddr() doesn't set errno when an IO error occurs. This makes it difficult to ignore os.errno.EADDRNOTAVAIL, which is quite ordinary for those devices that haven't been configured. Line 140: netmask = dev_info_list[0].ipv4_netmask ethtool.get_netmask() the same doesn't set errno when an IO error occurs. Line 143: return intToAddress((1L<<netmask)-1) etherinfo.ipv4_netmask is ipv4 netmask in bits, convert it to demical-dot format. -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com>

Dan Kenigsberg

3:51 a.m.

New subject: Change in vdsm[master]: replace external ifconfig cmdline with ioctl/socket and sysf...

Dan Kenigsberg has posted comments on this change. Change subject: replace external ifconfig cmdline with ioctl/socket and sysfs in netinfo ...................................................................... Patch Set 2: I would prefer that you didn't submit this we already depend on python-ethtool (see git grep ethtool). I quiver of the thought of depending on magic Linux numbers like 0x8915. If you do not mind too strongly, please use the higher-level abstraction of ethtool. We have higher obstacles than this for entry to Debian. -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com>

mhuntxu＠gmail.com

Sunday, 8 April Sun, 8 Apr

10:55 p.m.

New subject: Change in vdsm[master]: replace external ifconfig cmdline with ioctl/socket and sysf...

Hunt Xu has posted comments on this change. Change subject: replace external ifconfig cmdline with ioctl/socket and sysfs in netinfo ...................................................................... Patch Set 2: Verified @Dan, I did consider the use of python-ethtool before I use ioctl directly. However, AFAIK, not all the distributions provide this module in their official software repository(not in Debian, Archlinux, Gentoo), so I'm just trying to prevent new dependency which couldn't be easily satisfied on many other distributions. -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com>

Dan Kenigsberg

Saturday, 7 April Sat, 7 Apr

5:53 a.m.

Dan Kenigsberg has posted comments on this change. Change subject: replace extern ifconfig commandline with ioctl/socket and sysfs in netinfo ...................................................................... Patch Set 1: I would prefer that you didn't submit this (3 inline comments) Thanks for catching this issue! Please add yourself as an AUTHOR. However, I would prefer if this can be done via the python-ethtool module, instead direct ioctl calls. .................................................... File vdsm/netinfo.py Line 22: import fcntl, socket, struct to make pep8 happy, split. Line 39: IFREQ_SIZE = 40 this constant is not public, right? let's call it _IFREQ_SIZE then. Line 134: ifreq = struct.pack('%d''s' % IFREQ_SIZE, dev[:16]) is the double single quotes intentional? -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>

Dan Kenigsberg

Monday, 16 April Mon, 16 Apr

6:57 a.m.

New subject: Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

Dan Kenigsberg has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ...................................................................... Patch Set 6: Looks good to me, but someone else must approve this should be seriously verified. -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>

4379

days inactive

4413

days old

vdsm-patches@lists.fedorahosted.org

Manage subscription

24 comments

8 participants

tags (0)

participants (8)

Dan Kenigsberg
davidnaori3＠gmail.com
lilei＠linux.vnet.ibm.com
mhuntxu＠gmail.com
peet＠redhat.com
Roy Golan
smizrahi＠redhat.com
xiawenc＠linux.vnet.ibm.com

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

Change in vdsm[master]: replace extern ifconfig commandline with ioctl/socket and sy...