Dan Kenigsberg has submitted this change and it was merged.
Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo
......................................................................
replace ifconfig cmdline with ethtool and sysfs in netinfo
Since ifconfig output format has been changed recently(see
https://bugzilla.redhat.com/show_bug.cgi?id=784314), instead of parsing
ifconfig's output, use ethtool module to get ip address and netmask
of an interface, and get hardware address via
/sys/class/net/INTERFACE/address.
This makes vdsm could run normally on some bleeding edge distributions
such as Archlinux or F17 on which new version ifconfig has already been
deployed.
Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23
Signed-off-by: huntxu <mhuntxu(a)gmail.com>
---
M AUTHORS
M tests/Makefile.am
A tests/netinfoTests.py
A tests/netmaskconversions
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/netinfo.py
M vdsm_cli/vdscli.py.in
M vdsm_reg/deployUtil.py.in
9 files changed, 109 insertions(+), 50 deletions(-)
Approvals:
Lei Li: Verified; Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/3361
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <davidnaori3(a)gmail.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>