Dan Kenigsberg has posted comments on this change.
Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(3 inline comments)
oh, and this requires some serious testing on our two major platforms.
....................................................
File vdsm/netinfo.py
Line 133: addr = dev_info_list[0].ipv4_address
I do not understand the motivation of your comment. are you trying to explain why you
cannot use ethtool.get_ipaddr() ?
Line 297: "Return a list of the host's IP addresses"
that's not exactly the same thing, as the host may have aliases and whatever other net
devices.
currently this function is not used, so you may either fix it to keep returning all
addresses (directly via ethtool) or kill the function.
....................................................
File vdsm_reg/deployUtil.py.in
Line 350: arNICs = None
leaving this here makes pyflakes cry
--
To view, visit
http://gerrit.ovirt.org/3361
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com>