Dan Kenigsberg has posted comments on this change.
Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo
......................................................................
Patch Set 9: I would prefer that you didn't submit this
thanks!
may I repeat my request for a simple unit test for the new bitmask_to_address() function?
--
To view, visit
http://gerrit.ovirt.org/3361
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <davidnaori3(a)gmail.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>