Saggi Mizrahi has posted comments on this change.
Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
I actually been wanting to do this for a long time.
Good job overall.
Just make sure that if no one is calling ifcofig to remove it from constants and from
suduers
--
To view, visit
http://gerrit.ovirt.org/3361
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>