Dan Kenigsberg has posted comments on this change.
Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo
......................................................................
Patch Set 10: Looks good to me, but someone else must approve
(1 inline comment)
Thanks!
....................................................
File tests/netmaskconversions
Line 1: #bitmask address
I do not see the great benefit of putting this in a separate file. but fine, I suppose it
is a matter of taste.
--
To view, visit
http://gerrit.ovirt.org/3361
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <davidnaori3(a)gmail.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>