Eduardo Warszawski has posted comments on this change.
Change subject: BZ#732245, BZ#732269 - Handle EAGAIN and EINTR in AsyncProc.communicate
......................................................................
Patch Set 2: Do not submit
(1 inline comment)
....................................................
File vdsm/storage/misc.py
Line 865: raise
poll call timeout is indicated by an empty list that is not None.
Do you mean [] instead?
Loop on timeout result leads to a potential infinite loop.
In addition there is no escape from repeated EINTR or EAGAIN conditions.
--
To view, visit
http://gerrit.usersys.redhat.com/865
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0f8494826e9cb0debf8a9d3c9a591ac883b376
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>