Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................
Patch Set 2:
(1 comment)
....................................................
File vdsm/clientIF.py
Line 243:
Line 244: def prepareVolumePath(self, drive, vmId=None):
Line 245: if type(drive) is dict:
Line 246: # PDIV drive format
Line 247: if vm.isVdsmImage(drive):
so shouldn't it be removed from vm.py's updateDriveVolume as well?
Line 248: res = self.irs.prepareImage(
Line 249: drive['domainID'], drive['poolID'],
Line 250: drive['imageID'], drive['volumeID'])
Line 251:
--
To view, visit
http://gerrit.ovirt.org/22363
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes