Change in vdsm[master]: clientIF: Remove unnecessary device is disk check

Sergey Gotliv has uploaded a new change for review.

Change subject: clientIF: Remove unnecessary device is disk check
......................................................................

clientIF: Remove unnecessary device is disk check

Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com&gt;
---
M vdsm/clientIF.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/22363/1

diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index c083991..124f8e5 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -244,7 +244,7 @@
     def prepareVolumePath(self, drive, vmId=None):
         if type(drive) is dict:
             # PDIV drive format
-            if drive['device'] == 'disk' and vm.isVdsmImage(drive):
+            if vm.isVdsmImage(drive):
                 res = self.irs.prepareImage(
                     drive['domainID'], drive['poolID'],
                     drive['imageID'], drive['volumeID'])


-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;

Sergey Gotliv has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check
......................................................................


Patch Set 1:

(1 comment)

I will improve the commit message later.

....................................................
File vdsm/clientIF.py
Line 243: 
Line 244:     def prepareVolumePath(self, drive, vmId=None):
Line 245:         if type(drive) is dict:
Line 246:             # PDIV drive format
Line 247:             if vm.isVdsmImage(drive):
This block should check only PDIV, there is no need to check device type.
More than that if this is a PDIV => this is a disk at least right for today
Line 248:                 res = self.irs.prepareImage(
Line 249:                     drive['domainID'], drive['poolID'],
Line 250:                     drive['imageID'], drive['volumeID'])
Line 251: 


-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6067/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5280/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6170/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

Sergey Gotliv has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

I mistakenly pushed patch set 1 to draft.

-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6069/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5282/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6172/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

I like this cleanup, assuming that this check is indeed unneeded, but it is not complete.
In vm.py we always check that deive is "disk" before calling vm.isVdsmImage().
If you want to remove the check here, remove it also in vm.py.

-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

(1 comment)

....................................................
Commit Message
Line 4: Commit:     Sergey Gotliv <sgotliv(a)redhat.com&gt;
Line 5: CommitDate: 2013-12-13 11:20:25 +0200
Line 6: 
Line 7: clientIF: Remove unnecessary device is disk check in prepareVolumePath
Line 8: 
Please explain why this check is unnecessary.
Line 9: Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e


-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

Sergey Gotliv has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

I am not sure that all checks are unnecessary therefore I didn't remove them all, such
work is very time consuming and requires to perform tests so I decided to do that step by
step and this is the first step.

I choose to remove that one first as suggested by Ayal and Federico here:
http://gerrit.ovirt.org/#/c/21973/ in order to make "prepare" and
"teardown" are symmetric in the manner of how they both are treating the input
dictionary type.

-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

Michal Skrivanek has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/clientIF.py
Line 243: 
Line 244:     def prepareVolumePath(self, drive, vmId=None):
Line 245:         if type(drive) is dict:
Line 246:             # PDIV drive format
Line 247:             if vm.isVdsmImage(drive):
so shouldn't it be removed from vm.py's updateDriveVolume as well?
Line 248:                 res = self.irs.prepareImage(
Line 249:                     drive['domainID'], drive['poolID'],
Line 250:                     drive['imageID'], drive['volumeID'])
Line 251: 


-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/clientIF.py
Line 243: 
Line 244:     def prepareVolumePath(self, drive, vmId=None):
Line 245:         if type(drive) is dict:
Line 246:             # PDIV drive format
Line 247:             if vm.isVdsmImage(drive):
It should be removed everywhere, but Sergey want to fix this in small steps, limiting
verification effort.
Line 248:                 res = self.irs.prepareImage(
Line 249:                     drive['domainID'], drive['poolID'],
Line 250:                     drive['imageID'], drive['volumeID'])
Line 251: 


-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

Michal Skrivanek has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/clientIF.py
Line 243: 
Line 244:     def prepareVolumePath(self, drive, vmId=None):
Line 245:         if type(drive) is dict:
Line 246:             # PDIV drive format
Line 247:             if vm.isVdsmImage(drive):
hm, so 3rd patch anywhere? Bear in mind it then means 3 times as much verification making
it more likely to skip/omit a test case:)
Line 248:                 res = self.irs.prepareImage(
Line 249:                     drive['domainID'], drive['poolID'],
Line 250:                     drive['imageID'], drive['volumeID'])
Line 251: 


-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/clientIF.py
Line 243: 
Line 244:     def prepareVolumePath(self, drive, vmId=None):
Line 245:         if type(drive) is dict:
Line 246:             # PDIV drive format
Line 247:             if vm.isVdsmImage(drive):
I agree with you, we should better clean this up once.

If you want to handle this, the device = 'disk' thing was added in this patch:
http://gerrit.ovirt.org/2131

I don't see any reason why this was added and I also don't understand what is the
"new API" that needs this check.
Line 248:                 res = self.irs.prepareImage(
Line 249:                     drive['domainID'], drive['poolID'],
Line 250:                     drive['imageID'], drive['volumeID'])
Line 251: 


-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

Michal Skrivanek has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/clientIF.py
Line 243: 
Line 244:     def prepareVolumePath(self, drive, vmId=None):
Line 245:         if type(drive) is dict:
Line 246:             # PDIV drive format
Line 247:             if vm.isVdsmImage(drive):
ah, well, so that indeed suggests to do the change at the same time as it was added in the
same patch. Interestingly it also added the same =='disk' check to
_normalizeVdsmImg which currently has this awkward:
        if 'device' not in drv:
            drv['device'] = 'disk'
        if drv['device'] == 'disk':
            ...

which doesn't make any sense
Line 248:                 res = self.irs.prepareImage(
Line 249:                     drive['domainID'], drive['poolID'],
Line 250:                     drive['imageID'], drive['volumeID'])
Line 251: 


-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

Sergey Gotliv has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

Michal,

Please, read Ayal's comments in http://gerrit.ovirt.org/#/c/21973/, especially a part
about that removal.
In the bottom line, do you familiar with the PDIV that is not a disk? I think that the
right question is why we have this check there in the first place.

"making this method symmetric to prepare is not what this patch is about. it is about
preventing improper logging that is causing a lot of confusion for users. So symmetry can
be handled separately.
With regards to *how* it should be handled, it looks like the right thing to do is not to
add drive['device'] == 'disk' test here but rather remove it from
prepare.
In addition, prepare and teardown are not symmetrical in many other ways.
prepareVolumePath is preparing floppies, cdrom etc which teardown is not taking care of.
the 'teardown' for floppy is _cleanupFloppy etc."

-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

This patch should be simpler after a rebase. Can you rebase?

-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

Sorry, wrong patch :-)

-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

Ayal Baron has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2: Code-Review+2

This patch is fine, the discussion about yes or no removing more code elsewhere is besides
the point.  This patch is blocking http://gerrit.ovirt.org/#/c/21973 and is the sole
reason why this patch exists.

-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

Verify?

-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

Itamar Heim has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

ping

-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)gmail.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

Itamar Heim has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

why not verified so it can be merged?

-- 
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)gmail.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

[Jenkins CI RO]

Jenkins CI RO has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/22363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)gmail.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-HasComments: No

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/22363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)gmail.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;

Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...

automation(a)ovirt.org has posted comments on this change.

Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/22363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)gmail.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No