Bala.FA has posted comments on this change.
Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................
Patch Set 26: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/17644/26/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:
Line 1342: userName
have userName as remoteUserName
Line 1361: userName
1. same as above.
2. applicable to api.py and other places too
3. in what version of glusterfs is this feature available? you should set correct version
in the spec file as well
--
To view, visit
https://gerrit.ovirt.org/17644
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes